Re: [OAUTH-WG] Fwd: [Technical Errata Reported] RFC5849 (2550)

Eran Hammer-Lahav <eran@hueniverse.com> Fri, 28 January 2011 00:22 UTC

Return-Path: <eran@hueniverse.com>
X-Original-To: oauth@core3.amsl.com
Delivered-To: oauth@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id DDF303A6AFD for <oauth@core3.amsl.com>; Thu, 27 Jan 2011 16:22:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.503
X-Spam-Level:
X-Spam-Status: No, score=-2.503 tagged_above=-999 required=5 tests=[AWL=-0.038, BAYES_00=-2.599, HTTP_ESCAPED_HOST=0.134]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D8hqkg6oRkWs for <oauth@core3.amsl.com>; Thu, 27 Jan 2011 16:22:29 -0800 (PST)
Received: from p3plex1out01.prod.phx3.secureserver.net (p3plex1out01.prod.phx3.secureserver.net [72.167.180.17]) by core3.amsl.com (Postfix) with SMTP id DAA4C3A6AED for <oauth@ietf.org>; Thu, 27 Jan 2011 16:22:25 -0800 (PST)
Received: (qmail 8207 invoked from network); 28 Jan 2011 00:24:34 -0000
Received: from unknown (HELO smtp.ex1.secureserver.net) (72.167.180.21) by p3plex1out01.prod.phx3.secureserver.net with SMTP; 28 Jan 2011 00:24:33 -0000
Received: from P3PW5EX1MB01.EX1.SECURESERVER.NET ([10.6.135.19]) by P3PW5EX1HT003.EX1.SECURESERVER.NET ([72.167.180.21]) with mapi; Thu, 27 Jan 2011 17:24:30 -0700
From: Eran Hammer-Lahav <eran@hueniverse.com>
To: Peter Saint-Andre <stpeter@stpeter.im>, OAuth WG <oauth@ietf.org>
Date: Thu, 27 Jan 2011 17:24:10 -0700
Thread-Topic: [OAUTH-WG] Fwd: [Technical Errata Reported] RFC5849 (2550)
Thread-Index: AcuHkQ+gWSYSnMk+Qve09zMEiDkrFA28IR0w
Message-ID: <90C41DD21FB7C64BB94121FBBC2E723445A8FB27F9@P3PW5EX1MB01.EX1.SECURESERVER.NET>
References: <4CE5E01F.1020207@stpeter.im>
In-Reply-To: <4CE5E01F.1020207@stpeter.im>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Subject: Re: [OAUTH-WG] Fwd: [Technical Errata Reported] RFC5849 (2550)
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jan 2011 00:22:30 -0000

Verified as correct.

EHL

> -----Original Message-----
> From: oauth-bounces@ietf.org [mailto:oauth-bounces@ietf.org] On Behalf
> Of Peter Saint-Andre
> Sent: Thursday, November 18, 2010 6:26 PM
> To: OAuth WG
> Subject: [OAUTH-WG] Fwd: [Technical Errata Reported] RFC5849 (2550)
> 
> Folks, is this erratum accurate?
> 
> 
> -------- Original Message --------
> Subject: [Technical Errata Reported] RFC5849 (2550)
> Date: Tue, 12 Oct 2010 09:42:17 -0700 (PDT)
> From: RFC Errata System <rfc-editor@rfc-editor.org>
> To: eran@hueniverse.com, iesg@iesg.org
> CC: alasdair@lovefilm.com, rfc-editor@rfc-editor.org
> 
> 
> The following errata report has been submitted for RFC5849, "The OAuth 1.0
> Protocol".
> 
> --------------------------------------
> You may review the report below and at:
> http://www.rfc-editor.org/errata_search.php?rfc=5849&eid=2550
> 
> --------------------------------------
> Type: Technical
> Reported by: Alasdair McIntyre <alasdair@lovefilm.com>
> 
> Section: GLOBAL
> 
> Original Text
> -------------
> Section 3.1
> oauth_signature="bYT5CMsGcbgUdFHObYMEfcx6bsw%3D"
> 
> Section 3.4.1.1
> oauth_signature="bYT5CMsGcbgUdFHObYMEfcx6bsw%3D"
> 
> Section 3.4.1.3.1
> oauth_signature="djosJKDKJSD8743243%2Fjdk33klY%3D"
> 
> 
> 
> Corrected Text
> --------------
> Section 3.1
> oauth_signature="r6%2FTJjbCOr97%2F%2BUU0NsvSne7s5g%3D"
> 
> Section 3.4.1.1
> oauth_signature="r6%2FTJjbCOr97%2F%2BUU0NsvSne7s5g%3D"
> 
> Section 3.4.1.3.1
> oauth_signature="r6%2FTJjbCOr97%2F%2BUU0NsvSne7s5g%3D"
> 
> 
> Notes
> -----
> (Apologies - this supercedes Errata ID 2549).
> 
> The signatures in sections 3.1, 3.4.1.1, and 3.4.1.3.1 of the RFC have
> mistakenly been calculated as if with "GET". I have supplied the correct
> "POST" signatures in the corrected text.
> 
> For reference, here is the perl script I used to calculate the signatures:
> 
> #!/usr/bin/perl
> use strict;
> use warnings;
> use Digest::HMAC_SHA1;
> use URI::Escape;
> use MIME::Base64;
> 
> my $unsafe = '^-._~A-Za-z0-9';
> my $client_secret = 'j49sk3j29djd';
> my $token_secret = 'dh893hdasih9';
> my $key = join('&', $client_secret, $token_secret);
> 
> my $uri_base = 'http%3A%2F%2Fexample.com%2Frequest';
> my $params = join('', qw(
>     a2%3Dr%2520b%26a3%3D2%2520q%26a3%3Da%26b5%3D
>     %253D%25253D%26c%2540%3D%26c2%3D%26oauth_con
>     sumer_key%3D9djdj82h48djs9d2%26oauth_nonce%3
>     D7d8f3e4a%26oauth_signature_method%3DHMAC-SH
>     A1%26oauth_timestamp%3D137131201%26oauth_tok
>     en%3Dkkk9d7dh3k39sjv7
> ));
> 
> foreach my $method ('GET', 'POST') {
>     my $base_sig = join('&', $method, $uri_base, $params);
>     my $bin_sig = Digest::HMAC_SHA1::hmac_sha1($base_sig, $key);
>     my $b64_sig = MIME::Base64::encode_base64($bin_sig, '');
>     my $enc_sig = URI::Escape::uri_escape($b64_sig, $unsafe);
>     printf "%-8s %s\n", $method, $enc_sig; }
> 
> Instructions:
> -------------
> This errata is currently posted as "Reported". If necessary, please use "Reply
> All" to discuss whether it should be verified or rejected. When a decision is
> reached, the verifying party (IESG) can log in to change the status and edit
> the report, if necessary.
> 
> --------------------------------------
> RFC5849 (draft-hammer-oauth-10)
> --------------------------------------
> Title               : The OAuth 1.0 Protocol
> Publication Date    : April 2010
> Author(s)           : E. Hammer-Lahav, Ed.
> Category            : INFORMATIONAL
> Source              : IETF - NON WORKING GROUP
> Area                : N/A
> Stream              : IETF
> Verifying Party     : IESG