Re: [OAUTH-WG] Rename callback => callback_uri

Luke Shepard <lshepard@facebook.com> Thu, 15 April 2010 21:41 UTC

Return-Path: <lshepard@facebook.com>
X-Original-To: oauth@core3.amsl.com
Delivered-To: oauth@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id D0EF43A68C3 for <oauth@core3.amsl.com>; Thu, 15 Apr 2010 14:41:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.959
X-Spam-Level:
X-Spam-Status: No, score=-2.959 tagged_above=-999 required=5 tests=[AWL=0.305, BAYES_00=-2.599, HTML_MESSAGE=0.001, IP_NOT_FRIENDLY=0.334, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tu+XWvJB6IPt for <oauth@core3.amsl.com>; Thu, 15 Apr 2010 14:41:51 -0700 (PDT)
Received: from mailout-sf2p.facebook.com (mailout-snc1.facebook.com [69.63.179.25]) by core3.amsl.com (Postfix) with ESMTP id 93CE73A68F7 for <oauth@ietf.org>; Thu, 15 Apr 2010 14:41:51 -0700 (PDT)
Received: from mail.thefacebook.com ([192.168.18.212]) by pp02.snc1.tfbnw.net (8.14.3/8.14.3) with ESMTP id o3FLf7Q5006865 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 15 Apr 2010 14:41:07 -0700
Received: from sc-hub01.TheFacebook.com (192.168.18.104) by sc-hub04.TheFacebook.com (192.168.18.212) with Microsoft SMTP Server (TLS) id 14.0.689.0; Thu, 15 Apr 2010 14:41:41 -0700
Received: from SC-MBXC1.TheFacebook.com ([192.168.18.102]) by sc-hub01.TheFacebook.com ([192.168.18.104]) with mapi; Thu, 15 Apr 2010 14:41:41 -0700
From: Luke Shepard <lshepard@facebook.com>
To: Eran Hammer-Lahav <eran@hueniverse.com>, Naitik Shah <naitik@facebook.com>, OAuth WG <oauth@ietf.org>
Date: Thu, 15 Apr 2010 14:41:39 -0700
Thread-Topic: [OAUTH-WG] Rename callback => callback_uri
Thread-Index: AcrY5QgYzwsqKHvhTbuKpWjgY2XeCgDs1DqnABLzoxA=
Message-ID: <2513A610118CC14C8E622C376C8DEC93D54D66DCA7@SC-MBXC1.TheFacebook.com>
References: <9C30AE64-7DB8-4B6B-879B-61CB71BF74BB@facebook.com> <C7EC567E.322EE%eran@hueniverse.com>
In-Reply-To: <C7EC567E.322EE%eran@hueniverse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: multipart/alternative; boundary="_000_2513A610118CC14C8E622C376C8DEC93D54D66DCA7SCMBXC1TheFac_"
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2010-04-15_15:2010-02-06, 2010-04-15, 2010-04-15 signatures=0
Subject: Re: [OAUTH-WG] Rename callback => callback_uri
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2010 21:41:55 -0000

We already had one developer try it out and get confused because the server tried to treat the callback URL as a JSONP callback.

The protected resource typically accepts "callback" as a parameter to support JSONP. If a developer accidentally passes in callback there (maybe they got confused) then the server can't give a normal error message - instead it needs to either detect that it looks like a URL or otherwise reject it.

On a related note, I think it's more confusing calling it something different in the user-agent flow (redirector) when it's essentially doing the same thing.


From: oauth-bounces@ietf.org [mailto:oauth-bounces@ietf.org] On Behalf Of Eran Hammer-Lahav
Sent: Thursday, April 15, 2010 5:37 AM
To: Naitik Shah; OAuth WG
Subject: Re: [OAUTH-WG] Rename callback => callback_uri

I don't think it is that confusing. Its a completely different context from where JSON-P is used (note that in the User-Agent flow it is called something else).

EHL


On 4/10/10 12:35 PM, "Naitik Shah" <naitik@facebook.com> wrote:
With the simplified params, the callback url parameter is now just "callback". Since most major API providers already use "callback" to signify JSON-P callback, can we rename this to "callback_uri"? This will help avoid collisions and confusion.


-Naitik
_______________________________________________
OAuth mailing list
OAuth@ietf.org
https://www.ietf.org/mailman/listinfo/oauth