[OAUTH-WG] Re: [Technical Errata Reported] RFC7519 (8060)

Brian Campbell <bcampbell@pingidentity.com> Fri, 07 February 2025 19:42 UTC

Return-Path: <bcampbell@pingidentity.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61B51C360BD4 for <oauth@ietfa.amsl.com>; Fri, 7 Feb 2025 11:42:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.102
X-Spam-Level:
X-Spam-Status: No, score=-2.102 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=pingidentity.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s2Hy1hrlkYgE for <oauth@ietfa.amsl.com>; Fri, 7 Feb 2025 11:42:21 -0800 (PST)
Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A0A88C344BBE for <oauth@ietf.org>; Fri, 7 Feb 2025 11:42:21 -0800 (PST)
Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-8671441a730so60917241.0 for <oauth@ietf.org>; Fri, 07 Feb 2025 11:42:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pingidentity.com; s=google; t=1738957340; x=1739562140; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=w0DKEazNwnVx7oLihaK4ReBG5BC042xf5k1nUUEUmak=; b=ZDIi0clSU2qFr1lTRhmIZr1us8DyviQt6aD0drM22GA3WhfrppU9yyEjgn+wGMwGXf V/u6uiGo3FZv6c5fGCrrvkBLglje0kRMVPQWZJM4EKKudU/hbxFIeWnUyzPny/tpdatB HsACz61p5yUrSrNdS1ZnozY8qfUSMfFzKt+M8CzzrTCXXRCAKyGW+zSiZ9XsCQ9zUFcL pMN1H8LVG878XtQA3FPzqF1pOtolc49HY0tIkEbkwVrzUKYVX1EVVJM48ake4ChW3JoL M2CMoACp3XZtfgE4Lrnygnjn24lpQuuLY9pixhj+YNUoCaprCNIamgNlWWMEKTTW0hrm Xf9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738957340; x=1739562140; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w0DKEazNwnVx7oLihaK4ReBG5BC042xf5k1nUUEUmak=; b=L5nUsZ7y2vC4d7T39730vqWFIySmcjWWnQXjLBBYzxCMJh56koAFzNEkFwDYBa8rjH +ucrNA0f4RqAnsxrUPqDTGA0WlBWWzi/FMjpWAsP44joyAj14EPpmo8d13HTNUpmd5nM ulCO5JSjlSRB9TnVmEXWOgb8slekGrdSxm26k4VPBeBOGYqGUoU5dW8YotMu3QyF/mip AldeN1fdWGiPVZ+2lk6NjwHJv7SYCcfP7LLNoIWr5VzziIH7QOU+cicuhoU9J+kLV1UF JhDWl7mVvMbYyRpLIt5VMoplD4O7O7ESUib0/bOBS0vxUb8deHUqeo6NJhMyqlMrizA2 YdtA==
X-Gm-Message-State: AOJu0YxRD7JoFN6DbJXOtGzqaGm62MpCge781SMGhhD9KFcVlcXABhn2 l4Ed8+IgKf9DoZ+hUgLCyV1usi5ggDPohF31O5AEk7j3LCmJ/DoFvkqKfnChzPGHFm+uuZWt5/9 ZkG+vgCXdjGpdYEmap5C3Mts5spCWt5+2Blluu3WeJb/eb+VTtGm0iGMxAAT5cYro6FHzHkd+8+ OwYxbhAVO+hz2+tvsKIwZymDQYe3o6
X-Gm-Gg: ASbGnctCR9njc/+EnZXud+5SiUCKAzSescBLNJbj5BWCK/+Xkb0pK6VkzxrBFAdwkLR cmwo46TckuQQgyVa+pKSTtq7gEaPac+w5jIGXHODc59BuwXJfTpIYWt6YyZnvWdtCh1IfCo9CNA ==
X-Google-Smtp-Source: AGHT+IGd1VeM7CNbtovIEA7Bs5M5ihG29rViItBljb/lriHIApbugh7VyoYn7PdAFdY3zcvU6OotyQGyY18FWiohOuk=
X-Received: by 2002:a05:6122:794:b0:51c:c23e:8cd6 with SMTP id 71dfb90a1353d-51f2e1d9b57mr4677849e0c.6.1738957340298; Fri, 07 Feb 2025 11:42:20 -0800 (PST)
MIME-Version: 1.0
References: <CALtWOA3-T-48T8Vp3Na45NgxuUApYrHt9GcFq_KyF9B8xkkuVA@mail.gmail.com>
In-Reply-To: <CALtWOA3-T-48T8Vp3Na45NgxuUApYrHt9GcFq_KyF9B8xkkuVA@mail.gmail.com>
From: Brian Campbell <bcampbell@pingidentity.com>
Date: Fri, 07 Feb 2025 19:41:51 +0000
X-Gm-Features: AWEUYZlCW-s5vbl-eennuSHIbIiCi_pecB9UdS7yNjWtstuV7d2nZaJZP0kyPgM
Message-ID: <CA+k3eCThwcY3Xxiv+7ns8sJe_8HbrOG3gu5JUgMFr2yZN7aU+A@mail.gmail.com>
To: Pieter Kasselman <pieter@spirl.com>
Content-Type: multipart/alternative; boundary="0000000000008c6a13062d928e0a"
Message-ID-Hash: M4ZHRAW6DXFYSR3PR5NSCGV7VKFJ4GSO
X-Message-ID-Hash: M4ZHRAW6DXFYSR3PR5NSCGV7VKFJ4GSO
X-MailFrom: bcampbell@pingidentity.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-oauth.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: oauth <oauth@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [OAUTH-WG] Re: [Technical Errata Reported] RFC7519 (8060)
List-Id: OAUTH WG <oauth.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/2GE7LEKG0lMeKlGJfEQdOLtYxJk>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Owner: <mailto:oauth-owner@ietf.org>
List-Post: <mailto:oauth@ietf.org>
List-Subscribe: <mailto:oauth-join@ietf.org>
List-Unsubscribe: <mailto:oauth-leave@ietf.org>

Apologies Pieter, this fell "below the fold" in my inbox so to speak and I
lost track of responding to it. Thanks for the proposed new "notes" for the
errata, which I do think are sufficient now. In conjunction with that
simple "corrected text" you had of "5.  Verify the resulting JOSE Header
according to RFC7515 or RFC7516."

On Thu, Nov 21, 2024 at 8:25 PM Pieter Kasselman <pieter@spirl.com> wrote:

> Brian, as discussed at IETF 121, it would be good to wrap up on this errata. Is the below sufficient, or are there additional refinements or steps to take?
>
> Cheers
>
> Pieter
>
> --------------------------------
>
> Hi Brian, agreed, and thanks for pointing that out. Suggestion below:
>
>
>
> Notes
> -----
> Validation step 5 in section 7.2 of RFC 7519 states that header parameters should only be ignored if they are explicitly specified as needing to be ignored.
>
> This is contrary to step 7 in section 7.2 of RFC 7519 which requires that the processing rules of RFC 7515 should be followed if the JWT is a JWS, or the rules of RFC7516 should be followed if the JWT is a JWE. Neither RFC 7515 nor RFC 7516 include any special provisions for only ignoring header parameters if they are specified as being ignored, but instead requires all header parameters to be ignored if they are not understood, except if they are critical.
>
> This errata clarifies that JOSE Header parameters should be verified according to RFC7515 (JWS) or RFC7516 (JWE).
>
>
>
>
> From: Brian Campbell <bcampbell=40pingidentity.com@dmarc.ietf.org> <&lt;bcampbell=40pingidentity.com@dmarc.ietf.org&gt;>
> Sent: Monday 12 August 2024 19:46
> To: Pieter Kasselman <pieter.kasselman@microsoft.com> <&lt;pieter.kasselman@microsoft.com&gt;>
> Cc: David Waite <david@alkaline-solutions.com> <&lt;david@alkaline-solutions.com&gt;>; Paul Wouters <paul.wouters@aiven.io> <&lt;paul.wouters@aiven.io&gt;>; RFC Errata System <rfc-editor@rfc-editor.org> <&lt;rfc-editor@rfc-editor.org&gt;>; prkasselman@gmail.com; oauth@ietf.org
> Subject: Re: [OAUTH-WG] Re: [Technical Errata Reported] RFC7519 (8060)
>
> Thanks Pieter,
>
> That sounds good to me. I think a bit of the explanatory text in the "Notes" part of the errata likely needs to be adjusted accordingly too.
>
>
>
> On Mon, Aug 12, 2024 at 5:01 AM Pieter Kasselman <pieter.kasselman=40microsoft.com@dmarc.ietf.org<mailto:40microsoft.com@dmarc.ietf.org>> wrote:
> Thanks David and Brian.
>
> Unless there are any concerns with adopting the alternative text, I would suggest the following for the errata in section 7.2 bullet 5:
>
> Original Text
> -------------
>    5.   Verify that the resulting JOSE Header includes only parameters
>         and values whose syntax and semantics are both understood and
>         supported or that are specified as being ignored when not
>         understood.
>
> Corrected Text
> --------------
>    5.  Verify the resulting JOSE Header according to RFC7515 or RFC7516.
>
> Cheers
>
> Pieter
>
> From: David Waite <david=40alkaline-solutions.com@dmarc.ietf.org<mailto:40alkaline-solutions.com@dmarc.ietf.org>>
> Sent: Monday 5 August 2024 22:43
> To: Pieter Kasselman <pieter.kasselman=40microsoft.com@dmarc.ietf.org<mailto:40microsoft.com@dmarc.ietf.org>>
> Cc: Paul Wouters <paul.wouters=40aiven.io@dmarc.ietf.org<mailto:40aiven.io@dmarc.ietf.org>>; RFC Errata System <rfc-editor@rfc-editor.org<mailto:rfc-editor@rfc-editor.org>>; prkasselman@gmail.com<mailto:prkasselman@gmail.com>; oauth@ietf.org<mailto:oauth@ietf.org>
> Subject: [OAUTH-WG] Re: [Technical Errata Reported] RFC7519 (8060)
>
>
>
> On Aug 5, 2024, at 1:52 PM, Pieter Kasselman <pieter.kasselman=40microsoft.com@dmarc.ietf.org<mailto:pieter.kasselman=40microsoft.com@dmarc.ietf.org>> wrote:
>
> I tried to keep the changes to additional text that would scope the processing rules more precisely for the JWT/JWS/JWE cases (point 7 in the processing steps references JWS and JWE separately, so thought I would propose text that does something similar to that). The idea of additional text is that a reader who is familiar may find it easier to process the delta.
>
> However, if we want to change the text, I like your second option:
>
> "Verify the resulting JOSE Header according to RFC7515 or RFC7516."
>
> I don’t think we should delete the bullet completely.
>
> Cheers
>
> Pieter
>
> I prefer this over the current text, which might be incorrectly construed to provide counter guidance to the “crit” protected header parameter.
>
> -DW
> _______________________________________________
> OAuth mailing list -- oauth@ietf.org<mailto:oauth@ietf.org>
> To unsubscribe send an email to oauth-leave@ietf.org<mailto:oauth-leave@ietf.org>
>
> CONFIDENTIALITY NOTICE: This email may contain confidential and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited.  If you have received this communication in error, please notify the sender immediately by e-mail and delete the message and any file attachments from your computer. Thank you.
>
>
>
>
>
>

-- 
_CONFIDENTIALITY NOTICE: This email may contain confidential and privileged 
material for the sole use of the intended recipient(s). Any review, use, 
distribution or disclosure by others is strictly prohibited.  If you have 
received this communication in error, please notify the sender immediately 
by e-mail and delete the message and any file attachments from your 
computer. Thank you._