Re: [OAUTH-WG] WGLC review of OAuth 2.0 Security Best Current Practice by Mike Jones

Daniel Fett <fett@danielfett.de> Wed, 22 January 2020 14:35 UTC

Return-Path: <fett@danielfett.de>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 337971207FF for <oauth@ietfa.amsl.com>; Wed, 22 Jan 2020 06:35:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=danielfett.de
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YDYaRzUl20aS for <oauth@ietfa.amsl.com>; Wed, 22 Jan 2020 06:35:08 -0800 (PST)
Received: from d3f.me (redstone.d3f.me [5.9.29.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 33C26120103 for <oauth@ietf.org>; Wed, 22 Jan 2020 06:35:08 -0800 (PST)
Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by d3f.me (Postfix) with ESMTPA id 4D11E19CBA; Wed, 22 Jan 2020 14:35:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=danielfett.de; s=dkim; t=1579703703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O/ASlC9RnI5WZYy27qG2cW5Yon2bAFT3BEk/NHqfwz0=; b=uRDooMl1z8Pi5LtGx6V8ZM0KDX4pbNnoj+66uRLKc0sOuv+GAk0etNL7N/JTIJkn4lwIIf GpJOyqv9aF8RDxa5fO380QjFM4Bxnh4l5P3muFkPw4dWJt/PM5kVoF5T836O0xRJGVKRl2 mGoecpxY74ex03/A+Pa4qpVi10Sehrw=
To: Mike Jones <Michael.Jones@microsoft.com>, "oauth@ietf.org" <oauth@ietf.org>
Cc: "torsten@lodderstedt.net" <torsten@lodderstedt.net>, "ve7jtb@gmail.com" <ve7jtb@gmail.com>, 'Andrey Labunets' <isciurus@fb.com>
References: <BN8PR00MB056369C04536770FF5B90512F54F0@BN8PR00MB0563.namprd00.prod.outlook.com>
From: Daniel Fett <fett@danielfett.de>
Message-ID: <41ba813f-b6d8-ce82-a108-f53b35fc40a9@danielfett.de>
Date: Wed, 22 Jan 2020 15:35:02 +0100
MIME-Version: 1.0
In-Reply-To: <BN8PR00MB056369C04536770FF5B90512F54F0@BN8PR00MB0563.namprd00.prod.outlook.com>
Content-Type: multipart/alternative; boundary="------------4034793D8BD06ADD5F1F1BA0"
Content-Language: de-DE
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=danielfett.de; s=dkim; t=1579703703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O/ASlC9RnI5WZYy27qG2cW5Yon2bAFT3BEk/NHqfwz0=; b=bMdaW7ftOAsd0/PuURNLG9c57tYCtnojUtMb82BzjARS17in1/94dWUF5A+HBayIpUiZks hitSelHIOE9M+fcgYeohCD4tTqK5a/VwKMkSaYlLCRYTUqyBcdbkb8Y2dKdTFCBirVex02 PgJfS0b6x+n4Vi3l2VHeeEwF5D3divY=
ARC-Seal: i=1; s=dkim; d=danielfett.de; t=1579703703; a=rsa-sha256; cv=none; b=U0voHqPHwRHh9YdjSLfF2KFuDZIAMh01BTt0XoEZVQ9Iev+FpzW0oBErvbiaYlhedAq4FJEKrc0ZBzpxzQQ/KhepCH1s5mLzOUZGJ4Mv+41JQ3QKuHzcr28oozYgrl2UFHXbVp7hMUkuDUeUgAjt8brPTpx70g8f2lUt6D3z5wQ=
ARC-Authentication-Results: i=1; d3f.me; auth=pass smtp.auth=fett@danielfett.de smtp.mailfrom=fett@danielfett.de
Authentication-Results: d3f.me; auth=pass smtp.auth=fett@danielfett.de smtp.mailfrom=fett@danielfett.de
X-Spamd-Bar: /
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/5XdQFk52K2voavs66bz88gOMx64>
Subject: Re: [OAUTH-WG] WGLC review of OAuth 2.0 Security Best Current Practice by Mike Jones
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2020 14:35:14 -0000

Thanks for your feedback, Mike! I have two questions below:

Am 20.11.19 um 04:40 schrieb Mike Jones:
>
> I did a complete read of draft-ietf-oauth-security-topics-13
> <https://tools.ietf.org/html/draft-ietf-oauth-security-topics-13>.  My
> review comments follow, divided into substantive and editorial sections.
>
>  
>
> SUBSTANTIVE
>
>  
>
> 3.1.2. Implicit Grant – The statement “no viable mechanism exists to
> cryptographically bind access tokens issued in the authorization
> response to a certain client” isn’t actually true.  Please describe
> how the OpenID Connect ID Token achieves this for the “id_token token”
> and “code id_token token” response types via the “at_hash” claim in
> this paragraph, and appropriately qualify the unconditional statement
> cited.

How does the at_hash in the ID token bind the token to the client? I do
see that the client would not accept a token issued for another client.
What is discussed here, however, is that a malicious resource server
could use the token at another resource server. This is not prevented,
or is it?


> 4.8.1.3. Audience Restricted Access Tokens, next to last paragraph –
> When you list MTLS, also please state that the MTLS key can be used as
> a correlation handle, since it is the same for connections to all sites.
>
Wouldn't it be up to the client to use or not use the same key for
multiple sites? Also, what would be the impact of correlation here?