Re: [OAUTH-WG] ABNF in draft 11

"Manger, James H" <James.H.Manger@team.telstra.com> Thu, 25 November 2010 23:51 UTC

Return-Path: <James.H.Manger@team.telstra.com>
X-Original-To: oauth@core3.amsl.com
Delivered-To: oauth@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 9F0B03A6A91 for <oauth@core3.amsl.com>; Thu, 25 Nov 2010 15:51:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.113
X-Spam-Level:
X-Spam-Status: No, score=-1.113 tagged_above=-999 required=5 tests=[AWL=-0.212, BAYES_00=-2.599, HELO_EQ_AU=0.377, HOST_EQ_AU=0.327, RELAY_IS_203=0.994]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zoeJ93qiAks2 for <oauth@core3.amsl.com>; Thu, 25 Nov 2010 15:51:07 -0800 (PST)
Received: from ipxbvo.tcif.telstra.com.au (ipxbvo.tcif.telstra.com.au [203.35.135.204]) by core3.amsl.com (Postfix) with ESMTP id 8D9F73A6997 for <oauth@ietf.org>; Thu, 25 Nov 2010 15:51:05 -0800 (PST)
X-IronPort-AV: E=Sophos;i="4.59,257,1288530000"; d="scan'208";a="18405107"
Received: from unknown (HELO ipcavi.tcif.telstra.com.au) ([10.97.217.200]) by ipobvi.tcif.telstra.com.au with ESMTP; 26 Nov 2010 10:52:06 +1100
X-IronPort-AV: E=McAfee;i="5400,1158,6178"; a="14041398"
Received: from wsmsg3707.srv.dir.telstra.com ([172.49.40.81]) by ipcavi.tcif.telstra.com.au with ESMTP; 26 Nov 2010 10:52:06 +1100
Received: from WSMSG3153V.srv.dir.telstra.com ([172.49.40.159]) by wsmsg3707.srv.dir.telstra.com ([172.49.40.81]) with mapi; Fri, 26 Nov 2010 09:52:05 +1000
From: "Manger, James H" <James.H.Manger@team.telstra.com>
To: Eran Hammer-Lahav <eran@hueniverse.com>, OAuth WG <oauth@ietf.org>
Date: Fri, 26 Nov 2010 09:52:03 +1000
Thread-Topic: ABNF in draft 11
Thread-Index: AcuLrE0WNL4CckMHSC6Rvg1Kh0kB/QArB9ZgAATzm+AAITzOwA==
Message-ID: <255B9BB34FB7D647A506DC292726F6E11278AB64E4@WSMSG3153V.srv.dir.telstra.com>
References: <90C41DD21FB7C64BB94121FBBC2E72343D4AE3B191@P3PW5EX1MB01.EX1.SECURESERVER.NET> <255B9BB34FB7D647A506DC292726F6E112789E5CDD@WSMSG3153V.srv.dir.telstra.com> <90C41DD21FB7C64BB94121FBBC2E72343D4B06532C@P3PW5EX1MB01.EX1.SECURESERVER.NET>
In-Reply-To: <90C41DD21FB7C64BB94121FBBC2E72343D4B06532C@P3PW5EX1MB01.EX1.SECURESERVER.NET>
Accept-Language: en-US, en-AU
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US, en-AU
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [OAUTH-WG] ABNF in draft 11
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Nov 2010 23:51:07 -0000

This is better.

<scope> is not quite correct as the right-hand side is not quite a subset of <quoted-string> since <quoted-char> allows "\" as a character, instead of treating it as an escape character.
Option 1: remove "\" from <quoted-char>
Option 2: define <scope> as <"scope" "=" quoted-string>, and in the following paragraph say the "scope" attribute is a space-separated list of individual scope values -- more precisely, individual scope values are separated by <RWS> (and consequently cannot contain <RWS>).

I prefer option 2.


"WWW-Authenticate: OAuth2" is not strictly valid because it doesn't have a space <RWS> after the scheme.
RFC2617 and draft-ietf-httpbis-p7-auth-12 actually uses <1*SP>, instead of <RWS> in the generic definition of <challenge>.

Option 3: <challenge = "OAuth2" 1*SP 1#param>
          Add realm to <param>; add back paragraph saying the mandatory "realm" attribute allows protected resources on a server to be partitioned, as specified in RFC2617. Don't bother with any extra explanation.

Option 4: <challenge = "OAuth2" [ 1*SP #param ]>
          Add a paragraph explicitly saying this scheme does not quite obey the generic rules for schemes defined in RFC2617 because it does not require a "realm" parameter or, in fact, any parameters.

I prefer option 4, despite believing "realm" has some value. Most servers will have a single protection space (=realm), plus NTLM and Negotiate schemes already omit "realm", so I think disobeying RFC2617 here is ok (and fixing draft-ietf-httpbis-p7-auth-12).


<URI-Reference> should be
<URI-reference>


--
James Manger