Re: [OAUTH-WG] scp claim in draft-ietf-oauth-token-exchange-12

Mike Jones <Michael.Jones@microsoft.com> Mon, 23 April 2018 19:23 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F236D12D810 for <oauth@ietfa.amsl.com>; Mon, 23 Apr 2018 12:23:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.011
X-Spam-Level:
X-Spam-Status: No, score=-2.011 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WPeu2kCMlU48 for <oauth@ietfa.amsl.com>; Mon, 23 Apr 2018 12:23:43 -0700 (PDT)
Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0127.outbound.protection.outlook.com [104.47.32.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B5BFF126B6E for <oauth@ietf.org>; Mon, 23 Apr 2018 12:23:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EXr/ggEUPSyhDE3x7Fc2QaZXF5LAID/5AB2lVFsRH/A=; b=JYUsF4yBEZJS1ogEVubZYloUrxGGWeuExm2W+b+nqxj0Y+TwT5vuaXvSTPZ/3Ma43WvolTdHnHwy4Y6CCrRuQuVApei3gDCKsxhZoQu9X9aD+pvIiBNqUMlZ2XfLe74FuV99iUxDKLwj8f3jwfcLR6UPdfVDrm5dGL6yeJY5AOU=
Received: from DM5PR00MB0296.namprd00.prod.outlook.com (2603:10b6:4:9e::37) by DM5PR00MB0294.namprd00.prod.outlook.com (2603:10b6:4:9e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.744.0; Mon, 23 Apr 2018 19:23:40 +0000
Received: from DM5PR00MB0296.namprd00.prod.outlook.com ([fe80::e0eb:d2f7:29c5:1a1b]) by DM5PR00MB0296.namprd00.prod.outlook.com ([fe80::e0eb:d2f7:29c5:1a1b%2]) with mapi id 15.20.0747.000; Mon, 23 Apr 2018 19:23:40 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Brian Campbell <bcampbell@pingidentity.com>, Torsten Lodderstedt <torsten@lodderstedt.net>
CC: oauth <oauth@ietf.org>
Thread-Topic: [OAUTH-WG] scp claim in draft-ietf-oauth-token-exchange-12
Thread-Index: AQHT1NjgJy8mHwoFFk6XUY9K9SCN+aQGpvqAgACAzaCAAPXeAIAGpvWAgAAC18A=
Date: Mon, 23 Apr 2018 19:23:40 +0000
Message-ID: <DM5PR00MB0296E9493BA61BEDAA24B73BF5890@DM5PR00MB0296.namprd00.prod.outlook.com>
References: <C1972A3F-98FD-44FF-8090-2C141A801F76@lodderstedt.net> <CA+k3eCTsewdV_pHpV-WSbE39y7nN9x0tVch0-E3+sE6R2Wpwtw@mail.gmail.com> <MW2PR00MB029825EA57103F4FFD0DB57DF5B60@MW2PR00MB0298.namprd00.prod.outlook.com> <99725E0A-45F8-4E5C-8AAF-6F6C38110F2A@lodderstedt.net> <CA+k3eCRZ9PZkQxoH2Jms1pQ4+rPH05nGaP3gjjDc=vNJ+J_f-w@mail.gmail.com>
In-Reply-To: <CA+k3eCRZ9PZkQxoH2Jms1pQ4+rPH05nGaP3gjjDc=vNJ+J_f-w@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mbj@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-04-23T19:23:39.1561280Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General
x-originating-ip: [2001:4898:80e8:6::36]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DM5PR00MB0294; 7:KV3v9++lAPrZNC1QNnHkL47uvrpDRPC92DB7TQip4+VrsDapenKsA4fbrDsMRtdzlx6AMe8wU7elohmn+y3ppWU3QTbCQu9zgx4vKrk8ja7ztxxqX7NQDC5bNzPY072IRCxk2EVkhlK7oDgjWOy6jShqJK+KtxPG7GXssgv3kij3tHB5Lsiz0UjkwG7pjG0RG4YEzscKslJrtKZAj90T6byrv1yhoEuHB/bIH5BsSRMWcov5kYMUr8Q3+jjkBXac; 20:2a7RZs2NBlzd/T8k/4IVQXOAP8IQgyR0Ruv7vQ/M8wkrRFlXFfeG6d+kwu/ehR18lQVipRWNTtHBS0RLzyh3WcIY9hgbld4GgKDhPzWdQaQ1OxYYVYozaT4yP5YUz35cSWu/k9rVrnrn3RZAYT2/xASX9Vwgn9g89uKiWLkw0cU=
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR00MB0294;
x-ms-traffictypediagnostic: DM5PR00MB0294:
authentication-results: outbound.protection.outlook.com; spf=skipped (originating message); dkim=none (message not signed) header.d=none; dmarc=none action=none header.from=microsoft.com;
x-microsoft-antispam-prvs: <DM5PR00MB0294AECA3903456B4A412E14F5890@DM5PR00MB0294.namprd00.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(21748063052155);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(2017102700009)(2017102701064)(6040522)(2401047)(5005006)(8121501046)(2017102702064)(20171027021009)(20171027022009)(20171027023009)(20171027024009)(20171027025009)(20171027026009)(2017102703076)(93006095)(93001095)(3231232)(944501410)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR00MB0294; BCL:0; PCL:0; RULEID:; SRVR:DM5PR00MB0294;
x-forefront-prvs: 06515DA04B
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(39860400002)(39380400002)(346002)(376002)(366004)(53754006)(76176011)(6116002)(790700001)(19609705001)(55016002)(186003)(53936002)(5890100001)(6436002)(2900100001)(5250100002)(46003)(11346002)(476003)(606006)(236005)(5660300001)(54896002)(6306002)(74316002)(2906002)(3280700002)(9686003)(446003)(25786009)(478600001)(72206003)(86362001)(4326008)(3660700001)(8936002)(8676002)(966005)(7696005)(81166006)(52396003)(10290500003)(102836004)(53546011)(110136005)(7736002)(6506007)(59450400001)(22452003)(86612001)(6246003)(316002)(33656002)(229853002)(93886005); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR00MB0294; H:DM5PR00MB0296.namprd00.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv;
x-microsoft-antispam-message-info: c+5Sks+C3F6stV/R3FXhiCEdjvgn6TRgr9+dvAVtb+zyYeS6usaeZWovFvhg3kv7Bu9Rb1pTmPNNmeKAKA+jokvh8gWxYnH1wouujpydCa+cbtgTIMdpfun223uWcDxp1zcIpf1H5GaXVXrpSJt8deO4yKUK+bpl2srHl7F5R75Di8+yTyYy9JVeHaEwvUU9
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_DM5PR00MB0296E9493BA61BEDAA24B73BF5890DM5PR00MB0296namp_"
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: b6379281-a3c9-4b59-1ebe-08d5a94fb86e
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6379281-a3c9-4b59-1ebe-08d5a94fb86e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2018 19:23:40.3037 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR00MB0294
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/ry1OE8BKEOD0QJ0e2QumPbm6lus>
Subject: Re: [OAUTH-WG] scp claim in draft-ietf-oauth-token-exchange-12
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2018 19:23:46 -0000

+1

From: Brian Campbell <bcampbell@pingidentity.com>
Sent: Monday, April 23, 2018 12:13 PM
To: Torsten Lodderstedt <torsten@lodderstedt.net>
Cc: Mike Jones <Michael.Jones@microsoft.com>; oauth <oauth@ietf.org>
Subject: Re: [OAUTH-WG] scp claim in draft-ietf-oauth-token-exchange-12

I just noticed/remembered that the draft also currently defines a "cid" claim for the client identifier where Introspection's RFC 7662 already uses "client_id" for the same thing. The reason for using "cid" was similar in that I was looking to follow the semi-convention of JWT using three letter short claim names. But I think consistency with RFC 7662 is more important and meaningful here. So, barring a rough conscious of objections, I'm going to make that change too in a soon-to-be next revision of the draft.


On Thu, Apr 19, 2018 at 7:38 AM, Torsten Lodderstedt <torsten@lodderstedt.net<mailto:torsten@lodderstedt.net>> wrote:
+1 - It will makes thinks much simpler.



Am 19.04.2018 um 00:58 schrieb Mike Jones <Michael.Jones@microsoft.com<mailto:Michael.Jones@microsoft.com>>:

I’m OK with this change, given it makes the OAuth suite of specs more self-consistent.

                                                       -- Mike

From: OAuth <oauth-bounces@ietf.org<mailto:oauth-bounces@ietf.org>> On Behalf Of Brian Campbell
Sent: Wednesday, April 18, 2018 8:17 AM
To: Torsten Lodderstedt <torsten@lodderstedt.net<mailto:torsten@lodderstedt.net>>
Cc: oauth <oauth@ietf.org<mailto:oauth@ietf.org>>
Subject: Re: [OAUTH-WG] scp claim in draft-ietf-oauth-token-exchange-12

The draft-ietf-oauth-token-exchange document makes use of scope and at some point in that work it came to light that, despite the concept of scope being used lots of places elsewhere, there was no officially registered JWT claim for scope. As a result, we (the WG) decided to have draft-ietf-oauth-token-exchange define and register a JWT claim for scope. It's kind of an awkward place for it really but that's how it came to be there.
When I added it to the draft, I opted for the semi-convention of JWT using three letter short claim names.. And decided to use a JSON array to convey multiple values rather than space delimiting. It seemed like a good idea at the time - more consistent with other JWT claim names and cleaner to use the facilities of JSON rather than a delimited string. That was the thinking at the time anyway and, as I recall, I asked the WG about doing it that way at one of the meetings and there was general, if somewhat absent, nodding in the room.
Looking at this again in the context of the question from Torsten and his developers, I think using a different name and syntax for the JWT claim vs.. the Introspection response member/parameter/claim is probably a mistake.  While RFC 7662 Introspection response parameters aren't exactly the same as JWT claims, they are similar in many respects. So giving consistent treatment across them to something like scope is
Therefore I propose that the JWT claim for representing scope in draft-ietf-oauth-token-exchange be changed to be consistent with the treatment of scope in RFC 7662 OAuth 2.0 Token Introspection. That effectively means changing the name from "scp" to "scope" and the value from a JSON array to a string delimited by spaces.
I realize it's late in the process to make this change but believe doing so will significantly reduce confusion and issues in the long run.





On Sun, Apr 15, 2018 at 10:43 AM, Torsten Lodderstedt <torsten@lodderstedt.net<mailto:torsten@lodderstedt.net>> wrote:
Hi all,

I I’m wondering why draft-ietf-oauth-token-exchange-12 defines a claim „scp“ to carry scope values while RFC 7591 and RFC 7662 use a claim „scope“ for the same purpose. As far as I understand the text, the intension is to represent a list of RFC6749 scopes. Is this correct? What’s the rationale behind?

Different claim names for representing scope values confuse people. I realized that when one of our developers pointed out that difference recently.

best regards,
Torsten.
_______________________________________________
OAuth mailing list
OAuth@ietf.org<mailto:OAuth@ietf.org>
https://www.ietf.org/mailman/listinfo/oauth


CONFIDENTIALITY NOTICE: This email may contain confidential and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited..  If you have received this communication in error, please notify the sender immediately by e-mail and delete the message and any file attachments from your computer. Thank you.



CONFIDENTIALITY NOTICE: This email may contain confidential and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited.  If you have received this communication in error, please notify the sender immediately by e-mail and delete the message and any file attachments from your computer. Thank you.