Re: [OAUTH-WG] Draft 9, Section 4.1.1 missing several parameters

Justin Richer <jricher@mitre.org> Wed, 07 July 2010 14:43 UTC

Return-Path: <jricher@mitre.org>
X-Original-To: oauth@core3.amsl.com
Delivered-To: oauth@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 551493A6875 for <oauth@core3.amsl.com>; Wed, 7 Jul 2010 07:43:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.392
X-Spam-Level:
X-Spam-Status: No, score=-5.392 tagged_above=-999 required=5 tests=[AWL=1.207, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9120hg8tEn+l for <oauth@core3.amsl.com>; Wed, 7 Jul 2010 07:43:05 -0700 (PDT)
Received: from smtp-bedford.mitre.org (smtp-bedford.mitre.org [129.83.20.191]) by core3.amsl.com (Postfix) with ESMTP id 71D323A6877 for <oauth@ietf.org>; Wed, 7 Jul 2010 07:42:55 -0700 (PDT)
Received: from smtp-bedford.mitre.org (localhost.localdomain [127.0.0.1]) by smtp-bedford.mitre.org (8.13.1/8.13.1) with ESMTP id o67Egvkj001371 for <oauth@ietf.org>; Wed, 7 Jul 2010 10:42:58 -0400
Received: from imchub2.MITRE.ORG (imchub2.mitre.org [129.83.29.74]) by smtp-bedford.mitre.org (8.13.1/8.13.1) with ESMTP id o67EgvrA001366; Wed, 7 Jul 2010 10:42:57 -0400
Received: from [129.83.50.65] (129.83.50.65) by imchub2.MITRE.ORG (129.83.29.74) with Microsoft SMTP Server id 8.2.254.0; Wed, 7 Jul 2010 10:42:57 -0400
From: Justin Richer <jricher@mitre.org>
To: Marius Scurtescu <mscurtescu@google.com>
In-Reply-To: <AANLkTimfbRxKhUSV-Ydz_YGv-aE1VaQGgIFsdJ7qgut2@mail.gmail.com>
References: <AANLkTintGxCh-Pk1Wd5nubBm8qM96ZUb3TQ5Iuf0GQ07@mail.gmail.com> <AANLkTimfbRxKhUSV-Ydz_YGv-aE1VaQGgIFsdJ7qgut2@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 07 Jul 2010 10:42:56 -0400
Message-ID: <1278513776.2445.26.camel@localhost.localdomain>
MIME-Version: 1.0
X-Mailer: Evolution 2.28.3
Content-Transfer-Encoding: 7bit
Cc: OAuth WG <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Draft 9, Section 4.1.1 missing several parameters
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jul 2010 14:43:06 -0000

+1 on reference to section 2. Also, in 4.1.1, the wording in the last
paragraph makes it sound like the client_secret is REQUIRED for flows
using the authorization code, when as per section 2 the secret is only
required IF a secret was issued with the client_id. Wording such as
found in 4.1.2 is a better fit overall:

  The authorization server MUST validate the client credentials
  [link to Section 2 here] ...

 -- Justin

On Tue, 2010-07-06 at 22:42 -0400, Marius Scurtescu wrote:
> How the client authenticates itself is covered in section 2, and
> client_id plus client_secret in 2.1.
> 
> The first paragraph of section 4 mentions this in a general way, but I
> think an explicit pointer to section 2 would help.
> 
> Regarding the last paragraph of 4.1.1, since it explains the example,
> it probably makes sense to mention client id and secret. Again, a
> direct reference to 2.1 may help.
> 
> Marius
> 
> 
> 
> On Sat, Jul 3, 2010 at 2:28 PM, Andrew Arnott <andrewarnott@gmail.com> wrote:
> > Section 4.1.1, which deals with requesting an access token using an
> > authorization code, doesn't list the client_id and client_secret parameters
> > at all, yet mentions verifying them in paragraph form, and they are included
> > in the example.
> > --
> > Andrew Arnott
> > "I [may] not agree with what you have to say, but I'll defend to the death
> > your right to say it." - S. G. Tallentyre
> >
> > _______________________________________________
> > OAuth mailing list
> > OAuth@ietf.org
> > https://www.ietf.org/mailman/listinfo/oauth
> >
> >
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth