Re: [OAUTH-WG] Authorization Code Grant diagram Improvement OAuth 2.1 draft-ietf-oauth-v2-1

Dick Hardt <dick.hardt@gmail.com> Thu, 30 July 2020 17:37 UTC

Return-Path: <dick.hardt@gmail.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8BF8C3A0FF2 for <oauth@ietfa.amsl.com>; Thu, 30 Jul 2020 10:37:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.085
X-Spam-Level:
X-Spam-Status: No, score=-2.085 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_FONT_LOW_CONTRAST=0.001, HTML_IMAGE_RATIO_06=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I9jfaxaiMBhM for <oauth@ietfa.amsl.com>; Thu, 30 Jul 2020 10:37:10 -0700 (PDT)
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2D8C63A0FF1 for <oauth@ietf.org>; Thu, 30 Jul 2020 10:37:09 -0700 (PDT)
Received: by mail-lf1-x12b.google.com with SMTP id b30so15395473lfj.12 for <oauth@ietf.org>; Thu, 30 Jul 2020 10:37:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dzyzFi5ww+uLhb8wZwwAWUXWNPeVxYpJLk7pmmsgNMs=; b=fM5zAbarwXlXrizlzmbP3dIRiDXxuHYirZVmOShbFc7VEaYoyADLgtCa09vit8rI8E io+LFw1kAnYh/1pEOCznvlNt4IvIAM3v2agc9YyOW2P0kgePFk9bZZWMArdGsAjdcWic F3vTnyiehw/TCUtJLYRuphbB02sXKw4MgfQdR44nqdzzS7Dm3p/w3ulX4czgLW5MlWZY qGmXDunLZrFQbQ+jW5GVBVUcWern6L9ZQm+c484s8r2gV8eavW3wSdQRMDxrH788ubGB 7g1fiiGP7q8WFFdPpffc39xHMWIgauvtv9MbGcNApuQYL0/eIftXnqSJ2itGZtwrnKn0 s9yw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dzyzFi5ww+uLhb8wZwwAWUXWNPeVxYpJLk7pmmsgNMs=; b=XIzuTjXbX0IE4TuG6QzruArYVQuN8fGZbWwcpQB1Ylaeg73L5I/cLYjXCHsCSKX/N7 G3kaIOwAw5PvfJSKmwJzOpVL6i5bqoDLjxsjtW2hLj7lx5sNpRRvq/Dnc6RprJYJtCNB r8nyFgzLRDyZDa/sdnvgCkbMUr8xlOVRDEiEUQvihzJ1/BHvgB16k9xdZK6l4bvl8+jk DHsXD7l9/QXnl7hlLqTRGNsCBJOvKd5D7Pp8Je+P2878WB+NNfEMw7DnxnXMdPIcTBXz 1yIWqF9758ZdrUD4EaDWmV0sITSUyaEQvS1tXo3JOMbpePhxbukso3m5bKp4irFtX1Hw nZzw==
X-Gm-Message-State: AOAM531NpA/3eMeaBmh785jmiTt3xdngIrJljcTuI6Zdij9T3Qps+8V+ WMdVhD5ra0Ch8tcOR6cBZW4iyXmOx+mwuGHDckU=
X-Google-Smtp-Source: ABdhPJwjYFNiNN5c9vD+99ehmnBMdRUAJOTzfyNUhplxziSFwp7/xmCCbmaEG7+ZlpJugBnqACMUjItoM0O6uAtuDjU=
X-Received: by 2002:ac2:4a9d:: with SMTP id l29mr2194435lfp.23.1596130627097; Thu, 30 Jul 2020 10:37:07 -0700 (PDT)
MIME-Version: 1.0
References: <CAJot-L0pNWox1aX5GOkD=QVJakRVVtn=PvysciB2Wak6ijG+Dw@mail.gmail.com> <CAGBSGjo_w5+fOE0bQeeiuQLt0-Xkt+Gdu01C3BHZeuOZNh4Taw@mail.gmail.com> <CAJot-L0XmQ2wbmXPDjhwT4tT8nihmEXxc-N3orfeV21EKyYCPA@mail.gmail.com> <CAD9ie-sf+yxQaL-a1jVm=XyVCTkm2v9rc_8fWZOJsd62rCRQYQ@mail.gmail.com> <CAJot-L2PwMigsvD9j_enPMtb32w-RWgXe6nLL9wCm-UqDbDC_g@mail.gmail.com>
In-Reply-To: <CAJot-L2PwMigsvD9j_enPMtb32w-RWgXe6nLL9wCm-UqDbDC_g@mail.gmail.com>
From: Dick Hardt <dick.hardt@gmail.com>
Date: Thu, 30 Jul 2020 10:36:30 -0700
Message-ID: <CAD9ie-v0kJ0+O0Zj2K0Kj5t3E7xEtxVK4CQbUhEZP_fSSmcvsQ@mail.gmail.com>
To: Warren Parad <wparad@rhosys.ch>
Cc: Aaron Parecki <aaron@parecki.com>, oauth <oauth@ietf.org>
Content-Type: multipart/related; boundary="0000000000000b7a8605abac1fcb"
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/GX5a0MUjNb7-b6ZTh337ntBQldA>
Subject: Re: [OAUTH-WG] Authorization Code Grant diagram Improvement OAuth 2.1 draft-ietf-oauth-v2-1
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2020 17:37:13 -0000

In retrospect, I would make the (B) line a double line with hats and arrows
at each end to indicate it is not the same as (A) and (C).

I agree that adding a sub label will clarify which leg is first, and which
is second.

I also think we should change "User authenticates" to be "User interaction"
as there is both user authN and user consent.

We also are using 2 terms for the User (User in the flow, and RO in the
box). We should settle on one.


ᐧ

On Thu, Jul 30, 2020 at 10:28 AM Warren Parad <wparad@rhosys.ch> wrote:

> Wow only now I understand that, I didn't notice the hats on the arrows,
> and I was further confused why (B) had two "out arrows". Would still
> recommend these being 1a and 1b, 2a/b, 3a/b.
>
> Warren Parad
>
> Founder, CTO
> Secure your user data and complete your authorization architecture.
> Implement Authress <https://bit.ly/37SSO1p>.
>
>
> On Thu, Jul 30, 2020 at 7:24 PM Dick Hardt <dick.hardt@gmail.com> wrote:
>
>> The (A), (B), and (C) label the same flow that bounces through the
>> User-Agent. See note below the diagram.
>>
>> Note the tails and arrows at each end of (A) and (C), and the arrows at
>> both ends of (B) to indicate an interaction between the RO and the AS. (in
>> my original version, I had the User instead of the RO).
>>
>> The (A) and (C) flows are shown to go through the User-Agent to make it
>> clear it is a redirect flow in contrast to (D) and (E) in which the Client
>> directly talks to the AS.
>>
>>
>> ᐧ
>>
>> On Thu, Jul 30, 2020 at 9:57 AM Warren Parad <wparad@rhosys.ch> wrote:
>>
>>> From the OAuth RFC, these were actually letters. I don't see a necessary
>>> association between the left side of the diagram and the right side, it
>>> just seems unnecessarily confusing.
>>> [image: image.png]
>>>
>>> Warren Parad
>>>
>>> Founder, CTO
>>> Secure your user data and complete your authorization architecture.
>>> Implement Authress <https://bit.ly/37SSO1p>.
>>>
>>>
>>> On Thu, Jul 30, 2020 at 5:49 PM Aaron Parecki <aaron@parecki.com> wrote:
>>>
>>>> These numbers in the diagram correspond to the numbered steps in the
>>>> paragraphs below the diagram. Perhaps using non-duplicated numbers would
>>>> help, such as "1a" and "1b" instead of two instances of "1"? Although I'm
>>>> not sure how that would work exactly because the "1/2/3" are really just a
>>>> single action as described by the "Note" below the diagram in your
>>>> screenshot.
>>>>
>>>> ---
>>>> Aaron Parecki
>>>> https://aaronparecki.com
>>>> https://oauth2simplified.com
>>>>
>>>> On Thu, Jul 30, 2020 at 8:43 AM Warren Parad <wparad@rhosys.ch> wrote:
>>>>
>>>>>
>>>>> https://www.ietf.org/id/draft-ietf-oauth-v2-1-00.html#name-authorization-code-grant
>>>>>
>>>>> Can we avoid using (1, 2, 3) on the left side of the diagram to
>>>>> describe, I'm not even sure what they are supposed to represent, not to
>>>>> mention the RO in the diagram doesn't really provide value (for me)
>>>>> relevant to the code grant flow. It's confusing to see these numerical
>>>>> identifiers twice in the same picture. But maybe there is something hidden
>>>>> in this that I'm missing, still 3a and 3b could be used to identify
>>>>> different legs of the same code path.
>>>>> [image: image.png]
>>>>>
>>>>>
>>>>> *Warren Parad*
>>>>> Secure your user data and complete your authorization architecture.
>>>>> Implement Authress <https://bit..ly/37SSO1p>.
>>>>> <https://rhosys.ch>
>>>>> _______________________________________________
>>>>> OAuth mailing list
>>>>> OAuth@ietf.org
>>>>> https://www.ietf.org/mailman/listinfo/oauth
>>>>>
>>>> _______________________________________________
>>> OAuth mailing list
>>> OAuth@ietf.org
>>> https://www.ietf.org/mailman/listinfo/oauth
>>>
>>