Re: [OAUTH-WG] Call for Adoption: OAuth 2.0 Mix-Up Mitigation

Justin Richer <jricher@mit.edu> Mon, 25 January 2016 23:53 UTC

Return-Path: <jricher@mit.edu>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A56341A88BC for <oauth@ietfa.amsl.com>; Mon, 25 Jan 2016 15:53:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id drSzHu2BxqsG for <oauth@ietfa.amsl.com>; Mon, 25 Jan 2016 15:53:38 -0800 (PST)
Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu [18.7.68.34]) by ietfa.amsl.com (Postfix) with ESMTP id C8A051A8833 for <oauth@ietf.org>; Mon, 25 Jan 2016 15:53:37 -0800 (PST)
X-AuditID: 12074422-f79c46d000006aa7-28-56a6b580f45b
Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP id 40.0A.27303.085B6A65; Mon, 25 Jan 2016 18:53:36 -0500 (EST)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id u0PNrZPd015224; Mon, 25 Jan 2016 18:53:36 -0500
Received: from [192.168.128.48] (static-96-237-195-53.bstnma.fios.verizon.net [96.237.195.53]) (authenticated bits=0) (User authenticated as jricher@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id u0PNrX5S022964 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 25 Jan 2016 18:53:34 -0500
Content-Type: multipart/alternative; boundary="Apple-Mail=_3E91D8C8-4A06-4581-9925-6B6020F87B8E"
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
From: Justin Richer <jricher@mit.edu>
In-Reply-To: <56A66BED.3090505@aol.com>
Date: Mon, 25 Jan 2016 18:53:33 -0500
Message-Id: <522B7197-F14F-44AD-9217-63480CA558F2@mit.edu>
References: <569E22E1.5010402@gmx.net> <CANSMLKHjAHr6rUZny5EkX0KBHnOcLuUOZBL0Wwf6V8Y3tt_kNw@mail.gmail.com> <CABzCy2C-_57dO5n6GN6wazA9ozuPivrQd95g_XvdkPWx6zDwAA@mail.gmail.com> <CANSMLKE98FVdDV-7bwW3wZ=-ao5=oXkn9LO5s_M1KmMAt7Drcw@mail.gmail.com> <537B9D13-1159-4B2D-9E1A-A245C9B3659C@ve7jtb.com> <CAAP42hDUciKpS51dyx7Zy-kSCB_JUZqooXiaGTopHaFr_QkF5Q@mail.gmail.com> <995474C5-62E7-4310-84AF-A5EF1CDEA4DB@ve7jtb.com> <56A63F82.40104@aol.com> <6D8FA56F-EA72-4509-90C1-DC33094FA695@ve7jtb.com> <56A66522.1090804@aol.com> <23E34900-5C05-4295-AFC5-7DEBA6449AA7@ve7jtb.com> <56A66BED.3090505@aol.com>
To: George Fletcher <gffletch@aol.com>
X-Mailer: Apple Mail (2.2104)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHKsWRmVeSWpSXmKPExsUixG6nrtuwdVmYwZ4TOhZ3ulawW5x8+4rN YvXdv2wOzB73d69k91iy5CeTx+3bG1kCmKO4bFJSczLLUov07RK4MpYsbmAt2PKBsaLx2jrm BsaeFYxdjJwcEgImEqf+zoWyxSQu3FvP1sXIxSEksJhJ4uLF70wQzkZGiXf737FDOLeZJGav PgXUwsHBLJAg0Xw6GKSbV0BP4tWty6wgtrCAm8TKA5fZQGw2AVWJ6WtamEBsTgF1idP7n4LF WYDi328vYwaxmQU8JfY8u8AIMcdKYsKf01BXXGSRmP5gH1iRiICaRNPKNVCnykrs/v2IaQKj wCyEM2YhOWMW2FhtiWULXzND2AYSTztfYRHXl3jzbg7TAka2VYyyKblVurmJmTnFqcm6xcmJ eXmpRbqmermZJXqpKaWbGMGR4KK0g/HnQaVDjAIcjEo8vBsKloUJsSaWFVfmHmKU5GBSEuVN WAwU4kvKT6nMSCzOiC8qzUktPsQowcGsJMKbsAEox5uSWFmVWpQPk5LmYFES593VMTdMSCA9 sSQ1OzW1ILUIJivDwaEkwRu5BahRsCg1PbUiLTOnBCHNxMEJMpwHaHgISA1vcUFibnFmOkT+ FKMxx751d9Yycbya93AtkxBLXn5eqpQ47waQUgGQ0ozSPLhpoGSW8Paw6StGcaDnhHkDQKp4 gIkQbt4roFVMQKv+ai4GWVWSiJCSamDUb00MXMBSEbmrUyaEY9F9IYHkVVurjz84mf3rd++j Z6m3TWeLixTtsYnwKat8c4/vs+qitP7TuofnuaiELX3h/FGA7eLEw9E2stk256adSuVcdM7B 7Ji44NnrbKm8f9crFak6Ll102DPsv8W0v3Ubkhv03sp43L2Y5Ti9MIFjApdZN8dBzw1KLMUZ iYZazEXFiQCCzeKyQQMAAA==
Archived-At: <http://mailarchive.ietf.org/arch/msg/oauth/Mazgs4MuvvIfc5rmxFTnNDs55Rs>
Cc: "<oauth@ietf.org>" <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Call for Adoption: OAuth 2.0 Mix-Up Mitigation
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jan 2016 23:53:41 -0000

+1

> On Jan 25, 2016, at 1:39 PM, George Fletcher <gffletch@aol.com>; wrote:
> 
> So now, in addition to the dynamic client registration spec, the client would need to support OAuth2 Discovery.
> 
> I guess my concern is that it feels like we are adding a lot of little things to try and mitigate these attacks in OAuth2 and it's confusing when they are needed and when they aren't.
> 
> For me it would be simpler to say that OAuth2 with a single pre-configured AS is fine. If a client wants to support multiple Authorization Servers (a la dynamic client registration or some other method) then here are all the things that need to be done. Maybe this would be simpler as a profile of OAuth2 (in the vein of OpenID Connect) that adds the necessary requirements to mitigate these attacks.
> 
> This way an OAuth2 developer knows which spec to follow based on their requirements and all the necessary steps would be in "one" place.
> 
> Thanks,
> George
> 
> On 1/25/16 1:22 PM, John Bradley wrote:
>> The presumption is that registration would need to add a issuer, as an identifier of the AS, and that would be optionally be used in discovery.
>> 
>> OAuth as is supports the single AS model.
>> 
>> To support multiple AS for a single client something needs to change.    Adding issuer and client_id to the response with optional discovery was seen as the least disruptive at the Germany meeting.
>> 
>>  The other way to do it is to return discovery info from the the authorization and token endpoints, however the request probably also need to be modified so that the AS knows what the resource is, otherwise 
>> other things will break.    
>> 
>> It is possible now to have one authorization endpoint provide code for per Tennent token endpoints.(No I don’t know of any one doing it).
>> 
>> Anything we add to tighten up the trust model will have impacts on what can be done with OAuth.  
>> 
>> John B.
>>> On Jan 25, 2016, at 3:10 PM, George Fletcher <gffletch@aol.com <mailto:gffletch@aol.com>> wrote:
>>> 
>>> Comments inline
>>> 
>>> On 1/25/16 12:32 PM, John Bradley wrote:
>>>> No, client id_are scoped by issuer.  
>>> This makes sense, but I'm not sure it's a current assumption by OAuth2 implementations :)
>>>> 
>>>> There is no need for AS to make the client_id globally unique.
>>>> 
>>>>  The client needs to not allow two AS to provide it with the same issuer client_id pair.
>>>> 
>>>> That would probably be imposable for many clients anyway. 
>>> I would rather say that the results of two client_ids being the same from two different issuers is undefined.
>>>> 
>>>> For Connect clients typically manage configurations using issuer as the primary key.  I doubt may would support even two client_id from the same issuer.
>>> If scoped by issuer this makes sense, though the concept of "issuer" as a comparable entity wasn't really talked about with OAuth2.
>>>> 
>>>> For OAuth what clients do is slightly less clear.  In general they don’t have more than one AS per API do might try and organize things by RS or AS.
>>> I agree that not many clients support dynamic client registration. However, I would say there a number that support multiple AS that are "fixed" within the code (including fixed endpoint URIs). So I would say that the associations would be fixed in code. There wouldn't necessarily be an association outside of the code which maps button A to AS1 and button B to AS2.
>>>> 
>>>> In principal a OAuth client might have two different AS each with a different client ID and that will be OK as long as the client_id in the request is the same as the one in the response.
>>>> 
>>>> So going to a new AS and getting back the same iss and client_id that you registered someplace else would be an error for the client.
>>>> 
>>>> I don’t think that is unreasonable.
>>> I agree that this is reasonable with the assumption that client_id's are scoped by "issuer". It's just likely that most clients in the field do not have this sort of explicit association. The OAuth2 Dynamic Client Registration spec does not define an "issuer" in the response. For the OAuth2 use cases, what is the proposed "issuer" equivalent URI that is being used to scope the client_id? 
>>>> 
>>>> John B.
>>>> 
>>>> 
>>>>> On Jan 25, 2016, at 12:30 PM, George Fletcher <gffletch@aol.com <mailto:gffletch@aol.com>> wrote:
>>>>> 
>>>>> I'm still catching up... but to this point specifically...
>>>>> 
>>>>> Doesn't this require that the same client_id NOT be used simultaneously at two (or more) Authorization Servers? If so, I don't believe that is a viable option. It's a little late in the game to be putting requirements on the AS as to how it generates it's client_id.
>>>>> 
>>>>> Thanks,
>>>>> George
>>>>> 
>>>>> On 1/25/16 9:11 AM, John Bradley wrote:
>>>>>> 
>>>>>> Returning the iss and client_id from the authorization endpoint per Mike’s draft allows the client to reject the authorization response and not leak the code.
>>>>> 
>>>> 
>>> 
>>> -- 
>>> Chief Architect                   
>>> Identity Services Engineering     Work: george.fletcher@teamaol.com <mailto:george.fletcher@teamaol.com>
>>> AOL Inc.                          AIM:  gffletch
>>> Mobile: +1-703-462-3494           Twitter: http://twitter.com/gffletch <http://twitter.com/gffletch>
>>> Office: +1-703-265-2544           Photos: http://georgefletcher.photography <http://georgefletcher.photography/>
>> 
> 
> -- 
> Chief Architect                   
> Identity Services Engineering     Work: george.fletcher@teamaol.com <mailto:george.fletcher@teamaol.com>
> AOL Inc.                          AIM:  gffletch
> Mobile: +1-703-462-3494           Twitter: http://twitter.com/gffletch <http://twitter.com/gffletch>
> Office: +1-703-265-2544           Photos: http://georgefletcher.photography <http://georgefletcher.photography/>
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth