Re: [OAUTH-WG] Francesca Palombini's No Objection on draft-ietf-oauth-jwsreq-32: (with COMMENT)

Mike Jones <Michael.Jones@microsoft.com> Thu, 08 April 2021 04:45 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 660663A38FB; Wed, 7 Apr 2021 21:45:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.101
X-Spam-Level:
X-Spam-Status: No, score=-2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tFdYcyKtJzjJ; Wed, 7 Apr 2021 21:45:06 -0700 (PDT)
Received: from NAM06-DM3-obe.outbound.protection.outlook.com (mail-eopbgr640112.outbound.protection.outlook.com [40.107.64.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0A8963A38F9; Wed, 7 Apr 2021 21:45:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gz3UNQymYpvgiP60ZCzxK8ZeEhaqP+/65xGro6e75LgcdfHWhH6Efp6FAI2Dmqz8xWN5vSKLe20RNLr3jN6AtQ3+O7HBERyFijtlvbJvAOjdjxq4vSU7v4MCEpF8+nXx4pPJ+0ccVKwUjyqonpN59ohFlyZNiYB34f2LHQOZ2Ju3fCQ69xH/Dcz4aB5Xgkd0iJGHsaywCz//jNP6rs/CDKcr84l2QlogRBDXoSz6q0w90lFRP/IvUOtq5oZAmY+/Sk04FxkNfUTnqeRfRP4/sBQKYsL31fiiM6AwRV1CKeikgZgu1i3bk8spzoLSLAeWOaye2bpr3gS0Kf5imDrF2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q0GvpO2Hy3DjHZjlXOVIG/B2xalvtwJ/6eOxPGWiFGg=; b=jRiRFQKlIszfR8QqPbpebTekgozdhc7EPB6+esJR7mHGoVlLxtZcWmps0B6XiUsWcfSPf4/5z51emfEDy0y/pl6S4509u8zmI5MdtcZdAeiab+mmZbWUPpL4VWvrrUCzqqxFU7CmBMIKaXBbkGg1c4r+LvjRU82vruExN4Jp4cYf6fyd+/6sRGSNjtQVsxg+1LkYMIhCkVPNyJdFgWpl1LBm24epGG+yT3abRziCYgkU5jhRPbukgGVGwpW5wlK1C6dxi/VxRZhBbzJkFnuDJ960k0DTCf1k6oh6KtjTli9ncLUTw5QxHtZRZj7uxVzKtZkn14WLw0o/K+7ItLxLDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q0GvpO2Hy3DjHZjlXOVIG/B2xalvtwJ/6eOxPGWiFGg=; b=F9NKcr0/axCG7g0ttv5kHhZ09pYRNFwp6mV5CL8cOr3oAMF8chEm3fk44p20zowU9jPeG1LW8qz/z0kWtTc8uwVKButZcXIMCFqGdiVj4TYc7VxB03Ioh+/e1o4FRUZHSqi7+T9k0P4awoQkJ3m3fJYcZaOy8YnTLrlccpO5hbo=
Received: from DM5PR00MB0421.namprd00.prod.outlook.com (2603:10b6:4:a0::33) by DM6PR00MB0751.namprd00.prod.outlook.com (2603:10b6:5:1be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4056.0; Thu, 8 Apr 2021 04:44:59 +0000
Received: from DM5PR00MB0421.namprd00.prod.outlook.com ([fe80::e553:4e87:8c7e:63d5]) by DM5PR00MB0421.namprd00.prod.outlook.com ([fe80::e553:4e87:8c7e:63d5%7]) with mapi id 15.20.4056.000; Thu, 8 Apr 2021 04:44:59 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: "francesca.palombini@ericsson.com" <francesca.palombini@ericsson.com>, "iesg@ietf.org" <iesg@ietf.org>
CC: "draft-ietf-oauth-jwsreq@ietf.org" <draft-ietf-oauth-jwsreq@ietf.org>, "oauth-chairs@ietf.org" <oauth-chairs@ietf.org>, "oauth@ietf.org" <oauth@ietf.org>, "Hannes.Tschofenig@gmx.net" <Hannes.Tschofenig@gmx.net>
Thread-Topic: Francesca Palombini's No Objection on draft-ietf-oauth-jwsreq-32: (with COMMENT)
Thread-Index: AdcsMekdJv5IcULvQ1qzavuY873M4w==
Date: Thu, 8 Apr 2021 04:44:59 +0000
Message-ID: <DM5PR00MB04213AEA322C464E10D0E02FF5749@DM5PR00MB0421.namprd00.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-08T02:41:17Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=cdfb0104-3004-44ad-80cf-5c9eac18df57; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0
authentication-results: ericsson.com; dkim=none (message not signed) header.d=none; ericsson.com; dmarc=none action=none header.from=microsoft.com;
x-originating-ip: [172.56.42.184]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 14cc71dd-cbba-4be5-acfd-08d8fa4910e5
x-ms-traffictypediagnostic: DM6PR00MB0751:
x-microsoft-antispam-prvs: <DM6PR00MB075144B95CA263F9DBEA5BEFF5749@DM6PR00MB0751.namprd00.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: C9zHeEUctsZiKYkcPuOdfjMvPgabIiMTwwlGNtFBTF3O69vNW4rLXjEU2tsJtDuTzlTKqzbVIoxwSjY8fs1nQ5S7WF/MYrNfa9P+G1gGSwJBsvmLCyEqX5bpceluofxZvpB/kGGJCXhmk8tJkV2ulDuykuBhLRzhV5mqnXhf/Scfe81+e75kE6SvoNI0hhIQbgFyTQUHBI3s745dwmybtvRSpQN8jjcBGuFL1kEztbLa+rvRzFvFItw8a/rHi15ppLRLpe4tJGjv/GZDdkdf5uhdHdUOt+cHHXx7iYU7Fo0MdBzIrP4lar/lIzkFo9jyWhx3hVd70IIm3HXy/NkIChDg9jcTzPTTsUl7mJMq7WGqgQ8XeRYjjcH2JhGAs0HE6sIc6GUoDImRN2gUZRb7w/WpLIas5Hv5GU/bfDVCBN77US3092UH4DFntqZh1hWGZaAxV+HP5Kurob0ATU03FfLoDWtcBGTfK6YQbdfS8zGEy0BFqYuLKluXBzYNrcO2kHVb0/4q9nx0WQq5uwmOsnfwj3JpnKgeweXsA5FVlu7zWBTnl1djz/rst8zTAI74LO+SmkkM+KzzZjlUqHYEqXM7EG7GAIxbKs0OBvx4pp1ABKin3FmRWFCr+130JvPTQvQV39P5Q+qHiz1M0DuVwRNxer89fSkAdRneENj+rG1K0N65oAR1vNrWrJ6J6M38OdROGdt1zmeSmwlbaACXGyN9GDyr0JLM9bUJb9abUss=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR00MB0421.namprd00.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(2906002)(86362001)(26005)(5660300002)(55016002)(71200400001)(186003)(52536014)(478600001)(83380400001)(54906003)(8990500004)(110136005)(33656002)(966005)(7696005)(10290500003)(4326008)(66476007)(9686003)(66946007)(6506007)(316002)(82950400001)(38100700001)(8676002)(76116006)(66556008)(82960400001)(64756008)(66446008)(53546011); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: =?utf-8?B?dVppQXlqcVM4M1d4bGtQVlorZEVmOHZTWGxnNFg1WVZNM1RrdHNsY3ZFZGhG?= =?utf-8?B?M1JMRjhmcGN0cytMUjlvcFcyNGxPZ01Ja3IrK0R0Y2ZpWEQ1dTh1VzFyQm50?= =?utf-8?B?K3c5TkhVSE9HS3A2RzZYNFNTRnh1Q0tmU252WnJOUGwrWkJXU1A5dmx4R2Vp?= =?utf-8?B?RnZ2cFVyNVlFK2ZYRkF0NlhrMUkzM3VEWEVtNkhmd1dqRCtqY29TMkVEUjVy?= =?utf-8?B?UmdDUDV0K3FDcXVyakl2SGhFWjgwaFB0SkxOWmU1Smt5YmdwN29UbC9qWnN5?= =?utf-8?B?cnlFZW5NVWt0anpRSE8xcVZKYTRSWkpRbEpxTXpGclh6WTUvdjJ0VXFpOXhk?= =?utf-8?B?SzFNUU5oT01qS1VVdFRzeEJaRmM3V0Y5YTlEYlhxbS9zbWpNeElBR0NTak1C?= =?utf-8?B?T0R2c01Tc2N5ZXF0c2V1c2RrWG5odmxaZ0N2YThpNHJyTjIwdEtxL0JIRGtO?= =?utf-8?B?MU56Q3FPMG4yMCtaUjZQTUUvZVhNVEI1cVQwTTVPeGVDRlZuMGdOWVEyLzZH?= =?utf-8?B?R1RJK1RUeklGNm4rVkZneFVmbnkwVll4empLV1VSY0dCd0RnQkJ3K0RWZ3d5?= =?utf-8?B?KytmV2ppb0JTMXRDNlc0QnI0cWJrTmkvUTk0c01WOExrQXBEZjhRSFZKMGw4?= =?utf-8?B?UXY2a3lTTi9WZFRyR0hySGFJTXZYWXFOcVlQcHl2enhwQ1BXd3BueHJRT0FP?= =?utf-8?B?VmxiSTZpMTBHdk11STBmazFZUXBYNzJsUGE2Zjh5QStYOUN3aXJBcnJ4R1A2?= =?utf-8?B?eTJnZklLektGa09yMDJsV3RIZ1o3NlVTL0Vab1lvOXk5bks2U0hSeWlOUEZL?= =?utf-8?B?clVMVXY5V3dYSnZLMnNyRWhzbXplV3Z1SDBHM2VrWHdKWHIrTkE4ZnozbGND?= =?utf-8?B?TnJUODJncEwxOVdMeDl6S0VOOXVQYU5DLytxaTdMVXdaR3A3d1RoR3RubVQw?= =?utf-8?B?OEZ4SGxGd2g2Z1VpSk0rMnBuSjVBWTJxZWplTmFzb1JrSHRtTzgrbmZJNmdF?= =?utf-8?B?YjI1VW1odlNpU0dzd1ZlZDBrRjlpSVRhQzBVQnMrUllnNXlJeFZGS3M0M1Fw?= =?utf-8?B?MDM5dUVleW9sYTRCK0pmdVJkcE43d1dvTkIzYWxNelNINWNDbWZqd2oyVVc0?= =?utf-8?B?VnZBRUVZMEpiVjBweW0rNmRaRTVzMXZzZDVFbmN0RmZYNmxWZ1gwcEpmTUpj?= =?utf-8?B?NkNZdW5zMy9uZU1ndVBaMmxOWkN6UEU4cVlxZWdBeWp5dkZMS1R5VUtvRHhR?= =?utf-8?B?VEFSRmFHVURpZms2aU5OWVBxcDc4RkRFWWdKalgzYXZwSmdWZTd0NllFeVQy?= =?utf-8?B?ejZqNWFJSzJjWjgvQzk5ZmVVbituK213aEEzSTl5alNJb24yV2p5R0tLYXRV?= =?utf-8?B?RUQwQzVnS013cHduOVhtZzVGaHJSNkp3VkRLVmUwYkZHemVDSWtKSktwSGR3?= =?utf-8?B?bDFoK2YxVTE5NGpzUk9ZNEU0U0M5dnR1eVR2eHNCYVlzRWpxNEVuWmVSa3RI?= =?utf-8?B?SFpvL2VaK3AvS2lPY2RsdCtzTUNHRnZ1QVZwakZ2YVlHWTdhM1dLUk5RVWpB?= =?utf-8?B?UTd1RDR3MW9TUktOMEtiU0J2bVE2NkYzK091L1BQTGxDanVrejZ1YnNBSnd3?= =?utf-8?B?RWdHeFI1R2ZKa25va05vbkhFNkl0KzdOMDl4bXlkNFRmRmo5MkZnVmhZL3di?= =?utf-8?B?clZ6RWoyRnB3N1JOd2VxamxjMkZIMU9sejZwQUpPeTRTZy9YZmRNK2NXbGh2?= =?utf-8?Q?MQnxFWxI3tK4v62LinPeyQPqN9qr/jJHo29ViyK?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR00MB0421.namprd00.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14cc71dd-cbba-4be5-acfd-08d8fa4910e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 04:44:59.4340 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hRvdDc8F3aiV6d8mUBmOYhw/8w5YQxUuqG5yIEw3PZrHWQvNcQPgb2Wxbg/ve4mGwTDEIAr+1j+EtIOAFpTLYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR00MB0751
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/QYYujB879l5LvTy46K-4idlog5Y>
Subject: Re: [OAUTH-WG] Francesca Palombini's No Objection on draft-ietf-oauth-jwsreq-32: (with COMMENT)
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 04:45:15 -0000

Thanks for your review, Francesca.  We've published https://tools.ietf.org/html/draft-ietf-oauth-jwsreq-33 to address your and other IESG comments.

Responses are inline below, prefixed by "Mike>".

-----Original Message-----
From: Francesca Palombini via Datatracker <noreply@ietf.org> 
Sent: Wednesday, April 7, 2021 3:29 AM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-oauth-jwsreq@ietf.org; oauth-chairs@ietf.org; oauth@ietf.org; Hannes.Tschofenig@gmx.net
Subject: Francesca Palombini's No Objection on draft-ietf-oauth-jwsreq-32: (with COMMENT)

Francesca Palombini has entered the following ballot position for
draft-ietf-oauth-jwsreq-32: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-oauth-jwsreq/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thank you for the work on this document. I only have minor comments, the most interesting is probably 4. about if additional failure behavior should be defined at the AS.

Francesca

1. -----

   A Request Object (Section 2.1) has the "mime-type" "application/

FP: Please use "media type" instead of "mime-type" and reference
https://tools.ietf.org/html/rfc6838

Mike> Thanks, updated, although referencing RFC 2046 for the term "media type" (which is not superseded by RFC 6838).

2. -----

   The following is an example of the Claims in a Request Object before
   base64url encoding and signing.  Note that it includes the extension

FP: This example is the first time "base64url" appears in the document. I think it would make sense to mention that base64url is used when JWT is introduced, for example in the first paragraph of section 4.

Mike> Reference added.

3. -----

   If decryption fails, the Authorization Server MUST return an
   "invalid_request_object" error.

...

   If signature validation fails, the Authorization Server MUST return
   an "invalid_request_object" error.

...

   If the validation fails, then the Authorization Server MUST return an
   error as specified in OAuth 2.0 [RFC6749].

FP: very minor, but I suggests you add "to the client, in response to the request defined in 5.2.2. of this specification". The reason is that the doc specifies that the AS might be having other exchanges (to fetch the Request
Object) at the same time, and it can't hurt to be precise. Also regarding the reference to RFC 6749 - can you add a specific section to reference?

Mike> Done

4. -----

   specified in the "alg" Header Parameter.  If a "kid" Header Parameter
   is present, the key identified MUST be the key used, and MUST be a
   key associated with the client.  Algorithm verification MUST be

...

   same parameter is provided in the query parameter.  The Client ID
   values in the "client_id" request parameter and in the Request Object
   "client_id" claim MUST be identical.  The Authorization Server then

FP: "MUST be a key associated with the client" - what if it is not? does the AS return an error to the client then? Same comment "... MUST be identical" - is any error returned if it's not?

Mike> I believe that the responses to these validation errors are already described in the following paragraph, which says "If signature validation fails, the Authorization Server MUST return an 'invalid_request_object' error to the client in response to the authorization request."

5. -----

   location, (b) check the content type of the response is "application/

FP: For consistency, please change "content type" to "media type".

Mike> Done

				Thanks again,
				-- Mike