Re: [OAUTH-WG] WG Last Call on the RAR Document

Torsten Lodderstedt <torsten@lodderstedt.net> Sun, 20 June 2021 10:33 UTC

Return-Path: <torsten@lodderstedt.net>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 864273A0D0B for <oauth@ietfa.amsl.com>; Sun, 20 Jun 2021 03:33:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.088
X-Spam-Level:
X-Spam-Status: No, score=-0.088 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lodderstedt.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iS24LMEtvdFL for <oauth@ietfa.amsl.com>; Sun, 20 Jun 2021 03:33:43 -0700 (PDT)
Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C8ABF3A0D07 for <oauth@ietf.org>; Sun, 20 Jun 2021 03:33:42 -0700 (PDT)
Received: by mail-ej1-x629.google.com with SMTP id my49so23472449ejc.7 for <oauth@ietf.org>; Sun, 20 Jun 2021 03:33:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lodderstedt.net; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=qNVwhcNoz+z1Z/nR6VpJk/f4ck4U7XYk4bS1cBDwpO4=; b=5fk0TLsPwQ2uQF5uMlogeK5Wlhqn+SKNft6d8TkTfP6wTOFM9rOIMszJex2X6XQbg+ zL7Wh4oXbFL2L68d+1ACS/zZV/rHubnZ57Sib/yro3sWQ+h3K84oiaS6y30rTKatTTL7 xvGLgEMTq2WrvltcevObxnTqMzTip0cuJjJh3W+Pwp6sm20J0UrCoslS3zTOg/y76mGj OZjbGzOOZ7u5aef5v6xRBdxNfe63xjYMVgjnc9oMA9FhWTB5g5nREqctN1H6obAq4mBK O8rLJ+K2hHghA6mtNMck9+GpIGfs6GD50vIA0veMCHaWn/ezkhOMeZ895patLbj1zJMz GwTQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=qNVwhcNoz+z1Z/nR6VpJk/f4ck4U7XYk4bS1cBDwpO4=; b=HZHHCSUFVUq8XICf0DQaki5YSS+OFH45okKS1SKdEvb2zBpKbsYu1LRwmf1AbCEKPV YYDjiOu4kgO0/azSDYk4jqHBHyviVjch1NCnwX30dhT+HNFkIS8HPH2JfD10OgoejwVh vJa69ULy6wCN4lEl42KbiO1DHsI+aT1NuIJsgcQp0OkC2gZh+51y7nUnsLiS/tZZei7D 1U9AQnnWz+630tthaPYqOkDZmQYnMJ/B5vYfpG+1HeL2ZiV1jbISc2BRLIXxj/+7z1y0 ioCFJNrA60r8wjyskajhtQyhwbYiy9yxLsKnQy/DSMqARq+aPOi7d7eYsCoGIPnH4TC7 UZiQ==
X-Gm-Message-State: AOAM532FUVFAzTQDNH2GPuXwz7mrNozXhwczAH0jVXQZag5qbCaAMH2h xyTW2M5E3PjEP/hZOkqAemSB6A==
X-Google-Smtp-Source: ABdhPJypxU6en7q6TVUUtBl51X0kxiauiIzfnSOc64dBLKIFQwX3j/GkZLjVBCO6hDg5qAY5FC1twQ==
X-Received: by 2002:a17:906:b352:: with SMTP id cd18mr18905316ejb.222.1624185219922; Sun, 20 Jun 2021 03:33:39 -0700 (PDT)
Received: from smtpclient.apple (p200300eb8f0dc7f0302c4efdd0b85c24.dip0.t-ipconnect.de. [2003:eb:8f0d:c7f0:302c:4efd:d0b8:5c24]) by smtp.gmail.com with ESMTPSA id ee47sm1838750edb.51.2021.06.20.03.33.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jun 2021 03:33:39 -0700 (PDT)
From: Torsten Lodderstedt <torsten@lodderstedt.net>
Message-Id: <F860B659-BF55-4209-B138-F15218F60E76@lodderstedt.net>
Content-Type: multipart/alternative; boundary="Apple-Mail=_9E50AB98-9624-4840-A7D7-DFD9174A0927"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\))
Date: Sun, 20 Jun 2021 12:33:38 +0200
In-Reply-To: <CAP-T6TTaspi8+iZb2QSuLemfu_U8PxuZr7tQbX5M4pw00u6vyg@mail.gmail.com>
Cc: Rifaat Shekh-Yusef <rifaat.s.ietf@gmail.com>, oauth <oauth@ietf.org>
To: Dave Tonge <dave.tonge@momentumft.co.uk>
References: <CADNypP9BPovqzQ_=mp-X3xeHv5OTXYXH_D+2ZKXcUhfEhPaYsw@mail.gmail.com> <CAP-T6TTaspi8+iZb2QSuLemfu_U8PxuZr7tQbX5M4pw00u6vyg@mail.gmail.com>
X-Mailer: Apple Mail (2.3654.100.0.2.22)
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/TD7yD_Z7S0uZRUBMtJoDHAqVSho>
Subject: Re: [OAUTH-WG] WG Last Call on the RAR Document
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Jun 2021 10:33:49 -0000

Dear Dave,

thanks a lot for your review!

I create a PR with the changes you proposed. 

https://github.com/oauthstuff/draft-oauth-rar/pull/75 <https://github.com/oauthstuff/draft-oauth-rar/pull/75>

Please review and comment/approve. 

> Am 08.06.2021 um 12:33 schrieb Dave Tonge <dave.tonge@momentumft.co.uk>uk>:
> 
> Dear RAR authors
> 
> Thank you for your work on this draft - I believe it will be very helpful to many ecosystems and am in favour of its progression.

Thank you. 

> 
> A few nits:
> 
> Whole Document
>  - "payment initiation" is I think a PSD2 specific term, I'm not sure about its use in the document, perhaps just "payment API" is sufficient? If it is used, perhaps it needs a definition?

I changed the wording and added a short explanation of the term. Please have a look.

>  
> Introduction
> - "enables the AS to mint RS-specific" - I wonder whether "mint" is a well enough understood term?

Changed it to „issue"

> 
> Section 2
>  - final example in 2.1 - is the array of authorization details supposed to be under the `resources` key?

Good catch. I assume this is a remaining of the back port from GNAP. Fixed it.

> 
> Section 3
>  - Should PAR be added to 6747,8628 and CIBA in section 3? I know it is referenced in 12.4, but I think that RAR and PAR fit very well together and it would be better to call out earlier on in the spec ( it is mentioned extensively in the security and privacy considerations and so I think therefore should be mentioned earlier)

I added a paragraph including references to the security/privacy/implementation considerations.

>  - I suggest that mention is made in section 3 that the RO may grant a subset of the request authorization details. This is mentioned in section 7.1 but I feel it should be addressed in the authorization section. 

I added a note on that.

> 
> Section 7
> The title for section 7.1 could maybe adjusted to simply "Authorization details in Token Response" as it deals with both enrichment and a subset being returned.

Can you please refer to text in 7.1 taking about subsets? 

> In addition I don't think it is clear whether an AS is required to enrich the authorization details. The statement is made
> 
> >  In order to allow the client to determine the
>    accounts it is entitled to access, the authorization server will add
>    this information to the respective authorization details object.
> 
> However a more standard approach currently is that the Client would simply query an `/accounts` endpoint and would receive accounts to which it has been given access to - without having to know their identifiers up front. There could be a situation where a resource owner grants access to all their accounts (including accounts opened in the future). Having the AS be required to fill in the account identifiers in the token response could be restrictive. I think this kind of enrichment is nice, but I suggest that it be made clear that it is optional.

Rephrased it to clearly point out this is _a_ design option.
> 
> Section 12
>  - typo: "follwowing" -> "following"
> 

fixed. 

best regards,
Torsten. 

> Dave
> 
> 
> 
> 
> On Mon, 7 Jun 2021 at 22:19, Rifaat Shekh-Yusef <rifaat.s.ietf@gmail.com <mailto:rifaat.s.ietf@gmail.com>> wrote:
> All,
> 
> This is to start a WG Last Call on the RAR document, that ends June 22nd.
> https://datatracker.ietf.org/doc/html/draft-ietf-oauth-rar-05 <https://www.google.com/url?q=https://datatracker.ietf.org/doc/html/draft-ietf-oauth-rar-05&source=gmail-imap&ust=1623753262000000&usg=AOvVaw1nqrwpNU-gCB0XXukNArYO>
> 
> Please, review the document and provide your feedback on the mailing list. 
> A feedback that states that you have reviewed the document and have no concerns would also be very helpful.
> 
> Regards,
>  Rifaat & Hannes
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org <mailto:OAuth@ietf.org>
> https://www.ietf.org/mailman/listinfo/oauth <https://www.google.com/url?q=https://www.ietf.org/mailman/listinfo/oauth&source=gmail-imap&ust=1623753262000000&usg=AOvVaw2EuCMd5rhjT2dwxeQnZXh7>
> 
> 
> -- 
> Dave Tonge
> CTO
>  <https://www.google.com/url?q=http://www.google.com/url?q%3Dhttp%253A%252F%252Fmoneyhubenterprise.com%252F%26sa%3DD%26sntz%3D1%26usg%3DAFQjCNGUnR5opJv5S1uZOVg8aISwPKAv3A&source=gmail-imap&ust=1623753262000000&usg=AOvVaw2yNcpQiGCRg8dcbEYb3RP2>
> t: +44 (0)117 280 5120
> 
> Moneyhub Enterprise is a trading style of Moneyhub Financial Technology Limited which is authorised and regulated by the Financial Conduct Authority ("FCA"). Moneyhub Financial Technology is entered on the Financial Services Register (FRN 809360) at fca.org.uk/register <https://www.google.com/url?q=http://fca.org.uk/register&source=gmail-imap&ust=1623753262000000&usg=AOvVaw1iKdmU3ux71hBxbtoWOq-S>. Moneyhub Financial Technology is registered in England & Wales, company registration number  06909772 .
> Moneyhub Financial Technology Limited 2018 ©
> 
> DISCLAIMER: This email (including any attachments) is subject to copyright, and the information in it is confidential. Use of this email or of any information in it other than by the addressee is unauthorised and unlawful. Whilst reasonable efforts are made to ensure that any attachments are virus-free, it is the recipient's sole responsibility to scan all attachments for viruses. All calls and emails to and from this company may be monitored and recorded for legitimate purposes relating to this company's business. Any opinions expressed in this email (or in any attachments) are those of the author and do not necessarily represent the opinions of Moneyhub Financial Technology Limited or of any other group company.
> 
> Moneyhub Enterprise is a trading style of Moneyhub Financial Technology Limited which is authorised and regulated by the Financial Conduct Authority ("FCA"). Moneyhub Financial Technology is entered on the Financial Services Register (FRN 809360) at https://register.fca.org.uk/ <https://www.google.com/url?q=https://register.fca.org.uk/&source=gmail-imap&ust=1623753262000000&usg=AOvVaw2tR54FgMdG0bdY3zyLcvST>. Moneyhub Financial Technology is registered in England & Wales, company registration number 06909772. Moneyhub Financial Technology Limited 2020 © Moneyhub Enterprise, Regus Building, Temple Quay, 1 Friary, Bristol, BS1 6EA. 
> 
> DISCLAIMER: This email (including any attachments) is subject to copyright, and the information in it is confidential. Use of this email or of any information in it other than by the addressee is unauthorised and unlawful. Whilst reasonable efforts are made to ensure that any attachments are virus-free, it is the recipient's sole responsibility to scan all attachments for viruses. All calls and emails to and from this company may be monitored and recorded for legitimate purposes relating to this company's business. Any opinions expressed in this email (or in any attachments) are those of the author and do not necessarily represent the opinions of Moneyhub Financial Technology Limited or of any other group company.
> 
> 
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.google.com/url?q=https://www.ietf.org/mailman/listinfo/oauth&source=gmail-imap&ust=1623753262000000&usg=AOvVaw2EuCMd5rhjT2dwxeQnZXh7