IETF Logo Mail Archive

Re: [OAUTH-WG] Genart last call review of draft-ietf-oauth-discovery-07

Mike Jones <Michael.Jones@microsoft.com> Fri, 27 October 2017 22:29 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BC45513F5A9; Fri, 27 Oct 2017 15:29:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.801
X-Spam-Level:
X-Spam-Status: No, score=-4.801 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LI8ZozI9ZypW; Fri, 27 Oct 2017 15:29:36 -0700 (PDT)
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0099.outbound.protection.outlook.com [104.47.37.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4DF7138DE1; Fri, 27 Oct 2017 15:29:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UbcBffLafhzTQBBbvRR2lMWErZZtspI8GwIOKA46+fA=; b=j4gfoeprng4BXtLcC+fPb/J/4wURapr2oeLuaPkH6SpIY/mErxn1Qsk3IEcmpjSw5wW0F+isgTXTU0hOfeamWNBiGAL/RgNpStaYak0k/MQqxHv0525Wg39eAdwEvtZwf+12/eeD6mupdq55GrLmMh6pXj4/ATrukBVJAwva3e0=
Received: from CY4PR21MB0504.namprd21.prod.outlook.com (10.172.122.14) by CY4PR21MB0856.namprd21.prod.outlook.com (10.173.192.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.197.0; Fri, 27 Oct 2017 22:29:35 +0000
Received: from CY4PR21MB0504.namprd21.prod.outlook.com ([10.172.122.14]) by CY4PR21MB0504.namprd21.prod.outlook.com ([10.172.122.14]) with mapi id 15.20.0197.006; Fri, 27 Oct 2017 22:29:35 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Brian Carpenter <brian.e.carpenter@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "oauth@ietf.org" <oauth@ietf.org>, "draft-ietf-oauth-discovery.all@ietf.org" <draft-ietf-oauth-discovery.all@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-oauth-discovery-07
Thread-Index: AQHTOyo9I1g5CQpaC06Nc4/g9OMn56L4b67Q
Date: Fri, 27 Oct 2017 22:29:34 +0000
Message-ID: <CY4PR21MB0504B111EDD33DC3A476F9B8F55A0@CY4PR21MB0504.namprd21.prod.outlook.com>
References: <150691307049.28713.16129351135750922617@ietfa.amsl.com>
In-Reply-To: <150691307049.28713.16129351135750922617@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mbj@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-10-27T15:29:29.1806411-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General
x-originating-ip: [2001:4898:80e8:8::36]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; CY4PR21MB0856; 6:eBW4le2zqff7pPeLAnPbnT20/D1A05rFt/usb4AGK9XdL9790sw2ofUgDGU0CHhfFWfTZuyMGEmkHGco94RJoWFovjJ0yXvyzisjZd0Q2h2igyf2AodHLK0GHeTY14SGRcH3/uW+jsENFSiXvBwmjGZI6DjWnXXudNTaQfuQ2KraWaq6iow9OMJZMdovQst5gSCvqUOkVl0UiJ6xPkwqALzVSyOheWiqz3NLDlOKys6iqYkJOX/tcO7w7qe3jxodwpMMf3qNlvBTq7XeHBz8AnsD1YokbP8BW76VTF9iD+RmUlW9yxFc1yEkRVfSL7uOuTulTZ+fh+2DmdMUkWosldZ+Kz34F4YdeANKuFU3BLs=; 5:m+ZN4RojrjWzkuxJxFXKQGyPIQvVbSrXQiGUPES5P33ibgJ4gn4+l79ZVQTnx933qACqp8FNPMXswI55pGhWni9HtOzUEC5NmT1xfKfTjXFk4i/JBK8YhNEm+U8eMgxel6afDjtsOnspRy6C13IegxEIoZtAzJJ7g+DVjxKuPFw=; 24:NDhZpLOPvRIsONoDnA8t9MB8iimpOSsLeungi7+UNc2j2ECS3AC3QhME+E/Sdy5+jmvrLLeoSBSgPJimue4qwHBRqTW8aLWZkc/G+9GXAk4=; 7:2iwhgqDLaYBRxFMxOz1+vTrLquj3d0gUr8a5JOcuBJWQPMfPLxnZUafNHhtNtVt7179F1KjoeDdMp70WiNLTJiTpUlisjkNY56h0S2+IXQLe6UjfVO5DjVIcLgLGyBx2Yzch+c45oCw+VpqBSxgv8bvEp+4tPz+ui6Wt9Bqio7vus1tCq39VKOAMvkMmRGEEs9ScFfztg2qvKf7tMH/JjW3hLssVk7M8VuvJvbAcSxdepkM1jDrXIGX46cffPiqT
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: f71b707c-1957-4870-9fcd-08d51d8a3390
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603238); SRVR:CY4PR21MB0856;
x-ms-traffictypediagnostic: CY4PR21MB0856:
x-exchange-antispam-report-test: UriScan:;
x-microsoft-antispam-prvs: <CY4PR21MB08568784E4D697B8292B83D9F55A0@CY4PR21MB0856.namprd21.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(2401047)(8121501046)(5005006)(3002001)(3231020)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR21MB0856; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR21MB0856;
x-forefront-prvs: 0473A03F3F
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(346002)(376002)(39860400002)(47760400005)(199003)(377424004)(13464003)(189002)(51914003)(2900100001)(54356999)(50986999)(10290500003)(25786009)(5660300001)(33656002)(14454004)(8676002)(55016002)(7696004)(72206003)(2906002)(189998001)(74316002)(106356001)(10090500001)(7736002)(76176999)(3660700001)(3280700002)(53546010)(101416001)(39060400002)(105586002)(478600001)(77096006)(97736004)(4326008)(229853002)(230783001)(6506006)(102836003)(305945005)(6116002)(6246003)(110136005)(6436002)(8936002)(53936002)(316002)(54906003)(81166006)(99286003)(86362001)(6306002)(81156014)(9686003)(8990500004)(2501003)(2950100002)(86612001)(68736007)(22452003); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0856; H:CY4PR21MB0504.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Michael.Jones@microsoft.com;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f71b707c-1957-4870-9fcd-08d51d8a3390
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2017 22:29:34.8750 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0856
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/Ur25D-V2dfBrWfmK-B_TCFX3znA>
Subject: Re: [OAUTH-WG] Genart last call review of draft-ietf-oauth-discovery-07
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Oct 2017 22:29:39 -0000

Thanks for the review and validating the examples, Brian!

-----Original Message-----
From: Brian Carpenter [mailto:brian.e.carpenter@gmail.com] 
Sent: Sunday, October 1, 2017 7:58 PM
To: gen-art@ietf.org
Cc: oauth@ietf.org; draft-ietf-oauth-discovery.all@ietf.org
Subject: Genart last call review of draft-ietf-oauth-discovery-07

Reviewer: Brian Carpenter
Review result: Ready

Gen-ART Last Call review of draft-ietf-oauth-discovery-07

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-oauth-discovery-07.txt
Reviewer: Brian Carpenter
Review Date: 2017-10-02
IETF LC End Date: 2017-10-09
IESG Telechat date: 

Summary: Ready
--------

Comment:
--------

As far as my competence goes, I have no issues with this draft.
Just for fun, I checked that the JSON example works as the value of a GRASP objective (draft-ietf-anima-grasp) with the GRASP prototype code. And yes, of course it does, so we could map OAuth over the ANIMA discover/synchronize model if we wanted.

FWIW there are a couple of errors in the shepherd's writeup:

> This document does not request any actions by IANA.
>
> 18) List any new IANA registries that require Expert Review for future 
> allocations. Provide any public guidance that the IESG would find 
> useful in selecting the IANA Experts for these new registries.
>
> None.

Wrong, there are extensive IANA considerations and a requirement for multiple Designated Experts.

> There is no text in formal languages in the document. 

Maybe not, but there is a JSON example (which as noted above seems to be fine).

--

v2.23.0 | Report a Bug | By Email