Re: [OAUTH-WG] Comments on draft-ietf-oauth-v2-03.txt

Eran Hammer-Lahav <eran@hueniverse.com> Tue, 11 May 2010 02:53 UTC

Return-Path: <eran@hueniverse.com>
X-Original-To: oauth@core3.amsl.com
Delivered-To: oauth@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 0B3B028C0D6 for <oauth@core3.amsl.com>; Mon, 10 May 2010 19:53:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.437
X-Spam-Level:
X-Spam-Status: No, score=-2.437 tagged_above=-999 required=5 tests=[AWL=0.162, BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OHg8TtC6u28i for <oauth@core3.amsl.com>; Mon, 10 May 2010 19:53:42 -0700 (PDT)
Received: from p3plex1out02.prod.phx3.secureserver.net (p3plex1out02.prod.phx3.secureserver.net [72.167.180.18]) by core3.amsl.com (Postfix) with SMTP id 0691F3A6992 for <oauth@ietf.org>; Mon, 10 May 2010 19:53:41 -0700 (PDT)
Received: (qmail 26888 invoked from network); 11 May 2010 02:53:31 -0000
Received: from unknown (HELO smtp.ex1.secureserver.net) (72.167.180.20) by p3plex1out02.prod.phx3.secureserver.net with SMTP; 11 May 2010 02:53:31 -0000
Received: from P3PW5EX1MB01.EX1.SECURESERVER.NET ([10.6.135.20]) by P3PW5EX1HT002.EX1.SECURESERVER.NET ([72.167.180.20]) with mapi; Mon, 10 May 2010 19:53:30 -0700
From: Eran Hammer-Lahav <eran@hueniverse.com>
To: Marius Scurtescu <mscurtescu@google.com>
Date: Mon, 10 May 2010 19:53:33 -0700
Thread-Topic: [OAUTH-WG] Comments on draft-ietf-oauth-v2-03.txt
Thread-Index: Acrwfa3L0PrXyanRSYKqkERpVq1fWgAN3RxQ
Message-ID: <90C41DD21FB7C64BB94121FBBC2E72343B3AB47130@P3PW5EX1MB01.EX1.SECURESERVER.NET>
References: <4BE730CC.1090607@lodderstedt.net> <90C41DD21FB7C64BB94121FBBC2E72343B3AB46E24@P3PW5EX1MB01.EX1.SECURESERVER.NET> <918F548B-2501-4630-977E-0A7D4484D067@gmail.com> <90C41DD21FB7C64BB94121FBBC2E72343B3AB46E37@P3PW5EX1MB01.EX1.SECURESERVER.NET> <AANLkTimfTF05EWxOdyJrUU3K3IN7kJ7RdDk3mBXN2f41@mail.gmail.com>
In-Reply-To: <AANLkTimfTF05EWxOdyJrUU3K3IN7kJ7RdDk3mBXN2f41@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "OAuth WG (oauth@ietf.org)" <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Comments on draft-ietf-oauth-v2-03.txt
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 May 2010 02:53:43 -0000

Propose text.

EHL

> -----Original Message-----
> From: Marius Scurtescu [mailto:mscurtescu@google.com]
> Sent: Monday, May 10, 2010 1:16 PM
> To: Eran Hammer-Lahav
> Cc: Dick Hardt; OAuth WG (oauth@ietf.org)
> Subject: Re: [OAUTH-WG] Comments on draft-ietf-oauth-v2-03.txt
> 
> On Sun, May 9, 2010 at 10:09 PM, Eran Hammer-Lahav
> <eran@hueniverse.com> wrote:
> >
> >> -----Original Message-----
> >> From: Dick Hardt [mailto:dick.hardt@gmail.com]
> >> Sent: Sunday, May 09, 2010 5:52 PM
> >
> >> >> 3.5.1.  Client Requests Authorization
> >> >>
> >> >> If the client has previously registered a redirection URI with the
> >> >>    authorization server, the authorization server MUST verify that
> >> >> the
> >> >>    redirection URI received matches the registered URI associated
> >> >> with
> >> >>    the client identifier.
> >> >>
> >> >> Does this mean equality? Or just the same base string?
> >> >
> >> > Right now it depends on the server.
> >>
> >> The spec should clarify that. Suggested wording:
> >>
> >>
> >> If the client has previously registered a redirection URI with the
> >> authorization server, the authorization server MUST verify that the
> >> redirection URI received matches the registered URI associated with
> >> the client identifier. The components of the redirection URI that
> >> must match the registered URI is authorization server dependant.
> >
> > I don't see how that helps... I also don't see why we can't just profile this
> and decide on how the matching should be done. We have the state
> parameter to help too.
> 
> I also think the spec should specify how the matching should be done.
> 
> If left up to the authz server then a client that designs its OAuth 2
> implementation will have to assume that all authz servers will do strict
> equality matching, otherwise it may not be able to interact with some
> servers.
> 
> For example, if the client assumes that it can use load balancing by varying
> the first part of the host name, and this may work with the fist authz server it
> integrate with, later this client will not be able to interact with an authz server
> which does strict matching on host name. And changing the load balancing
> architecture once deployed could be very hard.
> 
> Since there is a state parameter maybe it is enough to allow wild cards only in
> the domain name of the callback URI.
> 
> Marius