Re: [OAUTH-WG] Stephen Farrell's No Objection on draft-ietf-oauth-amr-values-07: (with COMMENT)

Mike Jones <Michael.Jones@microsoft.com> Mon, 13 March 2017 16:13 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4FA3F129762; Mon, 13 Mar 2017 09:13:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.021
X-Spam-Level:
X-Spam-Status: No, score=-2.021 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3QpO9OyVV31G; Mon, 13 Mar 2017 09:13:07 -0700 (PDT)
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0091.outbound.protection.outlook.com [104.47.37.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B96FA129715; Mon, 13 Mar 2017 09:13:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EkKITotkx1z6bRodz3UVfKjI+4GlqsbR0/Gt8elwchQ=; b=FBnFiBlHJYiYfqBO/1Fi6M1vKD3jKBE4s1iJbV8PXQyV5GR9eFxLpxj7kZEQzYoK0nRPACfvcKWxZyJ2VziCt+DaRxgPyMMocu8arqWh/RHs2ebNnro7uYINDlwcmTXUKT5S9Jcv942psn8ir6aqaDfH+YfJ4+I7Ywa8hbu9D+8=
Received: from CY4PR21MB0504.namprd21.prod.outlook.com (10.172.122.14) by CY4PR21MB0502.namprd21.prod.outlook.com (10.172.122.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.0; Mon, 13 Mar 2017 16:13:06 +0000
Received: from CY4PR21MB0504.namprd21.prod.outlook.com ([10.172.122.14]) by CY4PR21MB0504.namprd21.prod.outlook.com ([10.172.122.14]) with mapi id 15.01.0991.000; Mon, 13 Mar 2017 16:13:06 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Stephen Farrell <stephen.farrell@cs.tcd.ie>, The IESG <iesg@ietf.org>
Thread-Topic: Stephen Farrell's No Objection on draft-ietf-oauth-amr-values-07: (with COMMENT)
Thread-Index: AQHSnA5b54CrGexD90GVFF1tRC62u6GS8ReA
Date: Mon, 13 Mar 2017 16:13:06 +0000
Message-ID: <CY4PR21MB0504AC9100FDB87A7BEDA459F5250@CY4PR21MB0504.namprd21.prod.outlook.com>
References: <148941885788.17035.8404645820700119652.idtracker@ietfa.amsl.com>
In-Reply-To: <148941885788.17035.8404645820700119652.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: cs.tcd.ie; dkim=none (message not signed) header.d=none;cs.tcd.ie; dmarc=none action=none header.from=microsoft.com;
x-originating-ip: [50.47.93.167]
x-microsoft-exchange-diagnostics: 1; CY4PR21MB0502; 7:o2odQqaZI6zQZBnyrIm2UUkWBlapTT78qBP5UrHpJGi9GJ9DEhh8y7txOn12dHR2OkiE4Dvj6kTXolADo5SvT1kZSG1fNMbbKOluPchwtUepvP8WwneqlasXGMFtmu9CJF6Ig5cudQj4jKsqF/ZRUKsa2nLTGFt2E+OjPMtBuJZYMtpr4dKj9OC6TBPgdN66+1rRSGMObb50REKSwNJVDbYLpDlsvPNflwSnZfW1hy4R/NnftB/k/sIm+KXAO9Otrrbi1Kya1IYFcUZ1IgUaOejH6epKRzZtf5PLnF4xeYa+nXr7OosW6w7ChQHAJZU63PPzYuYRlxfZLdzJ6p7qCXJBN4xoZh1FC+MVHIHeuAE=
x-ms-office365-filtering-correlation-id: bfcdd32b-cba1-4f4a-dcd3-08d46a2bd575
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254009)(48565401081); SRVR:CY4PR21MB0502;
x-microsoft-antispam-prvs: <CY4PR21MB05023BB2B9D8C2A218D5C24FF5250@CY4PR21MB0502.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(32856632585715)(120809045254105)(248736688235697);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123562025)(20161123558025)(20161123555025)(20161123560025)(20161123564025)(6072148); SRVR:CY4PR21MB0502; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0502;
x-forefront-prvs: 0245702D7B
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39850400002)(39860400002)(39840400002)(39410400002)(39450400003)(377454003)(2950100002)(7696004)(54356999)(50986999)(76176999)(53546006)(3846002)(6116002)(102836003)(4326008)(3280700002)(5660300001)(3660700001)(2900100001)(77096006)(25786008)(189998001)(6506006)(106116001)(99286003)(54906002)(229853002)(6306002)(6436002)(55016002)(9686003)(33656002)(53936002)(5005710100001)(10290500002)(81166006)(8676002)(10090500001)(8990500004)(74316002)(66066001)(8936002)(2906002)(7736002)(122556002)(6246003)(86362001)(86612001)(38730400002)(230783001)(305945005); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0502; H:CY4PR21MB0504.namprd21.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2017 16:13:06.0739 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0502
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/XZSI0mxHHjmICE5rwk7XG1oimh0>
Cc: "oauth-chairs@ietf.org" <oauth-chairs@ietf.org>, "draft-ietf-oauth-amr-values@ietf.org" <draft-ietf-oauth-amr-values@ietf.org>, "oauth@ietf.org" <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Stephen Farrell's No Objection on draft-ietf-oauth-amr-values-07: (with COMMENT)
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Mar 2017 16:13:09 -0000

Thanks, Stephen.  I'll try to apply the suggested changes before the cutoff.

				-- Mike

-----Original Message-----
From: Stephen Farrell [mailto:stephen.farrell@cs.tcd.ie] 
Sent: Monday, March 13, 2017 8:28 AM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-oauth-amr-values@ietf.org; Hannes Tschofenig <Hannes.Tschofenig@gmx.net>; oauth-chairs@ietf.org; Hannes.Tschofenig@gmx.net; oauth@ietf.org
Subject: Stephen Farrell's No Objection on draft-ietf-oauth-amr-values-07: (with COMMENT)

Stephen Farrell has entered the following ballot position for
draft-ietf-oauth-amr-values-07: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-oauth-amr-values/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------


Thanks for clarifying that amr represents classes of auth methods and not (always) individual methods, that all makes more sense now;-)

I think you might usefully add the phrase "classes of" (or similar) to the draft in a few places to help folks understand that, in particular, I spotted two places where I think something like that'd be good:

1. in the definition, I'd suggest:

OLD:

 amr
      OPTIONAL.  Authentication Methods References.  JSON array of
      strings that are identifiers for authentication methods used in
      the authentication. 

NEW:

 amr
      OPTIONAL.  Authentication Methods References.  JSON array of
      strings that are identifiers for classes of authentication methods used in
      the authentication. 

2. In the IANA considerations and DE guidance, maybe make the name of the new registry reflect that these are classes, in case someone gets confused only having looked at the IANA pages without reading the RFC, and perhaps point the DE guidance back to the top bit where you explain this stuff and add "classes of" in a few places in the template to save the DEs having to explain that over and over to people who just copy templates.

Thanks,
S.