[OAUTH-WG] Re: Mike Bishop's No Objection on draft-ietf-oauth-browser-based-apps-24: (with COMMENT)

Aaron Parecki <aaron@parecki.com> Wed, 28 May 2025 16:05 UTC

Return-Path: <aaron@parecki.com>
X-Original-To: oauth@mail2.ietf.org
Delivered-To: oauth@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id DF92E2DF023A for <oauth@mail2.ietf.org>; Wed, 28 May 2025 09:05:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (2048-bit key) header.d=parecki.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lxahG9MKlVlH for <oauth@mail2.ietf.org>; Wed, 28 May 2025 09:05:05 -0700 (PDT)
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id C782E2DF021E for <oauth@ietf.org>; Wed, 28 May 2025 09:05:05 -0700 (PDT)
Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-54d98aa5981so7162184e87.0 for <oauth@ietf.org>; Wed, 28 May 2025 09:05:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=parecki.com; s=google; t=1748448304; x=1749053104; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/zgEsZiIBAD+bbW8MFM0SVxPp3qpxJ/13Qsdp70uIlk=; b=gMyHZxf/7BnfuB4H8uPWZtzxhfXsdRIXEdU6cpS8DVKGb0OHBsPRLr2uIaG60iW58x iE0yza8P+7Umk+yv/z2DMuGhLsMPp3jRrdKXPkz4UNv4Oa2Sne4LvpfaDyT9n+Lw7Sez v/zP6G+xTfdd/fg2gQNC7ppjdUakx8tsT2TjWiNnol7zc5SOq3JbskK4FDuaRcBoH06D xQRCTkSGW6DdT/+cPq1mTs8Uy5rBsOQ4hc0qPl2RkJ/iXDqOPXcv7w7NAfX/GaDkExTK IooALPBp9RYk04Dqz8WZxq3QUIf68RNDBOlOZwM/dQAwp7qNTDcPA8MIHmbZV7pIFpeW A7Rw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748448304; x=1749053104; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/zgEsZiIBAD+bbW8MFM0SVxPp3qpxJ/13Qsdp70uIlk=; b=fauu2OlrCSRHO2ungm0v5LpZSFc+eSUxhqMFbhdZfrsWVc01mklH500B4PxCQM83ql xk/b4uvqHZyMqKP/oCbaP+AhWKMVDpuN0o6rGTBsnUwKrTkmrH0D99N508avIxzOOuJv KAtP4U298Rthkne+RZjy2IpNXszennxt4kMlUXFZZ9Nh6OkKv7nJRjVCtq06nK1gDxVA NI7fq73tSjNaXkse8LzTJwBYVMrHzp2gw8T3tJ6HR6JnDoGB5am12TxSyPZCwZd0m9hE RDjYvW8n9CoAoWjR+xbYZHcK2SCHfAUw3UW6K9Yr0AoXFGP0pVNoRQwTtdlZduTlnvlP Np/Q==
X-Forwarded-Encrypted: i=1; AJvYcCVqa/gbi1SLVypvg5vDamHEKY+AM342oj1mF6CSg47JbI2FRw+goiSoBqmNqrm1/HuSdNbeIA==@ietf.org
X-Gm-Message-State: AOJu0YzE05F6rPpmEvRLb7illR11hjBpJixX3gh+k25szC9k4FM4TtmV q4U89jczspRaYewQjWa5PovY35iW7D8XbZVlgG9+pWYr3OcsIhW9E2GxGrabxjOh4A==
X-Gm-Gg: ASbGncv31jIfgBdcNaTKHvJmrYw7NeXH8mEBaHtkUhocRPqGp/ES+rIGkwI/BlquqKK mDD3Qzw111bFxIzpKOMpT0rh5BwGC4J5CGY3sS+pb+Li9PNdZuSJwQOwyj9D7OBYh3xXwBfDfj8 WLHFA8LXuE0O6TfX9uz6RF35jKMeA6Gnyc1QiOcOF+xvQnWm6Q17/16BaTS4zD8icB4EA0gcYnt MkIwA2cgqBQKrrHf+v8eG4RenQBFN3Rd1VvLcf9FlB62RHk5DW34smqJ4e5/H6uONfYhCuORKy1 V7kd0ccoG049JwvNJFgZimAHzHuWkhByfDsJcbJZsctSL2dAR60R547fIq3w3YgAMhVyMF2toqE aVdw5nvQu6Q==
X-Google-Smtp-Source: AGHT+IFz2JuqLy/E5JQG5/CkHQ3lzgw2WSvSf6nhRHDGNLf4mJlXK7lWObnULLxCHfNdyuqFB05KRQ==
X-Received: by 2002:a05:6512:1385:b0:553:2882:d79b with SMTP id 2adb3069b0e04-5532882d9ffmr2567681e87.32.1748448304269; Wed, 28 May 2025 09:05:04 -0700 (PDT)
Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5532f6a5e63sm336883e87.171.2025.05.28.09.05.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 09:05:03 -0700 (PDT)
Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-54b09cb06b0so5273467e87.1; Wed, 28 May 2025 09:05:03 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCVu01OnvbKDcFyYJ0Mb0OwisL8A7r/lZS+qoAJKJZkIOraCROIbKHmMDBCbpBNfg3ZkqVzvZ/c=@ietf.org, AJvYcCW/Zp3UIAEIpQLbjJ6uk9sMvhgraKsKCUfmwX8oWcwdUrwXR/JISZJ8JBUL8sZKzMyHIx9MXT7rej9V6UDO@ietf.org, AJvYcCWo2kVXj82hLvbXfJYttBW37mZzA/rCI3F36PCDjdr/XVNWvt6nH4FRZ2103wO9CDZCZ3KPnR+qJDeFapfI5inwtACZcAZGckR/O0QnrIgxXZNsSA==@ietf.org
X-Received: by 2002:a05:651c:1506:b0:30c:160b:c766 with SMTP id 38308e7fff4ca-3295ba2491bmr47999271fa.14.1748448303037; Wed, 28 May 2025 09:05:03 -0700 (PDT)
MIME-Version: 1.0
References: <174545907709.2490841.13272614002933286637@dt-datatracker-64c5c9b5f9-hz6qg>
In-Reply-To: <174545907709.2490841.13272614002933286637@dt-datatracker-64c5c9b5f9-hz6qg>
From: Aaron Parecki <aaron@parecki.com>
Date: Wed, 28 May 2025 09:04:51 -0700
X-Gmail-Original-Message-ID: <CAGBSGjqhizb7qz-P0Ra6QfyVH2jY1oWcXgTWM0TJevGzpDYArw@mail.gmail.com>
X-Gm-Features: AX0GCFuiagvojOHzSRYxaTTkSmZJqNCMqzUoD-6HDKZdT6rHZnYk7FS392Sbr70
Message-ID: <CAGBSGjqhizb7qz-P0Ra6QfyVH2jY1oWcXgTWM0TJevGzpDYArw@mail.gmail.com>
To: Mike Bishop <mbishop@evequefou.be>
Content-Type: multipart/alternative; boundary="00000000000002c39b06363458a2"
Message-ID-Hash: YXBYM4PPAO2XYYBUPLJUTA6EWRNTBV7V
X-Message-ID-Hash: YXBYM4PPAO2XYYBUPLJUTA6EWRNTBV7V
X-MailFrom: aaron@parecki.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-oauth.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: The IESG <iesg@ietf.org>, draft-ietf-oauth-browser-based-apps@ietf.org, oauth-chairs@ietf.org, oauth@ietf.org
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [OAUTH-WG] Re: Mike Bishop's No Objection on draft-ietf-oauth-browser-based-apps-24: (with COMMENT)
List-Id: OAUTH WG <oauth.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/_X0mGUbeNrwmtAupB4nNiz0zQQ4>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Owner: <mailto:oauth-owner@ietf.org>
List-Post: <mailto:oauth@ietf.org>
List-Subscribe: <mailto:oauth-join@ietf.org>
List-Unsubscribe: <mailto:oauth-leave@ietf.org>

Thanks for your review Mike! Answers inline:


On Wed, Apr 23, 2025 at 6:44 PM Mike Bishop via Datatracker <
noreply@ietf.org> wrote:

>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Thank you for a solid and well-written document. Definitely a pleasure to
> read
> such a thorough analysis.
>
> The document states, "Given the popularity of this scenario, this document
> uses
> the term "JavaScript" to refer to all mechanisms that allow code to
> execute in
> the application's runtime in the browser. The recommendations and
> considerations in this document are not exclusively linked to the
> JavaScript
> language or its runtime, but also apply to other languages and runtime
> environments in the browser." I understand the temptation because of how we
> often speak about browser code, but that seems like a recipe for confusion
> --
> how about not doing that? Use JavaScript when you actually mean JavaScript
> itself, and use "browser-based apps" when you're more general (which is
> most of
> the time).
>
> Please also be consistent in your usage of JavaScript versus JS. We can
> afford
> the extra characters unless you're referring to the standard file
> extension.
>

I've done a thorough update to the language to be consistent with the
terminology here. All references should now say "browser-based application"
when referring to the general case, and "JavaScript" only when talking
about specific JavaScript APIs.


>
> Nit:
>
> - Why is "The first part (Section 5.1)" not simply "Section 5.1"? Same with
> second/5.2.
>

Thanks, fixed.

These changes are not yet posted to datatracker but you can see them on the
GitHub diffs:

*
https://github.com/oauth-wg/oauth-browser-based-apps/commit/f33b5f02b67de0aea697f4a45a5970e7df7d4b8f
*
https://github.com/oauth-wg/oauth-browser-based-apps/commit/7d72df77b94b62a6a8141ffb4e6ae32fb6745dfd


The preview build of the doc is here:

https://drafts.oauth.net/oauth-browser-based-apps/draft-ietf-oauth-browser-based-apps.html

Thanks!

Aaron