Re: [OAUTH-WG] tsv-dir review of draft-ietf-oauth-v2-23

Eran Hammer <eran@hueniverse.com> Thu, 08 March 2012 05:30 UTC

Return-Path: <eran@hueniverse.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0888521E8050 for <oauth@ietfa.amsl.com>; Wed, 7 Mar 2012 21:30:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.538
X-Spam-Level:
X-Spam-Status: No, score=-2.538 tagged_above=-999 required=5 tests=[AWL=0.061, BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CMMN1tea2GLF for <oauth@ietfa.amsl.com>; Wed, 7 Mar 2012 21:30:36 -0800 (PST)
Received: from p3plex1out01.prod.phx3.secureserver.net (p3plex1out01.prod.phx3.secureserver.net [72.167.180.17]) by ietfa.amsl.com (Postfix) with SMTP id E72AB21E8029 for <oauth@ietf.org>; Wed, 7 Mar 2012 21:30:35 -0800 (PST)
Received: (qmail 359 invoked from network); 8 Mar 2012 05:30:35 -0000
Received: from unknown (HELO smtp.ex1.secureserver.net) (72.167.180.19) by p3plex1out01.prod.phx3.secureserver.net with SMTP; 8 Mar 2012 05:30:35 -0000
Received: from P3PW5EX1MB01.EX1.SECURESERVER.NET ([10.6.135.20]) by P3PW5EX1HT001.EX1.SECURESERVER.NET ([72.167.180.19]) with mapi; Wed, 7 Mar 2012 22:29:48 -0700
From: Eran Hammer <eran@hueniverse.com>
To: Songhaibin <haibin.song@huawei.com>, "tsv-ads@tools.ietf.org" <tsv-ads@tools.ietf.org>, "draft-ietf-oauth-v2@tools.ietf.org" <draft-ietf-oauth-v2@tools.ietf.org>
Date: Wed, 7 Mar 2012 22:29:39 -0700
Thread-Topic: tsv-dir review of draft-ietf-oauth-v2-23
Thread-Index: AczrxK1m0Cmrx5G1TqO2SHCpS5HjoQQ+W/QAAASPNnAABwRTYA==
Message-ID: <90C41DD21FB7C64BB94121FBBC2E723453AFCD409B@P3PW5EX1MB01.EX1.SECURESERVER.NET>
References: <E33E01DFD5BEA24B9F3F18671078951F156D8F4B@szxeml534-mbx.china.huawei.com> <90C41DD21FB7C64BB94121FBBC2E723453AFCD407B@P3PW5EX1MB01.EX1.SECURESERVER.NET> <E33E01DFD5BEA24B9F3F18671078951F156E0D21@szxeml534-mbx.china.huawei.com>
In-Reply-To: <E33E01DFD5BEA24B9F3F18671078951F156E0D21@szxeml534-mbx.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: Martin Stiemerling <Martin.Stiemerling@neclab.eu>, "oauth@ietf.org" <oauth@ietf.org>, "tsv-dir@ietf.org" <tsv-dir@ietf.org>
Subject: Re: [OAUTH-WG] tsv-dir review of draft-ietf-oauth-v2-23
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2012 05:30:37 -0000

Should simple read "the attacker's user-agent is sent to".

EH

> -----Original Message-----
> From: Songhaibin [mailto:haibin.song@huawei.com]
> Sent: Wednesday, March 07, 2012 6:11 PM
> To: Eran Hammer; tsv-ads@tools.ietf.org; draft-ietf-oauth-v2@tools.ietf.org
> Cc: tsv-dir@ietf.org; oauth@ietf.org; Martin Stiemerling
> Subject: RE: tsv-dir review of draft-ietf-oauth-v2-23
> 
> > > 5. Section 10.6, paragraph 2, second sentence, When the attacker is
> > > sent to.../ When the authorization code request is sent to...
> >
> > Not sure what you mean.
> 
> I mean you may have to change "the attacker is sent to..." to "the
> authorization code is sent to...".
> 
> BR,
> -Haibin
> 
> > -----Original Message-----
> > From: Eran Hammer [mailto:eran@hueniverse.com]
> > Sent: Thursday, March 08, 2012 8:16 AM
> > To: Songhaibin; tsv-ads@tools.ietf.org;
> > draft-ietf-oauth-v2@tools.ietf.org
> > Cc: tsv-dir@ietf.org; oauth@ietf.org; Martin Stiemerling
> > Subject: RE: tsv-dir review of draft-ietf-oauth-v2-23
> >
> > Thanks Haibin.
> >
> > > -----Original Message-----
> > > From: Songhaibin [mailto:haibin.song@huawei.com]
> > > Sent: Wednesday, February 15, 2012 1:33 AM
> >
> > > Nits:
> > > 1. Section 3.1, paragraph 4, the last sentence is confusing, is it
> > > the authorization server who sends the request to the authorization
> endpoint?
> > > Or is it the resource owner?
> >
> > The client. Added clarification in section 3.
> >
> > > 2. Section 3.1.1, paragraph 3, "...where the order of values does not
> matter.."
> > > I think a little clarification on the reason for this would be
> > > better for people like me.
> >
> > I don't think we need to explain it, but it's to meet typical developers'
> > expectations.
> >
> > > 3. Section 3.2, paragraph 4, the last sentence is confusing, is it
> > > the authorization server who sends request to the token endpoint?
> >
> > Same as #1.
> >
> > > 4. Section 10.12, paragraph 4, should the terminology "end-user" be
> > > changed to "resource owner"? There are same issues in other places
> > > of this document.
> >
> > Changed some. Clarified end-user in the intro.
> >
> > > 5. Section 10.6, paragraph 2, second sentence, When the attacker is
> > > sent to.../ When the authorization code request is sent to...
> >
> > Not sure what you mean.
> >
> > EH
> >