Re: [OAUTH-WG] PKCE/SPOP

Nat Sakimura <sakimura@gmail.com> Wed, 04 February 2015 02:38 UTC

Return-Path: <sakimura@gmail.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0CD6D1A1A39 for <oauth@ietfa.amsl.com>; Tue, 3 Feb 2015 18:38:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q_tk1-5B-_oL for <oauth@ietfa.amsl.com>; Tue, 3 Feb 2015 18:38:24 -0800 (PST)
Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com [IPv6:2607:f8b0:4003:c01::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 637641A1A8B for <oauth@ietf.org>; Tue, 3 Feb 2015 18:38:21 -0800 (PST)
Received: by mail-ob0-f178.google.com with SMTP id uz6so25618729obc.9 for <oauth@ietf.org>; Tue, 03 Feb 2015 18:38:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HKkOuZu++ETHN/+nlqgsKRgqnZTGJsGYgtnMytcCFP8=; b=RC6cBugVgr55YU/5tIMkkvkywRaqaX2d1roaV3Ru3TYnhrTSGKMHqQ7w/s8fCPcJsz RuWmdNQTW4mP0SObmsFxZwqvr6Oij5rNotkPWJVatrBWUZgi/Ng0AD+fv3QD+DBT5VYk bgowBK0bwNRWMr8IiaeXF3NQTbTwaHwW9YbodUd6xHd74bwGguVsR/ItkP7AOwITvfar EvFmlY+2Ce/qOnCwv4Vic6IQU0p0+re+rLSdAV2ftngUoM+Q+W3M/1AXoUle+US9EWtX Sc+R0Eps93AXS8WFEgrnopevQ7aLC6buk0QNmSle4mQwe27zo4CqR9K1j365YIMde2ue DREg==
MIME-Version: 1.0
X-Received: by 10.182.81.98 with SMTP id z2mr17732953obx.35.1423017500644; Tue, 03 Feb 2015 18:38:20 -0800 (PST)
Received: by 10.60.171.196 with HTTP; Tue, 3 Feb 2015 18:38:20 -0800 (PST)
In-Reply-To: <CAAP42hBSZz-t-VRg+2VTYwneO9wVTZDr9LCPhumTP3jtxZmPsQ@mail.gmail.com>
References: <5CB2DAD4-1C61-4910-A866-4C18F4A9A3FE@ve7jtb.com> <CA+k3eCQmFsR95d+6Y0Ub=hVMdCB_siNMsKKrJYB3LXgsczfJrA@mail.gmail.com> <E57A72CF-C02A-47AA-B8CC-72795F57F3D8@ve7jtb.com> <CAAP42hBSZz-t-VRg+2VTYwneO9wVTZDr9LCPhumTP3jtxZmPsQ@mail.gmail.com>
Date: Wed, 4 Feb 2015 11:38:20 +0900
Message-ID: <CABzCy2DRHqNfHdrqbiaiuz5Gds+VqE3y22GvhxJDDp=hnSd1hA@mail.gmail.com>
From: Nat Sakimura <sakimura@gmail.com>
To: William Denniss <wdenniss@google.com>
Content-Type: multipart/alternative; boundary=047d7b2e4858a29cee050e3a14b5
Archived-At: <http://mailarchive.ietf.org/arch/msg/oauth/gcjp8D0vFxQ7nCXR8w63-TAJgYU>
Cc: oauth <oauth@ietf.org>
Subject: Re: [OAUTH-WG] PKCE/SPOP
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Feb 2015 02:38:27 -0000

Hmmm. A bug at ietf.org rendering engine?
Perhaps we may repeat of RFC4648 again there to avoid this behaviour.

2015-02-04 10:50 GMT+09:00 William Denniss <wdenniss@google.com>om>:

> Speaking of Base64url, where it's defined in "Notational Conventions", is
> there a way to prevent the HTML markup automatically linkifying "Section
> 3.2" ?  It's not marked up in the XML, but in the HTML output it is – and
> the auto-generated link is incorrect, as it points to Section 3.2 in SPOP,
> rather than 3.2 in RFC4648.
>
> This may seem trivial, but the fact that we're using a less common variant
> of Base64url makes me want to provide as much accurate context as possible
> to help implementers.
>
> This is how it renders today (note the Section 3.2 link)
>
>    Base64url Encoding  Base64 encoding using the URL- and filename-safe
>       character set defined in Section 5 of RFC 4648 <http://tools.ietf.org/html/rfc4648#section-5> [RFC4648 <http://tools.ietf.org/html/rfc4648>], with all
>       trailing '=' characters omitted (as permitted by Section 3.2 <http://tools.ietf.org/html/draft-ietf-oauth-spop-08#section-3.2>) and
>       without the inclusion of any line breaks, whitespace, or other
>       additional characters.  (See Appendix A <http://tools.ietf.org/html/draft-ietf-oauth-spop-08#appendix-A> for notes on implementing
>       base64url encoding without padding.)
>
>
>
> On Tue, Feb 3, 2015 at 6:51 AM, John Bradley <ve7jtb@ve7jtb.com> wrote:
>
>> OK I fixed that in bitbucket.
>>
>> If I don’t hear back from anyone else I will push that version to the doc
>> tracker this afternoon.
>>
>> John B.
>>
>>
>> On Feb 3, 2015, at 10:40 AM, Brian Campbell <bcampbell@pingidentity.com>
>> wrote:
>>
>> I went thought appendix B and reproduced the same calculations. Which is
>> nice.
>>
>> One little nit - to be consitent with the notation defined in §2, the appendix
>> B should have
>>
>>    BASE64URL(SHA256(ASCII("code_verifier"))) == code_challenge
>>
>> rather than
>>
>>    Base64url(SHA256(ASCII("code_verifier" ))) == code_challenge
>>
>>
>>
>>
>> On Sun, Feb 1, 2015 at 5:07 PM, John Bradley <ve7jtb@ve7jtb.com> wrote:
>>
>>>
>>> https://bitbucket.org/Nat/oauth-spop/raw/cd8b86496fb59261103143c246658da06e99c225/draft-ietf-oauth-spop-00.txt
>>>
>>> I made some edits to the copy in bitbucket.
>>>
>>> I changed the reference for unreserved URI characters to RFC3986. The
>>> Base64 spec we were pointing to is slightly different.
>>> The change allows someone in the future to define a new
>>> code_challenge_method that would allow a JWT to be valid.
>>> We unintentionally precluded the use of the “.” in code_challenge and
>>> code_verifier.
>>>
>>> I also added an appendix B to show the steps of S256 in a way someone
>>> could use as a test vector.
>>>
>>> Appendix B is a first cut at it so give me feedback, and I can push it
>>> to the document tracker later in the week.
>>>
>>>
>>> John B.
>>>
>>>
>>> _______________________________________________
>>> OAuth mailing list
>>> OAuth@ietf.org
>>> https://www.ietf.org/mailman/listinfo/oauth
>>>
>>>
>>
>>
>> _______________________________________________
>> OAuth mailing list
>> OAuth@ietf.org
>> https://www.ietf.org/mailman/listinfo/oauth
>>
>>
>
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth
>
>


-- 
Nat Sakimura (=nat)
Chairman, OpenID Foundation
http://nat.sakimura.org/
@_nat_en