Re: [OAUTH-WG] Google's OAuth endpoints now fully support PKCE (RFC7636)

John Bradley <ve7jtb@ve7jtb.com> Tue, 19 January 2016 12:33 UTC

Return-Path: <ve7jtb@ve7jtb.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C93AB1B2D77 for <oauth@ietfa.amsl.com>; Tue, 19 Jan 2016 04:33:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GQ6bc7XNcanQ for <oauth@ietfa.amsl.com>; Tue, 19 Jan 2016 04:33:04 -0800 (PST)
Received: from mail-qg0-x22c.google.com (mail-qg0-x22c.google.com [IPv6:2607:f8b0:400d:c04::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 74C061B2D76 for <oauth@ietf.org>; Tue, 19 Jan 2016 04:33:04 -0800 (PST)
Received: by mail-qg0-x22c.google.com with SMTP id b35so447519691qge.0 for <oauth@ietf.org>; Tue, 19 Jan 2016 04:33:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ve7jtb-com.20150623.gappssmtp.com; s=20150623; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=ZLFQIqwl8TT+JBrWyuhfInWCnPEdofW2O89zQ2eNFVo=; b=FVjuvUgv3Xm8BxVLj+PlG/PrDZHjY1i6XRmRzF5xqSWkrCP7RzSqSv2t2lhtD9Jp86 rRwCIK+laXcCtC1c5ElFQM1uXtCmT/vIY/tt/AYyFbA865Aso0/vFWddXtXp4CKKpLS3 nTUlIZCTpw2GiZDSiw679MsRykMmLGaIg5M8LrEfdfrTHb1SRBzyAb+wB4s5i4iUO7sI GTZugqq6rN0oi54j6a/2S4fayVYomqSxj2cCHjkHBQWdJnPRwQsrghPMTORoafSnGrhO npE2fQ2Fvz4QGeu/qm/453RIyx+3tuAG3iCQdXef+/fl3n3pDlZrZjFtzFM+DDkOLDyh y7mg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=ZLFQIqwl8TT+JBrWyuhfInWCnPEdofW2O89zQ2eNFVo=; b=S566YogeIFSSlEgLtWR6OewpuwXdLjr1H50NFVmzzviIFKRJtDjZbZyNNH8wwcxHWF EInfIdMlzIlOIptMSOfd4VnFz3/rQgGDJBDYW7fhoRKM1Z/0MJdvaOGpKMW6Ho2FNyl+ Mn7THhOKzs6jeaM7ZrRxHsY3XiUECZu4WRihRPNjYTFNG4CQNSf4s19MNw3OHpzgi8EG GpTV/dr/U+vW7StokfvsY/rpkX0jt5EQAQUH2PMIElaDFsKjkzdWpLHiVgQ3Hw7x8B6X pMZhCKvUmA9UnYqVY9IN7tVbec8S4tsc0c8scgar4GnrWE2VyywqDtGttV67CFUbeNaU 1QwQ==
X-Gm-Message-State: ALoCoQlHy9gjcRxXx1eVBVQJ2U+++HF62I95KbgyYDVtkoASA1kG/Xnlb8/Jy+mcy+m1nUz4TTFw0GWnfNJKQsZB18D8rYGWtw==
X-Received: by 10.140.158.4 with SMTP id e4mr39669437qhe.81.1453206783377; Tue, 19 Jan 2016 04:33:03 -0800 (PST)
Received: from [192.168.1.37] ([191.115.68.227]) by smtp.gmail.com with ESMTPSA id 138sm11970647qho.48.2016.01.19.04.33.00 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jan 2016 04:33:02 -0800 (PST)
Content-Type: multipart/signed; boundary="Apple-Mail=_25B7AEDF-82C7-453A-AE42-596570A2C579"; protocol="application/pkcs7-signature"; micalg=sha1
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
From: John Bradley <ve7jtb@ve7jtb.com>
In-Reply-To: <CAAP42hD3vpwnBYzu6YZVXtTimVuFHzgQ9Pksn1RQNEwogPZRJw@mail.gmail.com>
Date: Tue, 19 Jan 2016 09:32:41 -0300
Message-Id: <8E6EBF44-2057-4429-8347-1BA447C3F3DB@ve7jtb.com>
References: <CAAP42hD3vpwnBYzu6YZVXtTimVuFHzgQ9Pksn1RQNEwogPZRJw@mail.gmail.com>
To: William Denniss <wdenniss@google.com>
X-Mailer: Apple Mail (2.3112)
Archived-At: <http://mailarchive.ietf.org/arch/msg/oauth/l4ugIMwHd4uQ1kKXj0gELeN1JCk>
Cc: "oauth@ietf.org" <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Google's OAuth endpoints now fully support PKCE (RFC7636)
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2016 12:33:07 -0000

Great news.

If you have sent a PKCE challenge and no verifier that should be a authentication failure as if the value were wrong.

I don’t know if it needs a special error.

Thanks for bringing it up.

John B.

> On Jan 19, 2016, at 2:46 AM, William Denniss <wdenniss@google.com>; wrote:
> 
> This month we rolled out full PKCE (RFC7636) support on our OAuth endpoints.
> 
> We'd previously implemented an earlier draft but were not conformant to the final spec when it was published – now we are. Both "plain" and "S256" transforms are supported. As always, get the latest endpoints from our discovery document: https://accounts.google.com/.well-known/openid-configuration <https://accounts.google.com/.well-known/openid-configuration>
> 
> If you give it a spin, let me know how you go! The team monitors the Stack Overflow google-oauth <http://stackoverflow.com/questions/tagged/google-oauth> tag too, for any implementation questions.
> 
> I'm keen to know what we should be putting in our discovery doc to declare PKCE support (see the thread "Advertise PKCE support in OAuth 2.0 Discovery"), hope we can agree on that soon.
> 
> One implementation detail not covered in the spec: we error if you send code_verifier to the token endpoint when exchanging a code that was issued without a code_challenge being present. The assumption being that if you are sending code_verifier on the token exchange, you are using PKCE and should have sent code_challenge on the authorization request, so something is amiss.
> 
> William
> 
> 
> 
> 
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth