IETF Logo Mail Archive

Re: [OAUTH-WG] Review of draft-ietf-oauth-jwsreq-11

Nat Sakimura <sakimura@gmail.com> Mon, 06 February 2017 14:14 UTC

Return-Path: <sakimura@gmail.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BC69A129DA3; Mon, 6 Feb 2017 06:14:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S9ULawRVM7Xc; Mon, 6 Feb 2017 06:14:34 -0800 (PST)
Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F3EA1129D9A; Mon, 6 Feb 2017 06:14:33 -0800 (PST)
Received: by mail-wm0-x233.google.com with SMTP id b65so122241168wmf.0; Mon, 06 Feb 2017 06:14:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iqBblcxBJpi94r0QkcVPXBz5Ak3RnGNdiseim23l63Y=; b=Z4qk0H28s5x8/cN2gCOX44yygp7owC4OexSZsEoBArWKs3RhFD1Gw6mWEdcibR2SpT r94lCuL1OWezUxOzv6Z47p6LLK9GKe/yZlEAuHSAMfq0yDFH25gVp5sCZtG/Yb/xo6QZ JScaGEhDnnzDFec7Ag8aN/VJvD797L81OsNKRV/nRzbrvc6GZo8belSbdauQhnRenvUh VPMRIXhL4gyLOiAunGkQ2UuBh+4oCC7kh/Gm2ASkBARODWLqaRUlKVHmFp4la3/+epvD a6yE5tnjtKmahIXokC8N0UqMdtWcTxxFPBg5B0YVg0PqgJ80XEhcT1eOaE2Gy0Sm6nex 16hw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iqBblcxBJpi94r0QkcVPXBz5Ak3RnGNdiseim23l63Y=; b=iejT9xN/M+KOr9LvdafiOXyGTX734BA406hRbLqy2Hcohw0pZrzi7pjpoyA2bTZyVM R9O7ff6oaqWl1SOwjda/cwkZEzyQNjywtgyUHKgy8lPxOA5cb6nEm9OCCXK3kGcbICPL HZPm1cZDH3QMpRWFUWrInDP8NP2qUaTaDk7ta+XtaU9GAZHZ1QnA2/CUTHLYpBMnD5iA /6/Sq+6IyVqmXtM4PQLlxvYn+guRvAFUSAVQS+1/N07FNSVPsxfS0GHTViG7jz/EOqjv 1D5aI5YA7do+5DURY5estCDBt/+QKLFpumo0QdVfaiDtXPgHt7CuBBX2ZqpuWYupCgWl 88wA==
X-Gm-Message-State: AMke39kvq8OKJYdiF24k5eIH2AwAj4GRUEeELVJTxWA9HLJ2sEtzx7MmN1p2Vsqiem4N6rj639Cq8XdmuFCDmQ==
X-Received: by 10.28.1.216 with SMTP id 207mr9593070wmb.7.1486390472437; Mon, 06 Feb 2017 06:14:32 -0800 (PST)
MIME-Version: 1.0
References: <148607662042.13885.2832003093930390561.idtracker@ietfa.amsl.com>
In-Reply-To: <148607662042.13885.2832003093930390561.idtracker@ietfa.amsl.com>
From: Nat Sakimura <sakimura@gmail.com>
Date: Mon, 06 Feb 2017 14:14:22 +0000
Message-ID: <CABzCy2AUXh5kW_+-0T4r2HWqyhrmQ5DLQ6-GPiXdwqzE5ZOHmA@mail.gmail.com>
To: Joel Halpern <jmh@joelhalpern.com>, gen-art@ietf.org
Content-Type: multipart/alternative; boundary="001a113c73f81b78bd0547dd4018"
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/vRYCMu1COK0Ip2mRJrrQG2g_wok>
Cc: ietf@ietf.org, draft-ietf-oauth-jwsreq.all@ietf.org, oauth@ietf.org
Subject: Re: [OAUTH-WG] Review of draft-ietf-oauth-jwsreq-11
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2017 14:14:36 -0000

Thanks Joel,

-11 only contains the fixes to the comments received by Jan. 17. I am now
applying all the edits needed for the comments received after that.
The next version will fix the problem you have pointed out.

Best,

Nat

On Fri, Feb 3, 2017 at 8:03 AM Joel Halpern <jmh@joelhalpern.com> wrote:

> Reviewer: Joel Halpern
> Review result: Not Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-oauth-jwsreq-??
> Reviewer: Joel Halpern
> Review Date: 2017-02-02
> IETF LC End Date: 2017-02-13
> IESG Telechat date: 2017-02-16
>
> Summary: This document is ready for publication as a Proposed
> Standard
>
> Major issues: N/A
>
> Minor issues:
>     Why is the example if section 4 (and others later on) described
> as
> "non-normative"?  Is it incomplete?  incorrect?  An example is, by
> definition, not a full specification.  The language seems designed to
> reduce the value of the example.  I would recommend removing all the
> "non-normative" notes from the examples.  They are clearly stated to
> be examples.
>
> Nits/editorial comments:
>
>
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth
>
-- 

Nat Sakimura

Chairman of the Board, OpenID Foundation

v2.23.0 | Report a Bug | By Email