Re: [OAUTH-WG] Fwd: New Version Notification for draft-ietf-oauth-par-02.txt

Neil Madden <neil.madden@forgerock.com> Thu, 23 July 2020 07:53 UTC

Return-Path: <neil.madden@forgerock.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E95C3A09E4 for <oauth@ietfa.amsl.com>; Thu, 23 Jul 2020 00:53:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=forgerock.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K9z71uhSKWKh for <oauth@ietfa.amsl.com>; Thu, 23 Jul 2020 00:53:54 -0700 (PDT)
Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 32A0E3A09E0 for <oauth@ietf.org>; Thu, 23 Jul 2020 00:53:53 -0700 (PDT)
Received: by mail-wm1-x32c.google.com with SMTP id x5so3514813wmi.2 for <oauth@ietf.org>; Thu, 23 Jul 2020 00:53:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=forgerock.com; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=9lF2rCENzYOmzs5zY5IGNESoWU6hmdSG6KKiW4v8zf0=; b=MD6KkveL6Z419pkCjxetL1k/9fIOhckDcZOJDLP/6BGfyJqWYbW/41ZYuw5YVN6Cc/ er4eC1S7dVVQUr0QAEHvqybAlE9MYuy6L4GEpk/z37xIuMomPEa7iP3UJdJ+pM/KNv+9 rIXP0K/S5y1JApsPbmf0p/woU+b+WhP095z4c=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=9lF2rCENzYOmzs5zY5IGNESoWU6hmdSG6KKiW4v8zf0=; b=KsGN9nx+cIeOHQKKEpChfbX/DTqovzznvcDiJYwUl1SE/kM3yzx8ZAQ8dNDZTG7Tcu PkhmWVFZwSofdjBfp19hj31WVvggsNoIcxSZl4t+BAwIBgGlBpi3n1bGIYuHL/5JxBg/ HP4/xDEpcwwlJs788lJmxvHvuPqUhQUKSE9J/K5WSqhtFf/iORD9m0InDEH7zVBiI9EV 3HAFjLqF5nXdiuhIMApdoFVPTLfJPwo68OPEtKAiaedq8G3h/y4jnfnMDplgx3xM6NS9 97x5YhQjsHBzrIANBWZQjAuiNdF+00yt9LlTJDUk4njZANpuilARoJ+GhoVflmUB2y8X 4XRg==
X-Gm-Message-State: AOAM530NVfoROZTLzP0xJyhtJ+Ac83PJ5ilGyYp7/1qoSUTlxwSxl8i5 0ol6PmTMNoSNaRn8FcghoQRVGgEbHjDGuA==
X-Google-Smtp-Source: ABdhPJzc60BQVJRTrs6GxKqp+4ni3+sqtn9GV+lLcn32B3bs7+vraLTApUIo5ZMEqX17WhiJTe5Mjg==
X-Received: by 2002:a7b:c841:: with SMTP id c1mr3187222wml.25.1595490832075; Thu, 23 Jul 2020 00:53:52 -0700 (PDT)
Received: from [10.0.0.3] (38.227.143.150.dyn.plus.net. [150.143.227.38]) by smtp.gmail.com with ESMTPSA id s19sm2889105wrb.54.2020.07.23.00.53.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2020 00:53:51 -0700 (PDT)
Content-Type: multipart/alternative; boundary=Apple-Mail-823CB155-155F-4208-B152-054C3A044A97
Content-Transfer-Encoding: 7bit
From: Neil Madden <neil.madden@forgerock.com>
Mime-Version: 1.0 (1.0)
Date: Thu, 23 Jul 2020 08:53:50 +0100
Message-Id: <2ABDD1A0-0455-4CD7-94B9-121F7D61A287@forgerock.com>
References: <CA+k3eCRWSFGHPb9Yo1POR_YqZLELyhEuYuUsObcXMebxtnySBg@mail.gmail.com>
Cc: Vladimir Dzhuvinov <vladimir@connect2id.com>, oauth <oauth@ietf.org>
In-Reply-To: <CA+k3eCRWSFGHPb9Yo1POR_YqZLELyhEuYuUsObcXMebxtnySBg@mail.gmail.com>
To: Brian Campbell <bcampbell=40pingidentity.com@dmarc.ietf.org>
X-Mailer: iPhone Mail (17F80)
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/xR4hpMCNAMQPqOw8vsDgaDngoAc>
Subject: Re: [OAUTH-WG] Fwd: New Version Notification for draft-ietf-oauth-par-02.txt
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2020 07:53:57 -0000

Can you expand on the risks of replay? It seems like if the request can be replayed an attacker can also block the original request and inject the URI into a different request - ie no replay. 

(Shouldn’t state and/or PKCE and/or nonce prevent replay already?)

In general the draft could do with some discussion of why an attacker being able to modify an authorization request is a risk. I might just be lacking enough coffee this morning to understand the risk here. 

— Neil

> On 22 Jul 2020, at 23:14, Brian Campbell <bcampbell=40pingidentity.com@dmarc.ietf.org> wrote:
> 
> 
> Thanks Vladimir, both comments should be easy to address in -03 (HTTPS/TLS required and SHOULD on short lifetime *and* single use). 
> 
>> On Sun, Jul 19, 2020 at 12:55 PM Vladimir Dzhuvinov <vladimir@connect2id.com> wrote:
>> Thanks for the update. With the "require PAR" AS and client metadata the spec is now "policy complete". I can't think of what else there is to add.
>> 
>> 
>> 
>> I have two comments about -02:
>> 
>> 
>> 
>> https://tools.ietf.org/html/draft-ietf-oauth-par-02#section-2
>> 
>> I didn't see a mention of https / TLS being required for the PAR endpoint. The reader could assume http is fine.
>> 
>> 
>> 
>> https://tools.ietf.org/html/draft-ietf-oauth-par-02#section-2.2
>> 
>>>    Since the request URI can be replayed, its lifetime SHOULD be short
>>>    and preferably limited to one-time use.
>> The SHOULD is ambiguous here - does it apply to the lifetime only, or to the lifetime and the single use.
>> 
>> 
>> Vladimir
>> 
>> 
>> 
>> On 10/07/2020 21:36, Brian Campbell wrote:
>>> WG,
>>> 
>>> A new -02 draft of "OAuth 2.0 Pushed Authorization Requests" has been published. A summary of the changes, taken from the document history, is included below for ease of reference.  
>>> 
>>>    -02
>>> 
>>>    *  Update Resource Indicators reference to the somewhat recently
>>>       published RFC 8707
>>> 
>>>    *  Added metadata in support of pushed authorization requests only
>>>       feature
>>> 
>>>    *  Update to comply with draft-ietf-oauth-jwsreq-21, which requires
>>>       "client_id" in the authorization request in addition to the
>>>       "request_uri"
>>> 
>>>    *  Clarified timing of request validation
>>> 
>>>    *  Add some guidance/options on the request URI structure
>>> 
>>>    *  Add the key used in the request object example so that a reader
>>>       could validate or recreate the request object signature
>>> 
>>>    *  Update to draft-ietf-oauth-jwsreq-25 and added note regarding
>>>       "require_signed_request_object"
>>> 
>>> ---------- Forwarded message ---------
>>> From: <internet-drafts@ietf.org>
>>> Date: Fri, Jul 10, 2020 at 1:21 PM
>>> Subject: New Version Notification for draft-ietf-oauth-par-02.txt
>>> To: Filip Skokan <panva.ip@gmail.com>om>, Torsten Lodderstedt <torsten@lodderstedt.net>et>, Brian Campbell <bcampbell@pingidentity.com>om>, Dave Tonge <dave@tonge.org>rg>, Nat Sakimura <nat@sakimura.org>
>>> 
>>> 
>>> 
>>> A new version of I-D, draft-ietf-oauth-par-02.txt
>>> has been successfully submitted by Brian Campbell and posted to the
>>> IETF repository.
>>> 
>>> Name:           draft-ietf-oauth-par
>>> Revision:       02
>>> Title:          OAuth 2.0 Pushed Authorization Requests
>>> Document date:  2020-07-10
>>> Group:          oauth
>>> Pages:          18
>>> URL:            https://www.ietf.org/internet-drafts/draft-ietf-oauth-par-02.txt
>>> Status:         https://datatracker.ietf.org/doc/draft-ietf-oauth-par/
>>> Htmlized:       https://tools..ietf.org/html/draft-ietf-oauth-par-02
>>> Htmlized:       https://datatracker.ietf.org/doc/html/draft-ietf-oauth-par
>>> Diff:           https://www.ietf.org/rfcdiff?url2=draft-ietf-oauth-par-02
>>> 
>>> Abstract:
>>>    This document defines the pushed authorization request endpoint,
>>>    which allows clients to push the payload of an OAuth 2.0
>>>    authorization request to the authorization server via a direct
>>>    request and provides them with a request URI that is used as
>>>    reference to the data in a subsequent authorization request.
>>> 
>>> 
>>> 
>>> 
>>> Please note that it may take a couple of minutes from the time of submission
>>> until the htmlized version and diff are available at tools.ietf.org.
>>> 
>>> The IETF Secretariat
>>> 
>>> 
>>> 
>>> CONFIDENTIALITY NOTICE: This email may contain confidential and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited..  If you have received this communication in error, please notify the sender immediately by e-mail and delete the message and any file attachments from your computer. Thank you. 
>>> 
>>> _______________________________________________
>>> OAuth mailing list
>>> OAuth@ietf.org
>>> https://www.ietf.org/mailman/listinfo/oauth
>> -- 
>> Vladimir Dzhuvinov
>> _______________________________________________
>> OAuth mailing list
>> OAuth@ietf.org
>> https://www.ietf.org/mailman/listinfo/oauth
> 
> CONFIDENTIALITY NOTICE: This email may contain confidential and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited..  If you have received this communication in error, please notify the sender immediately by e-mail and delete the message and any file attachments from your computer. Thank you._______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth