Re: [ogpx] type-system : example in section 4.3.1 is wrong

Joshua Bell <josh@lindenlab.com> Mon, 29 March 2010 21:04 UTC

Return-Path: <josh@lindenlab.com>
X-Original-To: ogpx@core3.amsl.com
Delivered-To: ogpx@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id ABA563A6985 for <ogpx@core3.amsl.com>; Mon, 29 Mar 2010 14:04:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.188
X-Spam-Level: *
X-Spam-Status: No, score=1.188 tagged_above=-999 required=5 tests=[AWL=0.175, BAYES_20=-0.74, DNS_FROM_OPENWHOIS=1.13, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SSZmR2w-iouw for <ogpx@core3.amsl.com>; Mon, 29 Mar 2010 14:04:54 -0700 (PDT)
Received: from mail-wy0-f172.google.com (mail-wy0-f172.google.com [74.125.82.172]) by core3.amsl.com (Postfix) with ESMTP id DB5CF3A65A6 for <ogpx@ietf.org>; Mon, 29 Mar 2010 14:04:53 -0700 (PDT)
Received: by wyb29 with SMTP id 29so5248254wyb.31 for <ogpx@ietf.org>; Mon, 29 Mar 2010 14:05:21 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.91.8 with HTTP; Mon, 29 Mar 2010 14:05:21 -0700 (PDT)
In-Reply-To: <b325928b1003281034w5c6e374ek57653c023d291fe6@mail.gmail.com>
References: <b325928b1003281034w5c6e374ek57653c023d291fe6@mail.gmail.com>
Date: Mon, 29 Mar 2010 14:05:21 -0700
Received: by 10.216.161.196 with SMTP id w46mr2190932wek.105.1269896721559; Mon, 29 Mar 2010 14:05:21 -0700 (PDT)
Message-ID: <f72742de1003291405g29f63f2ena09e89f977e87405@mail.gmail.com>
From: Joshua Bell <josh@lindenlab.com>
To: ogpx <ogpx@ietf.org>
Content-Type: multipart/alternative; boundary="0016363ba6e4fd74410482f6dec1"
Subject: Re: [ogpx] type-system : example in section 4.3.1 is wrong
X-BeenThere: ogpx@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Virtual World Region Agent Protocol - IETF working group <ogpx.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/ogpx>, <mailto:ogpx-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ogpx>
List-Post: <mailto:ogpx@ietf.org>
List-Help: <mailto:ogpx-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ogpx>, <mailto:ogpx-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Mar 2010 21:04:55 -0000

Trying this out, I note several errors:

On Sun, Mar 28, 2010 at 10:34 AM, Meadhbh Hamrick <ohmeadhbh@gmail.com>wrote:

> the example in section 4.3.1 is wrong. it does not include closing
> tags for the array or map.
>
> if we wanted to eliminate closing tags, then it would be correct. but
> if we decide we want to keep them, then we should fix the example.
> here's my recommendation. please double check it. -thx
>
>    Offset   Hex Data                  Char Data
>   -------- ------------------------- -----------
>   00000000  5B                       '['
>   00000001  00 00 00 03              '....'
>   00000005  69                       'i'
>   00000006  00 00 00 2A              '...*'
>   0000000A  75                       'u'
>   0000000B  6B AD 25 8E 06 F0 4A 87  'k.%...J.'
>   00000013  A6 59 49 31 17 C9 C1 62  '.YI1...b'
>   0000001B  7B                       '{'
>   0000001C  00 00 00 04              '....'
>   00000020  6B                       'k'
>   00000021  00 00 00 03              '....'
>   00000025  68 6F 74                 'hot'
>   00000028  73                       's'
>   00000029  00 00 00 04              '....'
>   0000002D  63 6F 6C 64              'cold'
>   00000031  6B                       'k'
>   00000032  00 00 00 13              '....'
>

^^ key length for 'higgs_boson_test_mass' should be 0x15 not 0x13


>   00000036  68 69 67 67 73 5F 62 6F  'higgs_bo'
>   0000003E  73 6F 6E 5F 72 65 73 74  'son_rest'
>   00000046  5f 6d 61 73 73           '_mass'
>   0000004B  21                       '!'
>   0000004C  68                       'k'
>

^^ This should be 0x6B (ASCII 'k') not 0x68


>   0000004D  00 00 00 09              '....'
>   00000051  69 6E 66 6F 5F 70 61 67  'info_pag'
>   00000059  65                       'e'
>   0000005A  6C                       'l'
>   0000005B  00 00 00 3A              '...:'
>   0000005F  68 74 74 70 73 3A 2f 2F  'https://'
>   00000067  65 78 61 6D 70 6C 65 2E  'example.'
>   0000006F  6F 72 67 2F 72 2F 36 62  'org/r/6b'
>   00000077  61 64 32 35 38 65 2D 30  'ad258e-0'
>   0000007F  36 66 30 2D 34 61 38 37  '6f0-4a87'
>   00000087  2D 61 36 35 39 2D 34 39  '-a659-49'
>   0000008F  33 31 31 37 63 39 63 31  '3117c9c1'
>   00000097  36 32                    '62'
>   00000099  68                       'k'
>

^^ This should be 0x6B (ASCII 'k') not 0x68


>   0000009A  00 00 00 14              '....'
>   0000009E  73 74 61 74 75 73 5F 72  'status_r'
>   000000A7  65 70 6F 72 74 5F 64 75  'eport_du'
>   000000AF  65 5F 62 79              'e_by'
>


>   000000B3  00 00 00 08              '....'
>

^^ These four octets appear erroneous. (Residue from trying to indicate the
length of the subsequent Date? But they preceded the 'd' and dates are fixed
length...)


>   000000B7  64                       'd'
>   000000B8  41 D2 3C E6 AC 00 00 00  'A.<.....'
>   000000C0  7D                       '}'
>   000000C0  5D                       ']'
>
> -cheers
> -meadhbh
> --
> meadhbh hamrick * it's pronounced "maeve"
> @OhMeadhbh * http://meadhbh.org/ * OhMeadhbh@gmail.com
> _______________________________________________
> ogpx mailing list (VWRAP working group)
> ogpx@ietf.org
> https://www.ietf.org/mailman/listinfo/ogpx
>