Re: [Ohai] Working Group Last Call for draft-ietf-ohai-ohttp

Tim Wicinski <tjw.ietf@gmail.com> Wed, 17 August 2022 16:39 UTC

Return-Path: <tjw.ietf@gmail.com>
X-Original-To: ohai@ietfa.amsl.com
Delivered-To: ohai@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A2554C1524A4 for <ohai@ietfa.amsl.com>; Wed, 17 Aug 2022 09:39:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.105
X-Spam-Level:
X-Spam-Status: No, score=-7.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7RcjvPF7HjWO for <ohai@ietfa.amsl.com>; Wed, 17 Aug 2022 09:39:48 -0700 (PDT)
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 50CECC1522BE for <ohai@ietf.org>; Wed, 17 Aug 2022 09:39:48 -0700 (PDT)
Received: by mail-lj1-x22a.google.com with SMTP id by6so14063081ljb.11 for <ohai@ietf.org>; Wed, 17 Aug 2022 09:39:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=SZpAIjJAIl/3kqeRnsQtppfAcTPTfKafcQJ0p6D7/nk=; b=Byk9wo+Kbr/Q3aBR8vfWJPnEDPhlyU4979Gn7VhAyarwoxoP7O6gISmhLlqkzKjTlL 1o0Oy95hDC/7HxwugExTUJuJ3izgSpLjdsD2R/uYqsqCqptCDjWlFrhicpTbPHiCYadE LnKduyK8xVwwzznb2WYozjI1pJ5zuMXMD+kIZ4XfYBTaO8FsQQ5NWUn3ZtSWp4BTs5w0 4H4okQB08tZ3AfDTRC+IyKnwLp00KLMrHEnblTIlcJ6Vbz2jyMCo7eddt8TKPq53dnob GPkCrys2V66+Hq1BK5Ur4hjgeiq3+B1qoHyfngA5/sHkeV5caVm9TxxwNVuPsp+mjU25 qk8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=SZpAIjJAIl/3kqeRnsQtppfAcTPTfKafcQJ0p6D7/nk=; b=qPS9kzkcPbKseQQIEKKpHicEKCOvl68sKbsA+AHBVyEaNN5xrTOQ91xIiQ2TKmvzvC ou1H1bqwXPQmpMrliN5MnIfmsqxoqAFj+FhVh8qOdfaue7yICo/iVqKStNh2mMKZWmTQ C00Um8Rtb5h5sRO4Bjga/hgW9LwUU/8kuO/Xu8eZgUf5cepIw8hiZtJMNJxeVCBvTF7E V5c9l15H8JS7Xspi2l357ZwFYcHXL38LozGE/93BiWJjwMT2l2cUT92X8P2ndC9N3y8u aWuAu3z153EFtr/dT0c1LiD73cdBM/9uCyOKz/+UrMFvDXexH993xrvLFuYz5B0IoAjy 3OjA==
X-Gm-Message-State: ACgBeo37fLfnePvZ0T62T7lkI9+7z3FVjxcA/nwuvrFTaJaTwpt/HnSG pOBgF/+XGJSoKqhRb0bGqQJ2XifKBVkPRX2X+ps=
X-Google-Smtp-Source: AA6agR6jnePeigJiBRVvde87T3BxQdIAEvHwxa2niIayl/hj8TF8dqMiRvjjO5z+9yRneiliDxa6WJczLQDyr92F97A=
X-Received: by 2002:a2e:a7d3:0:b0:25e:7a20:e255 with SMTP id x19-20020a2ea7d3000000b0025e7a20e255mr7722165ljp.426.1660754386235; Wed, 17 Aug 2022 09:39:46 -0700 (PDT)
MIME-Version: 1.0
References: <CAG3f7Mi3MmZeECSyMewaQLSNtjpfqctkbTUvxbnM+voemwfzdg@mail.gmail.com> <F79C27F3-5FD7-4E22-AEBE-BA0C2FF1676C@apple.com> <CAMOjQcGv5rqxA+iowBQL51DyQTd7eRiD9rYiJMdMmbbqxv_ANw@mail.gmail.com>
In-Reply-To: <CAMOjQcGv5rqxA+iowBQL51DyQTd7eRiD9rYiJMdMmbbqxv_ANw@mail.gmail.com>
From: Tim Wicinski <tjw.ietf@gmail.com>
Date: Wed, 17 Aug 2022 12:39:34 -0400
Message-ID: <CADyWQ+EQFfHoG8m8err5L5LFehWpxn4Dzi9M-VXb04HyMjti0w@mail.gmail.com>
To: Eric Orth <ericorth=40google.com@dmarc.ietf.org>
Cc: Shivan Kaul Sahib <shivankaulsahib@gmail.com>, ohai@ietf.org, David Benjamin <davidben@google.com>
Content-Type: multipart/alternative; boundary="0000000000004036eb05e67283e7"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ohai/VmClJPNwFrMI3kXh1RJyhhPc_D8>
Subject: Re: [Ohai] Working Group Last Call for draft-ietf-ohai-ohttp
X-BeenThere: ohai@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Oblivious HTTP Application Intermediation <ohai.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ohai>, <mailto:ohai-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ohai/>
List-Post: <mailto:ohai@ietf.org>
List-Help: <mailto:ohai-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ohai>, <mailto:ohai-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Aug 2022 16:39:52 -0000

I read this finally (I know late, but what else is new), and there are some
Nits that need checking out (Lucas caught most of them I think).
Whomever shepherds this will follow up on those.

Thinking about the IESG process, you may want to quote things like "
KeyConfig.key.id" to make them more obvious. Having run through several
reviews as
shepherd for DNS docs things like this stick in my mind.

tim

On Tue, Aug 16, 2022 at 2:33 PM Eric Orth <ericorth=
40google.com@dmarc.ietf.org> wrote:

> Took a review pass of the latest draft 03.  Opened one minor editorial
> issue in the github.  I also found my eyes glazing over when trying to read
> through and understand the section on HPKE encapsulation, but assuming
> davidben@google.com has reviewed that text, I trust his judgement on such
> stuff.
>
> Overall, I support this moving forward.
>
> On Tue, Aug 16, 2022 at 12:40 PM Tommy Pauly <tpauly=
> 40apple.com@dmarc.ietf.org> wrote:
>
>> I’ve done a review pass of the document, based on the current editor’s
>> copy in GitHub. I think it’s in good shape and should be published.
>>
>> I did file a PR for minor comments, mainly editorial:
>>
>> https://github.com/ietf-wg-ohai/oblivious-http/pull/183
>>
>> The interesting bits here are:
>> - The suggested info string for other media types needs to be updated to
>> include the header values
>> - I think several places in the document would benefit from referring to
>> the “repurposing” support, so that readers are aware of the places they
>> should make generic for different media types if they intend to support
>> them. It’s useful when implementing the API surface.
>>
>> Thanks,
>> Tommy
>>
>> On Aug 8, 2022, at 2:57 PM, Shivan Kaul Sahib <shivankaulsahib@gmail.com>
>> wrote:
>>
>> ohai folks,
>>
>> This email starts a Working Group Last Call for draft-ietf-ohai-ohttp, "Oblivious
>> HTTP".
>>
>> The draft is available at
>> https://datatracker.ietf.org/doc/draft-ietf-ohai-ohttp/, with the source
>> at https://github.com/ietf-wg-ohai/oblivious-http.
>>
>> The WGLC will last for a period of 3 weeks until August 22, 2022, 23:59
>> AoE <https://en.wikipedia.org/wiki/Anywhere_on_Earth>.
>>
>> Please review and submit issues and pull requests and comments and
>> objections and support to GitHub and/or this mailing list.
>>
>> Thanks!
>> Shivan & Richard, OHAI chairs
>>
>>
>>
>> --
>> Ohai mailing list
>> Ohai@ietf.org
>> https://www.ietf.org/mailman/listinfo/ohai
>>
>>
>> --
>> Ohai mailing list
>> Ohai@ietf.org
>> https://www.ietf.org/mailman/listinfo/ohai
>>
> --
> Ohai mailing list
> Ohai@ietf.org
> https://www.ietf.org/mailman/listinfo/ohai
>