Re: [openpgp] I-D Action: draft-ietf-openpgp-crypto-refresh-02.txt (fwd)

Paul Wouters <paul@nohats.ca> Thu, 29 April 2021 04:23 UTC

Return-Path: <paul@nohats.ca>
X-Original-To: openpgp@ietfa.amsl.com
Delivered-To: openpgp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7409D3A2E72 for <openpgp@ietfa.amsl.com>; Wed, 28 Apr 2021 21:23:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nohats.ca
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HDtcEtQ6GWbu for <openpgp@ietfa.amsl.com>; Wed, 28 Apr 2021 21:23:44 -0700 (PDT)
Received: from mx.nohats.ca (mx.nohats.ca [193.110.157.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 08D083A2E71 for <openpgp@ietf.org>; Wed, 28 Apr 2021 21:23:43 -0700 (PDT)
Received: from localhost (localhost [IPv6:::1]) by mx.nohats.ca (Postfix) with ESMTP id 4FW2SG5CSBz3Tr; Thu, 29 Apr 2021 06:23:42 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nohats.ca; s=default; t=1619670222; bh=5cUqt4eQ7bxDbI/qlPDiwOy7WoZJDejov8W9VsGgb/s=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=eRup0qlbdR5y+79rX4WdG7K4yqy4Sxj7Bm1YLu7KMkEc3BS5pfE9To04NYoAhCU9S c65ZhnLb6dWsadbp5MwsFFXzl9gUM3md+bnbVW+ZT1Izn4bQr7q8wIgjh6rQr4dHlZ 1caQ/IDe1trFVNCOgFv8OhBtjJr+0U/B8yeWgQ7A=
X-Virus-Scanned: amavisd-new at mx.nohats.ca
Received: from mx.nohats.ca ([IPv6:::1]) by localhost (mx.nohats.ca [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id XjCzDRq3shQ0; Thu, 29 Apr 2021 06:23:41 +0200 (CEST)
Received: from bofh.nohats.ca (bofh.nohats.ca [193.110.157.194]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.nohats.ca (Postfix) with ESMTPS; Thu, 29 Apr 2021 06:23:41 +0200 (CEST)
Received: by bofh.nohats.ca (Postfix, from userid 1000) id 73FE46029A70; Thu, 29 Apr 2021 00:23:40 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1]) by bofh.nohats.ca (Postfix) with ESMTP id 6B46666B7C; Thu, 29 Apr 2021 00:23:40 -0400 (EDT)
Date: Thu, 29 Apr 2021 00:23:40 -0400 (EDT)
From: Paul Wouters <paul@nohats.ca>
To: "Neal H. Walfield" <neal@walfield.org>
cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, openpgp@ietf.org
In-Reply-To: <877dmraytj.wl-neal@walfield.org>
Message-ID: <36edd7dd-8217-fc9a-88f-90cd47c5695@nohats.ca>
References: <7d8bdda1-4e5c-6c10-f3cd-1d191fad595c@nohats.ca> <87im6faw06.wl-neal@walfield.org> <87pn0mcecf.fsf@fifthhorseman.net> <877dmraytj.wl-neal@walfield.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Archived-At: <https://mailarchive.ietf.org/arch/msg/openpgp/OPdzLObouPQyDzRbARB-idrQOdA>
Subject: Re: [openpgp] I-D Action: draft-ietf-openpgp-crypto-refresh-02.txt (fwd)
X-BeenThere: openpgp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Ongoing discussion of OpenPGP issues." <openpgp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/openpgp>, <mailto:openpgp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/openpgp/>
List-Post: <mailto:openpgp@ietf.org>
List-Help: <mailto:openpgp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/openpgp>, <mailto:openpgp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2021 04:23:48 -0000

On Mon, 1 Mar 2021, Neal H. Walfield wrote:

>> On Fri 2021-02-26 12:50:17 +0100, Neal H. Walfield wrote:
>>> -- 20 octets representing a recipient encryption subkey or a master key fingerprint, identifying the key material that is needed for the decryption.
>>> -  For version 5 keys the 20 leftmost octets of the fingerprint are used.
>>> +- [ ] 20 octets representing a recipient encryption subkey or a primary key fingerprint identifying the key material that is needed for decryption
>>> +  (for version 5 keys the 20 leftmost octets of the fingerprint are used).
>
> I don't know how that crept it.
>
>> what does the [ ] you've inserted here mean?  It looks like a markdown
>> todo-list "checkbox", maybe it was inserted by mistake?

It is not in the markdown original, so I'm not sure how/why it is
happening.

>>> -    09 k0 k1 ... k31 c0 c1 05 05 05 05 05
>>> +    09 k0 k1 ... k31 C0 C1 05 05 05 05 05
>>>
>>> -The octets c0 and c1 above denote the checksum.
>>> +The octets C0 and C1 above denote the checksum.
>>
>> This seems like a mistake.  C0 and C1 could be specific hexadecimal
>> octets (decimal 12), whereas "c0" and "c1" here are intended to be
>> placeholders for the checksum.  This is a bit confusing, maybe it would
>> be better to use s0 and s1 (s for "sum") so that it's clear that it
>> isn't hex?
>
> Good points!  I think using s0 and s1 is the best suggestion so far.

Done via commit 27e70ca.

Paul