Re: [openpgp] I-D Action: draft-ietf-openpgp-crypto-refresh-02.txt (fwd)

Daniel Kahn Gillmor <dkg@fifthhorseman.net> Sat, 27 February 2021 17:46 UTC

Return-Path: <dkg@fifthhorseman.net>
X-Original-To: openpgp@ietfa.amsl.com
Delivered-To: openpgp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D96E3A1041 for <openpgp@ietfa.amsl.com>; Sat, 27 Feb 2021 09:46:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=neutral reason="invalid (unsupported algorithm ed25519-sha256)" header.d=fifthhorseman.net header.b=qB3E3Mej; dkim=pass (2048-bit key) header.d=fifthhorseman.net header.b=dzJ4YCK3
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7eapQf5bhncC for <openpgp@ietfa.amsl.com>; Sat, 27 Feb 2021 09:46:57 -0800 (PST)
Received: from che.mayfirst.org (che.mayfirst.org [IPv6:2001:470:1:116::7]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ABB163A1048 for <openpgp@ietf.org>; Sat, 27 Feb 2021 09:46:57 -0800 (PST)
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1614448016; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=KTCiz6hDKb1P5r7lY6v7HjShGxem+xv6+nOrilkuJJM=; b=qB3E3MejbxKwaW1JW2PSgCdkAvdJPtQkEoHJHHBMIvX5wFIF8uERmlKDGM2R81oJdILT2 RGfRUL0TsHTxc5SAg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1614448016; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=KTCiz6hDKb1P5r7lY6v7HjShGxem+xv6+nOrilkuJJM=; b=dzJ4YCK3emien4lv2ny5S7hXNvU2jM4uU8uplHYqr73LTTq5QmOnogudlZ+Vqi4AfJYtT DFoi9w3TUS3GVGepXCbbpnkAvYLlOCUMjeLW8qqlzoQ1I2hYwaWZ7Lwj2v3V09FPWo8V2fz NF2YeLOFiJMW4FnARWoiXoWYBTU5YQ/Zwvr7P8GxqskYmi62wgvidgj6P5zKcWY/K/mBR9c ArM7SQBy+e6cnavKf25VOlviajbFLlg9TwxKw4XpR7bL1xghYr2Yild7FzgoCWmbSFSU7zD /NiSeIreWguYnT0cVWnfKRp91WUqbUvfQVEutiGegb+P9fmOL1NkJMCBhQig==
Received: from fifthhorseman.net (lair.fifthhorseman.net [108.58.6.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 41DB3F9A8; Sat, 27 Feb 2021 12:46:55 -0500 (EST)
Received: by fifthhorseman.net (Postfix, from userid 1000) id 253A9204C1; Fri, 26 Feb 2021 23:41:05 -0500 (EST)
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: "Neal H. Walfield" <neal@walfield.org>, Paul Wouters <paul@nohats.ca>
Cc: openpgp@ietf.org
In-Reply-To: <87im6faw06.wl-neal@walfield.org>
References: <7d8bdda1-4e5c-6c10-f3cd-1d191fad595c@nohats.ca> <87im6faw06.wl-neal@walfield.org>
Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH
Date: Fri, 26 Feb 2021 23:41:04 -0500
Message-ID: <87pn0mcecf.fsf@fifthhorseman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/openpgp/XzmQ4fsC_BTHBd1EkyeERaC1udw>
Subject: Re: [openpgp] I-D Action: draft-ietf-openpgp-crypto-refresh-02.txt (fwd)
X-BeenThere: openpgp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Ongoing discussion of OpenPGP issues." <openpgp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/openpgp>, <mailto:openpgp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/openpgp/>
List-Post: <mailto:openpgp@ietf.org>
List-Help: <mailto:openpgp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/openpgp>, <mailto:openpgp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Feb 2021 17:46:59 -0000

Hi Neal--

Thanks for the nit-picks.  Two concerns:

On Fri 2021-02-26 12:50:17 +0100, Neal H. Walfield wrote:
> -- 20 octets representing a recipient encryption subkey or a master key fingerprint, identifying the key material that is needed for the decryption.
> -  For version 5 keys the 20 leftmost octets of the fingerprint are used.
> +- [ ] 20 octets representing a recipient encryption subkey or a primary key fingerprint identifying the key material that is needed for decryption
> +  (for version 5 keys the 20 leftmost octets of the fingerprint are used).

what does the [ ] you've inserted here mean?  It looks like a markdown
todo-list "checkbox", maybe it was inserted by mistake?

> -    09 k0 k1 ... k31 c0 c1 05 05 05 05 05
> +    09 k0 k1 ... k31 C0 C1 05 05 05 05 05
>  
> -The octets c0 and c1 above denote the checksum.
> +The octets C0 and C1 above denote the checksum.

This seems like a mistake.  C0 and C1 could be specific hexadecimal
octets (decimal 12), whereas "c0" and "c1" here are intended to be
placeholders for the checksum.  This is a bit confusing, maybe it would
be better to use s0 and s1 (s for "sum") so that it's clear that it
isn't hex?

At any rate, i think this was the only "capital hex" part of the diff,
so we probably don't need that mention in the commit message either,
right?

I've included this proposal (without the two changes above that i think
are mistaken) and your other remark about the big-endianness of the
two-octet scalar in a merge request:

   https://gitlab.com/openpgp-wg/rfc4880bis/-/merge_requests/38

I encourage people to make merge requests directly in gitlab in addition
to posting patches to the mailing list, especially for
non-substantive/editorial changes like this.

        --dkg