IETF Logo Mail Archive

Re: [openpgp] [RFC4880bis PATCH] Clarify CRC-24 C example implementation

Ángel <angel@16bits.net> Thu, 18 March 2021 01:33 UTC

Return-Path: <angel@16bits.net>
X-Original-To: openpgp@ietfa.amsl.com
Delivered-To: openpgp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C10A3A1A26 for <openpgp@ietfa.amsl.com>; Wed, 17 Mar 2021 18:33:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 34bteEEZwWXg for <openpgp@ietfa.amsl.com>; Wed, 17 Mar 2021 18:33:56 -0700 (PDT)
Received: from mail.direccionemail.com (mail.direccionemail.com [199.195.249.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C17003A1A24 for <openpgp@ietf.org>; Wed, 17 Mar 2021 18:33:56 -0700 (PDT)
Message-ID: <25e8d5713bcccb7b86e0f9ce75dafba80fb41530.camel@16bits.net>
From: Ángel <angel@16bits.net>
To: openpgp@ietf.org
Date: Thu, 18 Mar 2021 02:33:54 +0100
In-Reply-To: <871rcd7rdh.fsf@fifthhorseman.net>
References: <20210317145508.136021-1-dkg@fifthhorseman.net> <871rcd7rdh.fsf@fifthhorseman.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/openpgp/lgj10hSe_YyVOeJrEZtR7epMUXw>
Subject: Re: [openpgp] [RFC4880bis PATCH] Clarify CRC-24 C example implementation
X-BeenThere: openpgp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Ongoing discussion of OpenPGP issues." <openpgp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/openpgp>, <mailto:openpgp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/openpgp/>
List-Post: <mailto:openpgp@ietf.org>
List-Help: <mailto:openpgp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/openpgp>, <mailto:openpgp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Mar 2021 01:33:59 -0000

On 2021-03-17 at 11:05 -0400, Daniel Kahn Gillmor wrote:
> On Wed 2021-03-17 10:55:08 -0400, Daniel Kahn Gillmor wrote:
> > The mismatch between the variable in the sample CRC-24 generation
> > code
> > and the definition of the generator in the paragraph above has been
> > a
> > source of confusion for over 20 years.
> 
> I recorded this proposed minor cleanup as MR 39:
> https://gitlab.com/openpgp-wg/rfc4880bis/-/merge_requests/39
> 
>         --dkg

What about using, instead of the 'long' type, which may mean quite
dfferent things, the uint_least32_t type defined in ISO C 7.18 ?

v2.23.0 | Report a Bug | By Email