Re: [openpgp] change salt size for v5 signatures?

Daniel Kahn Gillmor <dkg@fifthhorseman.net> Thu, 09 February 2023 17:12 UTC

Return-Path: <dkg@fifthhorseman.net>
X-Original-To: openpgp@ietfa.amsl.com
Delivered-To: openpgp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21102C18799D for <openpgp@ietfa.amsl.com>; Thu, 9 Feb 2023 09:12:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.303
X-Spam-Level:
X-Spam-Status: No, score=-1.303 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=neutral reason="invalid (unsupported algorithm ed25519-sha256)" header.d=fifthhorseman.net header.b="39Aj+Z+Y"; dkim=pass (2048-bit key) header.d=fifthhorseman.net header.b="Ezj1DFL1"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id thxMvwkpKns9 for <openpgp@ietfa.amsl.com>; Thu, 9 Feb 2023 09:12:02 -0800 (PST)
Received: from che.mayfirst.org (unknown [162.247.75.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BF47CC22E911 for <openpgp@ietf.org>; Thu, 9 Feb 2023 09:11:32 -0800 (PST)
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1675962691; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=37H7RLQj7TxEUMYA/+8FFOBoAiIPeTCljT6ltlCHgpk=; b=39Aj+Z+Y2dsb3lZ/qMnKVWAsP21z1V3HNnOojHOI1tD2NxWagXvkH3R/V4YW5kvZK02xA v9yvFzDRLRYwna6Ag==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1675962691; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=37H7RLQj7TxEUMYA/+8FFOBoAiIPeTCljT6ltlCHgpk=; b=Ezj1DFL1/+1X/7qjt/5uw1HJJ+KqUjG29xceVj7K3gBQSrcyydcL5HhLwXRg5tm4/eRuo NAH5jqKcyX3U1paAk8sw29fzJTV9WemSysCuB2CUMp4H/vC0h3vnOGyMxR7aAYWaLF65B3V V/mLfgaFBhyRkBGkIP/EjwpFeUtlNNNXVOpbqTLB0nzWzDbwJUa9H4hNkimAAmLvOEZDROJ VozvkffYnWvlbmAZ+1iYULICLM0h+4U4kSWGhQXFZjYdBnjKUHcTHE1SLqT8OUZ+nIjMGaR Wf/ZEk89RbtDVLQ01/matXEF0lz0NV9Ae3LXLR3RNS5DMHnCLC5BULbEI6xg==
Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 332FAF9AF for <openpgp@ietf.org>; Thu, 9 Feb 2023 12:11:30 -0500 (EST)
Received: by fifthhorseman.net (Postfix, from userid 1000) id 22D4E20A7E; Thu, 9 Feb 2023 12:08:20 -0500 (EST)
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: openpgp@ietf.org
In-Reply-To: <871qn4ni9l.fsf@fifthhorseman.net>
References: <871qn4ni9l.fsf@fifthhorseman.net>
Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH
Date: Thu, 09 Feb 2023 12:08:19 -0500
Message-ID: <874jrulqbg.fsf@fifthhorseman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/openpgp/zi-d_nQPudKivReVsmaszI46Cis>
Subject: Re: [openpgp] change salt size for v5 signatures?
X-BeenThere: openpgp@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Ongoing discussion of OpenPGP issues." <openpgp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/openpgp>, <mailto:openpgp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/openpgp/>
List-Post: <mailto:openpgp@ietf.org>
List-Help: <mailto:openpgp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/openpgp>, <mailto:openpgp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Feb 2023 17:12:08 -0000

On Sun 2023-02-05 12:17:58 -0500, Daniel Kahn Gillmor wrote:
> v5 signatures are currently 16 octets.  Should we update this to be able
> to accomodate some future schemes that probably warrant more than 16
> octets of salt?  (see
> https://gitlab.com/openpgp-wg/rfc4880bis/-/issues/150)
>
> Some interesting subquestions:
>
> - Should this be a uniform increase to 32 octets?  or should it be bound
>   to the hash function used?
>
> - If variable-sized, should the size of the salt be indicated on the
>   wire in the Signature packet?
>
> An MR that answers "bound to the hash function used" and "indicated on
> the wire" to the above questions:
> https://gitlab.com/openpgp-wg/rfc4880bis/-/merge_requests/219

We discussed this in the interim session today.  The consensus of the
active participants was that we should make this change.  In particular:

 - to bind the salt size to the hash algorithm used for the signature,
   adding a column to the table of hash algorithms

 - to indicate the size of the salt on the wire, which permits parsing
   signature packets even when the hash algorithm is unknown

 - to reject v6 signatures when their salt size does not match the
   expected salt size for their hash algorithm

 - to indicate that the expected salt size for deprecated hash
   algorithms like MD5 and SHA1 should be "N/A"

Daniel Huigens offered to make an MR on top of !219 that adopts this
last change.

    --dkg