[OPSAWG] Quick review of draft-evenwu-opsawg-yang-composed-vpn-03

"Adrian Farrel" <adrian@olddog.co.uk> Fri, 09 August 2019 17:07 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B58E01200EC; Fri, 9 Aug 2019 10:07:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.598
X-Spam-Level:
X-Spam-Status: No, score=-2.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ug0B8UP1JHBr; Fri, 9 Aug 2019 10:07:37 -0700 (PDT)
Received: from mta5.iomartmail.com (mta5.iomartmail.com [62.128.193.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 98647120142; Fri, 9 Aug 2019 10:07:34 -0700 (PDT)
Received: from vs2.iomartmail.com (vs2.iomartmail.com [10.12.10.123]) by mta5.iomartmail.com (8.14.4/8.14.4) with ESMTP id x79H7WJV003058; Fri, 9 Aug 2019 18:07:32 +0100
Received: from vs2.iomartmail.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2D3E322048; Fri, 9 Aug 2019 18:07:32 +0100 (BST)
Received: from asmtp1.iomartmail.com (unknown [10.12.10.248]) by vs2.iomartmail.com (Postfix) with ESMTPS id 1885F22044; Fri, 9 Aug 2019 18:07:32 +0100 (BST)
Received: from LAPTOPK7AS653V (120.105.162.213.dyn.plus.net [213.162.105.120] (may be forged)) (authenticated bits=0) by asmtp1.iomartmail.com (8.14.4/8.14.4) with ESMTP id x79H7QXV025263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 9 Aug 2019 18:07:26 +0100
Reply-To: adrian@olddog.co.uk
From: Adrian Farrel <adrian@olddog.co.uk>
To: draft-evenwu-opsawg-yang-composed-vpn@ietf.org
Cc: opsawg@ietf.org
Date: Fri, 09 Aug 2019 18:07:26 +0100
Organization: Old Dog Consulting
Message-ID: <03f501d54ed4$eea60a70$cbf21f50$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AdVO1K3mublaoijBQ+u1qSSqz6WdnA==
Content-Language: en-gb
X-Originating-IP: 213.162.105.120
X-Thinkmail-Auth: adrian@olddog.co.uk
X-TM-AS-GCONF: 00
X-TM-AS-Product-Ver: IMSVA-9.0.0.1623-8.2.0.1013-24838.000
X-TM-AS-Result: No--14.448-10.0-31-10
X-imss-scan-details: No--14.448-10.0-31-10
X-TMASE-Version: IMSVA-9.0.0.1623-8.2.1013-24838.000
X-TMASE-Result: 10--14.447900-10.000000
X-TMASE-MatchedRID: Eaa9uy99bv9VkshSxEEhDXFPUrVDm6jtS/ceBQrgS1FwkdIrVt8X1Q7+ NAAXKQLHeX/L2MY3FxrZLAoIw72C6H9oXId4GW5yDDlsUbcsIPprLj3DxYBIN1AoBBK61BhcDpb rdhcd5/nWjIV9d6zWtnZUc9XearI8eoT8ghp9T79TNl9jB9u8gCWo4o4gXl+QVj3J63pAR3xkR9 HRH5IIWPoeFlakQzNkc7X8iaJ6GDGZfIEUmIhDjsEDv1eIMYWzV447DNvw38YjRiu1AuxJTFYIH eJwbhUqED80K02TGfdfL846nDpxb5+8D2AIxR4AN+75FOVyJeBaEfFgComdj2GVufr+eY4v4iqq D3wNGvqzU0DpC2iPh9ZOqJtWMtpaGHYsFHqGD8YZSUX8zcPGn3BGtZWEKpDp/t8WJLqus8G0LxC At471HufOVcxjDhcwlnP9MMAZcdpTptoDfp6JrMRB0bsfrpPIfiAqrjYtFiQWCw8rZAdpQ1+HTa Khip0WGWEhfmc1PwvaERpfZcyG5H7cGd19dSFd
X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/2yOAClUDgUGVGvyr13qbT2lmEMw>
Subject: [OPSAWG] Quick review of draft-evenwu-opsawg-yang-composed-vpn-03
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Aug 2019 17:07:40 -0000

Hey authors,

I reviewed -02 back in March and sent you a pile of comments mainly with suggested text changes.

You posted -03 shortly after, and I just checked - looks like you made all of the changes. Thanks.

While looking through the current version, I see a few bits and pieces that could be fixed.

I'm aware that we are polishing this draft to a level normally associated with a WG draft, so I hope we are going to advance this work (otherwise we're wasting our time 😉)

Best,
Adrian

===

idnits has a little to say. Some of it can be ignored, but...

>  == The document doesn't use any RFC 2119 keywords, yet has text resembling
>     RFC 2119 boilerplate text.

The fix is s/[RFC2119] and [RFC8174]/[RFC2119] [RFC8174]/

> ** There are 80 instances of too long lines in the document, the longest
>      one being 35 characters in excess of 72.

Figure 3 just needs a very small edit

Some of this is in the YANG and can be easily fixed by manual folding of text strings.
There is also some folding that looks safe.

In section 8, the folding might need draft-ietf-netmod-artwork-folding.

The figure in section 8 can also stand some simple edits.

It's just the tree in section 5 that is going to be hard work.

---

A question about Figure 1. The text says that the composed VPN model can be an input to the process. Maybe show this as an extra arrow coming into the Network Orchestrator.

It would also be good to label the flows south of the network Orchestrator to match the text.

---

Section 3

s/added ,the/added, the/

---

5.2.2.2 has "combined VPN" and I think it should be "composed VPN"

---

Section 9 might just highlight the imports that are necessary.

---

OLD
Appendix A.  Acknowledges
NEW
Appendix A.  Acknowledgements
END

---