Re: [OPSAWG] Rtgdir early review of draft-ietf-opsawg-ipfix-bgp-community-06

"Dongjie (Jimmy)" <jie.dong@huawei.com> Mon, 16 April 2018 03:40 UTC

Return-Path: <jie.dong@huawei.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1BA3C1204DA; Sun, 15 Apr 2018 20:40:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fFRb4sZYm_FT; Sun, 15 Apr 2018 20:40:26 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A705A12D77C; Sun, 15 Apr 2018 20:40:15 -0700 (PDT)
Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 23118F0721C98; Mon, 16 Apr 2018 04:40:12 +0100 (IST)
Received: from NKGEML412-HUB.china.huawei.com (10.98.56.73) by LHREML714-CAH.china.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.382.0; Mon, 16 Apr 2018 04:40:13 +0100
Received: from NKGEML515-MBX.china.huawei.com ([fe80::a54a:89d2:c471:ff]) by nkgeml412-hub.china.huawei.com ([10.98.56.73]) with mapi id 14.03.0361.001; Mon, 16 Apr 2018 11:40:09 +0800
From: "Dongjie (Jimmy)" <jie.dong@huawei.com>
To: Joel Halpern <jmh@joelhalpern.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "draft-ietf-opsawg-ipfix-bgp-community.all@ietf.org" <draft-ietf-opsawg-ipfix-bgp-community.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Rtgdir early review of draft-ietf-opsawg-ipfix-bgp-community-06
Thread-Index: AQHT0zX1w/Ov8PWmpkGg5ezlfsT2sqQCrsUA
Date: Mon, 16 Apr 2018 03:40:09 +0000
Message-ID: <76CD132C3ADEF848BD84D028D243C927983DA81F@NKGEML515-MBX.china.huawei.com>
References: <152363066886.26321.3212300538180273898@ietfa.amsl.com>
In-Reply-To: <152363066886.26321.3212300538180273898@ietfa.amsl.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.130.151.75]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/3RmwlBkYE1f89KCEXGeDmvlP_5k>
Subject: Re: [OPSAWG] Rtgdir early review of draft-ietf-opsawg-ipfix-bgp-community-06
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2018 03:40:28 -0000

Hi Joel, 

Thanks a lot for your review comments. 

Regarding your first problem, I don't think this draft introduces "significant new processing load on the router", as similar processing has already been done for the BGP AS number and BGP-nexthop based traffic collection. As described in the draft, the BGP-community based traffic collection is done by BGP lookup and correlating the BGP community with the flow data to be exported. Whether it is done in data plane or control plane is implementation specific and IMO does not belong to a IETF document. 

As for your second problem, as many operators have pointed out, it is a common case to use BGP communities to represent geo locations at various granularities. So we need to provide them the tools to meet their requirements. Standardizing the IEs for BGP community is a good start.

Best regards,
Jie

> -----Original Message-----
> From: Joel Halpern [mailto:jmh@joelhalpern.com]
> Sent: Friday, April 13, 2018 10:44 PM
> To: rtg-dir@ietf.org
> Cc: draft-ietf-opsawg-ipfix-bgp-community.all@ietf.org; ietf@ietf.org;
> opsawg@ietf.org; gen-art@ietf.org
> Subject: Rtgdir early review of draft-ietf-opsawg-ipfix-bgp-community-06
> 
> Reviewer: Joel Halpern
> Review result: Not Ready
> 
> This is both a gen-art re-review and a routing directorate requested review.
> 
> The revisions from draft-04 to -06 show some improvement.  However, I still
> have serious problems with this work.
> 
> The primary problem is that this seems to violate the designed work
> distribution in the IPFIX architecture.  The draft itself notes that the
> correlation requested could be done in the collector.  Which is where
> correlation is designed to be done.  Instead, it puts a significant new
> processing load on the router that is delivering the IPFIX information.  For
> example, if one delivers IPFIX from the router data plane, one either has to
> modify the router architecture to include additional complex computed
> information in the data plane architecture (a bad place to add complexity) or
> one has to give up and move all the information through the control plane.
> And even the control plane likely has to add complexity to its RIB logic, as it has
> to move additional information from BGP to the common structures.
> 
> The secondary problem is that this additional work is justified for the router by
> the claim that the unusual usage of applying community tags for geographical
> location of customers is a common practice.  It is a legal practice.  And I
> presume it is done somewhere or the authors would not be asking for it.   But
> it is not common.
> 
> In short, since even the draft admits that this is not needed, I recommend
> against publishing this document as an RFC.