Re: [OPSAWG] I-D Action: draft-ietf-opsawg-tacacs-08.txt

"Douglas Gash (dcmgash)" <dcmgash@cisco.com> Mon, 19 March 2018 15:30 UTC

Return-Path: <dcmgash@cisco.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3E80129C6B for <opsawg@ietfa.amsl.com>; Mon, 19 Mar 2018 08:30:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.529
X-Spam-Level:
X-Spam-Status: No, score=-14.529 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7_gefc2_7OFc for <opsawg@ietfa.amsl.com>; Mon, 19 Mar 2018 08:30:58 -0700 (PDT)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB507129C5D for <opsawg@ietf.org>; Mon, 19 Mar 2018 08:30:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=21548; q=dns/txt; s=iport; t=1521473457; x=1522683057; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=FkZGkKZlEkALNx664of0LSh5ZXGfUGRs1i650KyML+k=; b=b7BU/goH3Xk8eqtyPK8c7+yfiC3A4det1bKENi9E6alkcreU38mEm3lx y60ijyNy492jVVRmO65edzFIFTEtKM0iBOUwpsYPjH/L4CWHliBoZvmz1 j6iLDBNIh/IG7fT5YKTP4GDAEtK9UkoBzyA1vKLsP3W6mE9QW1qADAeSA A=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0BQAgCo1q9a/4oNJK1UCRkBAQEBAQEBAQEBAQEHAQEBAQGCWnZmcigKg1OYF4IDgRaOcYchCxgBCoQgTQIagyYhNxUBAgEBAQEBAQJrHQuFJQEBAQQBASFLGwIBCBEDAQIBJwMCAgIlCxQJCAIEExuEGWQPqRGCJiaESINpgg6FM4IVgykogniDHgEBAgEBF4EhFDaCaDCCMQOHQZB1CQKGBYkqgU0/gz2CcoRyiTCGXgIREwGBKQEOJiIzgR9wFRkhKgGCGAmCKRuOHnSPQIEYAQEB
X-IronPort-AV: E=Sophos;i="5.48,331,1517875200"; d="scan'208,217";a="359151057"
Received: from alln-core-5.cisco.com ([173.36.13.138]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2018 15:30:56 +0000
Received: from XCH-ALN-014.cisco.com (xch-aln-014.cisco.com [173.36.7.24]) by alln-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id w2JFUukG008921 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL) for <opsawg@ietf.org>; Mon, 19 Mar 2018 15:30:56 GMT
Received: from xch-aln-014.cisco.com (173.36.7.24) by XCH-ALN-014.cisco.com (173.36.7.24) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 19 Mar 2018 10:30:56 -0500
Received: from xch-aln-014.cisco.com ([173.36.7.24]) by XCH-ALN-014.cisco.com ([173.36.7.24]) with mapi id 15.00.1320.000; Mon, 19 Mar 2018 10:30:56 -0500
From: "Douglas Gash (dcmgash)" <dcmgash@cisco.com>
To: "opsawg@ietf.org" <opsawg@ietf.org>
Thread-Topic: [OPSAWG] I-D Action: draft-ietf-opsawg-tacacs-08.txt
Thread-Index: AQHTv5PAuo/gd2wOc0OFAYu3i9xDmKPYAzMA
Date: Mon, 19 Mar 2018 15:30:56 +0000
Message-ID: <BB4E3A16-5C5A-42CF-93DA-E58C8ABBD8BE@cisco.com>
References: <151905481837.18617.15913982011400739178@ietfa.amsl.com> <5aef06e0-68a6-cdd1-d165-0eaba1e10d8f@cisco.com> <CAB4uO_yXQYw0gQi-DWrLeV-vsE1xzPdS7D3AFRM4yLT+h+X=Rw@mail.gmail.com>
In-Reply-To: <CAB4uO_yXQYw0gQi-DWrLeV-vsE1xzPdS7D3AFRM4yLT+h+X=Rw@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.26.0.170902
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.229.136.16]
Content-Type: multipart/alternative; boundary="_000_BB4E3A165C5A42CF93DAE58C8ABBD8BEciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/5d0p-RDuw-icZohAqN-L0QhpNs0>
Subject: Re: [OPSAWG] I-D Action: draft-ietf-opsawg-tacacs-08.txt
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 15:31:00 -0000

Apologies for the delay, For some reason the mails did not get through until fellow author kindly forwarded them, disturbed by my rudeness for not having responded.

Thanks Joe, all very valid and will fix forthwith,

---------- Forwarded message ---------
From: Joe Clarke <jclarke@cisco.com<mailto:jclarke@cisco.com>>
Date: Di., 20. Feb. 2018 um 17:52 Uhr
Subject: Re: [OPSAWG] I-D Action: draft-ietf-opsawg-tacacs-08.txt
To: <opsawg@ietf.org<mailto:opsawg@ietf.org>>


Thank you, authors.  Would you send a synopsis of the changes to the
list as well as what you feel is left to do?  It would be good to spur
some more discussion on this.

I read through the text, focusing on the changes, and found a few typos
and nits.

Section 1:

OLD:

The normative description of Legacy features such as ARAP and
outbound authentication have

NEW:

The normative description of Legacy features such as ARAP and
outbound authentication has

===

Section 1:

s/authroization/authorization/

===

Section 3.3

You have one reference to "Single connection Mode".  Why is the 'c'
lowercase here?  For consistency, it should be uppercase.

===

Section 3.4

OLD:

For example, the client try alternative methods, if they are available,

NEW:

For example, the client tries alternative methods, if they are available,

===

Section 3.4

s/implmentation/implementation/

===

Section 3.5

OLD:

.  for example

NEW:

.  For example

===

Section 3.7

OLD:

refer to section section

NEW:

refer to section

===

Section 4.1

You refer to the Unix su(1) command in man page style notation.  This
may not be fully understood by all readers.  I think it would be better
to describe what su does in a short phrase (This is comparable to the
"su" command on Unix, which substitutes the current user's identity with
another).

===

Section 4.4.2.3

s/alays/always/

===

Sections 4.4.2.4 and 4.4.2.5

OLD:

The TACACS+ server must rejects

NEW:

The TACACS+ server must reject

===

Section 4.4.3

s/temrination/termination/

===

Section 4.4.3

You say, "oplease refer to section" (which has a typo).  But I don't
think you need the please at all here.

===

Section 5

s/clients actions/client's actions/

===

Section 5.1

s/corrsponds/corresponds/

===

Section 7.1

Stardate is canonically inconsistent

:-)

===

Section 7.2

Under nohangup, I think you have a typo with "authorization.y."  Not
sure if you intended something else there, or that "y." just crept in.

===

Section 8

s/()such as/(such as/

===

Section 8

s/starts starts/starts/

===

Section 8

s/reuthentication/reauthentication/

===

Section 8

You mention su again, but do so without man page notation.  you also
refer to unix instead of Unix.  Perhaps a good solution is to point to
one of the web=based man page gateways to create a true xref for su.

===

Section 9.1

s/For this reasons/For these reasons/

===

Section 9.2

s/which may me/which may be/

===

Section 9.5

s/apropriate/appropriate/

===

Section 9.5

s/send send secret keys/send secret keys/

Joe




On 2/19/18 10:40, internet-drafts@ietf.org<mailto:internet-drafts@ietf.org> wrote:
>
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Operations and Management Area Working Group WG of the IETF.
>
>         Title           : The TACACS+ Protocol
>         Authors         : Thorsten Dahm
>                           Andrej Ota
>                           Douglas C. Medway Gash
>                           David Carrel
>                           Lol Grant
>       Filename        : draft-ietf-opsawg-tacacs-08.txt
>       Pages           : 43
>       Date            : 2018-02-19
>
> Abstract:
>    TACACS+ provides Device Administration for routers, network access
>    servers and other networked computing devices via one or more
>    centralized servers.  This document describes the protocol that is
>    used by TACACS+.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-opsawg-tacacs/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-opsawg-tacacs-08
> https://datatracker.ietf.org/doc/html/draft-ietf-opsawg-tacacs-08
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-opsawg-tacacs-08
>
>
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org<http://tools.ietf.org>.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> OPSAWG mailing list
> OPSAWG@ietf.org<mailto:OPSAWG@ietf.org>
> https://www.ietf.org/mailman/listinfo/opsawg
>

_______________________________________________
OPSAWG mailing list
OPSAWG@ietf.org<mailto:OPSAWG@ietf.org>
https://www.ietf.org/mailman/listinfo/opsawg


--
Thorsten Dahm

Network Engineer
Google Ireland Ltd.
The Gasworks, Barrow Street
Dublin 4,  Ireland

Registered in Dublin, Ireland
Registration Number: 368047