Re: [OPSAWG] Last Call: <draft-ietf-opsawg-l2nm-15.txt> (A YANG Network Data Model for Layer 2 VPNs) to Proposed Standard

[tom petch <[e-mail]>]

On 29/04/2022 15:40, The IESG wrote:
 > The IESG has received a request from the Operations and Management Area
 > Working Group WG (opsawg) to consider the following document: - 'A YANG
 > Network Data Model for Layer 2 VPNs'
 >    <draft-ietf-opsawg-l2nm-15.txt> as Proposed Standard

Two more YANG quirks, belatedly.

s.7.6 has
                        |        +--:(evpn-bgp)
                        |           +--rw df-preference?     uint16
                        |           +--rw vpws-service-instance
while s.7.6.2 has
                |        +--:(evpn-bgp)
                |           +--rw vpws-service-instance
df-preference is present in the YANG module so I think that the approach 
in s.7.6 is preferable to that of s.7.6.2.


s.7.5.2 has
   +--rw (signaling-option)?              choice
       |     +--:(bgp)                            case
       |     |  ...                                choice bgp-type
       |     +--:(ldp-or-l2tp)                    case

so I expect to see
  choice signaling-option   which I do on page 87
  case bgp                  also on page 87
  ....
  case ldp-or-l2tp          nowhere to be seen.
In fact, there is no case, rather there is a container with that 
identifier on page 93.  This is valid  YANG - a container can stand in 
for a case - but with six pages of YANG in-between, this is hard to 
follow.  I would suggest /container/case/ or if there is a reason for 
not using case, then add a comment to that effect in the YANG module 
prior to the container statement.

Tom Petch

>
> The IESG plans to make a decision in the next few weeks, and solicits final
> comments on this action. Please send substantive comments to the
> [e-mail] mailing lists by 2022-05-13. Exceptionally, comments may
> be sent to [e-mail] instead. In either case, please retain the beginning
> of the Subject line to allow automated sorting.
>
> Abstract
>
>
>     This document defines an L2VPN Network YANG Model (L2NM) which can be
>     used to manage the provisioning of Layer 2 Virtual Private Network
>     services within a network (e.g., service provider network).  The L2NM
>     complements the Layer 2 Service Model (L2SM) by providing a network-
>     centric view of the service that is internal to a service provider.
>     The L2NM is particularly meant to be used by a network controller to
>     derive the configuration information that will be sent to relevant
>     network devices.
>
>     Also, this document defines a YANG module to manage Ethernet segments
>     and the initial versions of two IANA-maintained modules that defines
>     a set of identities of BGP Layer 2 encapsulation types and pseudowire
>     types.
>
>
>
>
> The file can be obtained via
> https://datatracker.ietf.org/doc/draft-ietf-opsawg-l2nm/
>
>
>
> No IPR declarations have been submitted directly on this I-D.
>
>
>
>
>
> _______________________________________________
> IETF-Announce mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/ietf-announce
> .
>