Re: [OPSAWG] Opsdir last call review of draft-ietf-opsawg-service-assurance-yang-09

Jean Quilbeuf <jean.quilbeuf@huawei.com> Mon, 28 November 2022 12:32 UTC

Return-Path: <jean.quilbeuf@huawei.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1D60BC1524A2; Mon, 28 Nov 2022 04:32:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wPIB-EW800su; Mon, 28 Nov 2022 04:32:10 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 750FEC1522D1; Mon, 28 Nov 2022 04:31:50 -0800 (PST)
Received: from fraeml743-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4NLPsG5xJmz6HJTS; Mon, 28 Nov 2022 20:28:50 +0800 (CST)
Received: from kwepemi500011.china.huawei.com (7.221.188.124) by fraeml743-chm.china.huawei.com (10.206.15.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 28 Nov 2022 13:31:48 +0100
Received: from frapeml500001.china.huawei.com (7.182.85.94) by kwepemi500011.china.huawei.com (7.221.188.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 28 Nov 2022 20:31:45 +0800
Received: from frapeml500001.china.huawei.com ([7.182.85.94]) by frapeml500001.china.huawei.com ([7.182.85.94]) with mapi id 15.01.2375.031; Mon, 28 Nov 2022 13:31:43 +0100
From: Jean Quilbeuf <jean.quilbeuf@huawei.com>
To: "Wubo (lana)" <lana.wubo@huawei.com>, "ops-dir@ietf.org" <ops-dir@ietf.org>
CC: "draft-ietf-opsawg-service-assurance-yang.all@ietf.org" <draft-ietf-opsawg-service-assurance-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>
Thread-Topic: Opsdir last call review of draft-ietf-opsawg-service-assurance-yang-09
Thread-Index: AQHY/bwL7Q3Al7GP8kGucuZzMHbfxa5URS+Q
Date: Mon, 28 Nov 2022 12:31:43 +0000
Message-ID: <1d749265aa714f50a94eed1023b3548a@huawei.com>
References: <166904369359.62390.8340929694339676488@ietfa.amsl.com>
In-Reply-To: <166904369359.62390.8340929694339676488@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.206.138.57]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/7cN8MKVKu82PPYV3imr0dd--sXk>
Subject: Re: [OPSAWG] Opsdir last call review of draft-ietf-opsawg-service-assurance-yang-09
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Nov 2022 12:32:14 -0000

Hi Bo,
Thanks for your comments. Please find our answers inline.

The full diff is here:  https://www.ietf.org/rfcdiff?url2=draft-ietf-opsawg-service-assurance-yang-10 

Best,
Jean


> -----Original Message-----
> From: Bo Wu via Datatracker [mailto:noreply@ietf.org]
> Sent: Monday 21 November 2022 15:15
> To: ops-dir@ietf.org
> Cc: draft-ietf-opsawg-service-assurance-yang.all@ietf.org; last-call@ietf.org;
> opsawg@ietf.org
> Subject: Opsdir last call review of draft-ietf-opsawg-service-assurance-yang-
> 09
> 
> 
> Nits/editorial comments:
> 
> 1.It would be better to add some text to explain why the agent list is defined.
> Introduction says the module should be supported by an agent.
> 
Added the collector export use case:
   " The module is also intended to be exported by the SAIN collector which aggregates the output of several SAIN agents to provide the global assurance graph.
        In that case, only the telemetry export use case is considered."

> 2. In section 3.2 and 3.4
> The "subservice" list contains all the subservice instances currently
>    configured on the server.
> "server" is not defined in the document. Is it referring "SAIN agent"?

Changed to:
   "The "subservice" list contains all the subservice instances currently known by the server (i.e. SAIN agent or SAIN collector)."

> 3. Appendix C Example of YANG instances
> Paragraph 1
> s/examples/example since there is only one example.

Removed the plural, thanks.