Re: [OPSAWG] RtgDir Last Call review: draft-ietf-opsawg-sap-04

Mach Chen <mach.chen@huawei.com> Wed, 18 May 2022 09:34 UTC

Return-Path: <mach.chen@huawei.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EAA0EC14F723; Wed, 18 May 2022 02:34:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PNkwkwz1AEOS; Wed, 18 May 2022 02:34:26 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 07F9DC14F716; Wed, 18 May 2022 02:34:26 -0700 (PDT)
Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4L37593TDgz6GDGw; Wed, 18 May 2022 17:30:37 +0800 (CST)
Received: from dggpemm100001.china.huawei.com (7.185.36.93) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 18 May 2022 11:34:22 +0200
Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 18 May 2022 17:34:20 +0800
Received: from dggpemm500002.china.huawei.com ([7.185.36.229]) by dggpemm500002.china.huawei.com ([7.185.36.229]) with mapi id 15.01.2375.024; Wed, 18 May 2022 17:34:20 +0800
From: Mach Chen <mach.chen@huawei.com>
To: "mohamed.boucadair@orange.com" <mohamed.boucadair@orange.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "draft-ietf-opsawg-sap.all@ietf.org" <draft-ietf-opsawg-sap.all@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: RtgDir Last Call review: draft-ietf-opsawg-sap-04
Thread-Index: Adhl0DweELvuRAxpQ5itBXGYoq6lEQAJf4GQAMWwItAAWt118AAIdu9Q
Date: Wed, 18 May 2022 09:34:20 +0000
Message-ID: <6c5f0dda82a6461bb088c0d92f5a7baa@huawei.com>
References: <97b21743e4d7460d8a15c1ee0ab2ebb2@huawei.com> <6951_1652358046_627CFB9E_6951_291_1_1c4d05ebc1984a1d9eaef1ab78609269@orange.com> <8dcd3b4bfc6b4a0ba23d3eec2d94c3b9@huawei.com> <28200_1652852044_6284854C_28200_105_1_3a6c9abc34de4cf284621bd822b12ab5@orange.com>
In-Reply-To: <28200_1652852044_6284854C_28200_105_1_3a6c9abc34de4cf284621bd822b12ab5@orange.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.110.46.250]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/A6zwNVboFG1gTjD0P46ytPZDRpA>
Subject: Re: [OPSAWG] RtgDir Last Call review: draft-ietf-opsawg-sap-04
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2022 09:34:30 -0000

Hi Med,

Indeed, I just updated the datatracker to reflect the review.

Best regards,
Mach

> -----Original Message-----
> From: mohamed.boucadair@orange.com <mohamed.boucadair@orange.com>
> Sent: Wednesday, May 18, 2022 1:34 PM
> To: Mach Chen <mach.chen@huawei.com>; rtg-dir@ietf.org
> Cc: draft-ietf-opsawg-sap.all@ietf.org; opsawg@ietf.org; last-call@ietf.org
> Subject: RE: RtgDir Last Call review: draft-ietf-opsawg-sap-04
> 
> Hi Mach,
> 
> Thank you for checking. All the changes are available in -05.
> 
> BTW, it seems that your review is not tracked (still displayed as incomplete):
> https://datatracker.ietf.org/doc/draft-ietf-opsawg-sap/reviewrequest/15831/
> 
> Cheers,
> Med
> 
> > -----Message d'origine-----
> > De : Mach Chen <mach.chen@huawei.com>
> > Envoyé : mardi 17 mai 2022 08:43
> > À : BOUCADAIR Mohamed INNOV/NET <mohamed.boucadair@orange.com>;
> > rtg-dir@ietf.org Cc : draft-ietf-opsawg-sap.all@ietf.org;
> > opsawg@ietf.org; last- call@ietf.org Objet : RE: RtgDir Last Call
> > review: draft-ietf-opsawg-sap-04
> >
> > Hi Med,
> >
> > Thanks for considering my comments, I am OK with your resolution.
> >
> > Best regards,
> > Mach
> >
> > > -----Original Message-----
> > > From: mohamed.boucadair@orange.com
> > <mohamed.boucadair@orange.com>
> > > Sent: Thursday, May 12, 2022 8:21 PM
> > > To: Mach Chen <mach.chen@huawei.com>; rtg-dir@ietf.org
> > > Cc: draft-ietf-opsawg-sap.all@ietf.org; opsawg@ietf.org;
> > > last-call@ietf.org
> > > Subject: RE: RtgDir Last Call review: draft-ietf-opsawg-sap-04
> > >
> > > Hi Mach,
> > >
> > > Thank you for the review. The changes to address the review can
> > be tracked at:
> > > https://tinyurl.com/sap-latest
> > >
> > > Please see inline.
> > >
> > > Cheers,
> > > Med
> > >
> > > > -----Message d'origine-----
> > > > De : last-call <last-call-bounces@ietf.org> De la part de Mach
> > Chen
> > > > Envoyé : jeudi 12 mai 2022 11:11 À : rtg-dir@ietf.org Cc :
> > > > draft-ietf-opsawg-sap.all@ietf.org; opsawg@ietf.org; last-
> > > > call@ietf.org Objet : [Last-Call] RtgDir Last Call review:
> > > > draft-ietf-opsawg-
> > > > sap-04
> > > >
> > > > Hello,
> > > >
> > > > I have been selected as the Routing Directorate reviewer for
> > this
> > > > draft. The Routing Directorate seeks to review all routing or
> > > > routing-related drafts as they pass through IETF last call and
> > IESG
> > > > review, and sometimes on special request. The purpose of the
> > review
> > > > is to provide assistance to the Routing ADs. For more
> > information
> > > > about the Routing Directorate, please see
> > > > http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
> > > >
> > > > Although these comments are primarily for the use of the
> > Routing
> > > > ADs, it would be helpful if you could consider them along with
> > any
> > > > other IETF Last Call comments that you receive, and strive to
> > > > resolve them through discussion or by updating the draft.
> > > >
> > > > Document: draft-ietf-opsawg-sap-04
> > > > Reviewer: Mach Chen
> > > > Review Date: 2022/05/15
> > > > IETF LC End Date:
> > > > Intended Status: Standards Track
> > > >
> > > > Summary:
> > > > I have some minor concerns about this document that I think
> > should
> > > > be resolved before publication.
> > > >
> > > > Major Issues:
> > > > None
> > > >
> > > > Minor Issues:
> > > > 1. Section 2, the definition of Service Attachment Point (SAP)
> > is
> > > > hard to understand here, the definition depends on the
> > definition of
> > > > "service's endpoint" and "TP" that is not defined in the
> > document or
> > > > lack of references(if defined in other documents).
> > > > More text needed here and it's better to make it consistent
> > with the
> > > > definition in other places (e.g., Introduction section).
> > >
> > > [Med] Updated the text to:
> > >
> > > NEW:
> > >    Service Attachment Points (SAPs):  An abstraction of the
> > network
> > >       reference points (e.g., PE side of an AC) where network
> > services
> > >       can be delivered and/or being delivered to customers.
> > >
> > > >
> > > > 2. Section 3,
> > > > " The
> > > >    model is also used to retrieve the network points where a
> > service
> > > > is
> > > >    being delivered to customers."
> > > > What's the meaning of the "network points" here? Is it a node,
> > link,
> > > > interface or something else, some clarification needed here,
> > or
> > > > using a more specific and well-known term here.
> > > >
> > >
> > > [Med] An example was added to updated definition provided above.
> > >
> > > > 3. Section 4, " Also, the SAP is not a tunnel termination
> > point
> > > > (TTP) (Section 3.6 of
> > > >    [RFC8795]) nor a link." Why need to state this here, maybe
> > it's
> > > > better to move it to the place of the definition of "SAP".
> > >
> > > [Med] We prefer to maintain it here as this section is about
> > > positioning the model vs. existing models.
> > >
> > > >
> > > > 4. identity basic-connectivity {
> > > >        base vpn-common:service-type;
> > > >        description
> > > >          "Basic IP connectivity. This is, for example, a plain
> > > >           connectivity offered to Enterprises over a dedicated
> > > >           or shared MPLS infrastructure."; Since it's a "IP
> > > > connectivity", why emphasize that it is over an "MPLS"
> > > > infrastructure?
> > > >
> > >
> > > [Med] That was just an example.
> > >
> > > > Nits:
> > > > 1. Abstract section, the second sentence of paragraph, s/ The
> > > > Service Attachment Points/SAPs
> > >
> > > [Med] OK
> > >
> > >
> > > 2. Section 1, the last 3rd para,
> > > > it's better to add references when mention L2VPN and L3VPN
> > >
> > > [Med] Added a pointer to RFC4026.
> > >
> > >
> > > 3.
> > > > Section 3, suggest to add a reference to EVPN.
> > >
> > > [Med] Several EVPN-related are provided in Section 5 with
> > explicit
> > > association with the EVPN flavor.
> > >
> > > > 4. Section 5, suggest to add the references to LAG, IRB.
> > >
> > > [Med] OK
> > >
> > > > 5. identity virtual-network,  suggest to copy the description
> > of
> > > > "Virtual Network" from RFC 8453.
> > >
> > > [Med] Went with the following:
> > >
> > > OLD:
> > >       "Virtual network.";
> > > NEW:
> > >       "Virtual network. Refers to a logical network instance
> > >        that is built over a physical network.";
> > >
> > > > 6. It's better to add more text to the description of identity
> > phy,
> > > > loopback, lag and irb.
> > >
> > > [Med] These are well-known and well-established. I don't think
> > we need
> > > to say much here, but will see. Thanks.
> > >
> > > >
> > > > Best regards,
> > > > Mach
> > > >
> > > > --
> > > > last-call mailing list
> > > > last-call@ietf.org
> > > > https://www.ietf.org/mailman/listinfo/last-call
> > >
> > >
> ________________________________________________________________
> > > _________________________________________________________
> > >
> > > Ce message et ses pieces jointes peuvent contenir des
> > informations
> > > confidentielles ou privilegiees et ne doivent donc pas etre
> > diffuses,
> > > exploites ou copies sans autorisation. Si vous avez recu ce
> > message
> > > par erreur, veuillez le signaler a l'expediteur et le detruire
> > ainsi
> > > que les pieces jointes. Les messages electroniques etant
> > susceptibles
> > > d'alteration, Orange decline toute responsabilite si ce message
> > a ete altere, deforme ou falsifie. Merci.
> > >
> > > This message and its attachments may contain confidential or
> > > privileged information that may be protected by law; they should
> > not
> > > be distributed, used or copied without authorisation.
> > > If you have received this email in error, please notify the
> > sender and
> > > delete this message and its attachments.
> > > As emails may be altered, Orange is not liable for messages that
> > have
> > > been modified, changed or falsified.
> > > Thank you.
> 
> 
> ________________________________________________________________
> _________________________________________________________
> 
> Ce message et ses pieces jointes peuvent contenir des informations
> confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou
> copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le
> signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
> electroniques etant susceptibles d'alteration, Orange decline toute
> responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
> 
> This message and its attachments may contain confidential or privileged
> information that may be protected by law; they should not be distributed, used or
> copied without authorisation.
> If you have received this email in error, please notify the sender and delete this
> message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been
> modified, changed or falsified.
> Thank you.