IETF Logo Mail Archive

[OPSAWG] draft-ietf-opsawg-ipfix-tcpo-v6eh-08 shepherd review

Thomas.Graf@swisscom.com Sun, 21 January 2024 08:45 UTC

Return-Path: <Thomas.Graf@swisscom.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 43D5AC14F69B; Sun, 21 Jan 2024 00:45:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.405
X-Spam-Level:
X-Spam-Status: No, score=-4.405 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=swisscom.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XZv98Mzfz46n; Sun, 21 Jan 2024 00:45:02 -0800 (PST)
Received: from mail.swisscom.com (mailout120.swisscom.com [138.188.166.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EDA6FC14F699; Sun, 21 Jan 2024 00:44:54 -0800 (PST)
Received: by mail.swisscom.com; Sun, 21 Jan 2024 09:44:51 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=swisscom.com; s=iscm; t=1705826691; bh=3zSLAJo62gfkGQHG/QwsQgKTPoTP/J4pI63LHxiabBk=; h=From:To:CC:Subject:Date; b=ow/390bU02+i0qbSYkqA3Ako/lhdGKu5f9nrzmrVuNfaY93gu6tS/w0GacJHmYl20 Y6ZE0+u7gVaY/ds02g5zTTUgCVw4QK5XvZFV7L+UEr6pjfF5s81LcQpYyJf8FHQ33h UiXKEZMlpNfZLsNwGRAN6PTrLTH1ovGkVwDTCfbldbOrev5tmC/dCjwXpP2WYZDnOT dOvkHvPLegwhvpBxOeKQzhw8yFPFVnAJI4LUEYk+IgUNQE/LhSd3mcvzHxuwZUtL14 vDpmsBG2Bt2v2y+/qbL6HirkYDl2q4Os1T0TT49MS7ZH+73agisZbDzeE8HojqNpkw XVLHPpYxZ+awA==
MIME-Version: 1.0
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg="sha-256"; boundary="----=_Part_3826242_1187829166.1705826691066"
X-Mailer: Totemo_TrustMail_(Notification)
From: Thomas.Graf@swisscom.com
To: draft-ietf-opsawg-ipfix-tcpo-v6eh.authors@ietf.org
CC: draft-ietf-opsawg-ipfix-tcpo-v6eh.chairs@ietf.org, opsawg@ietf.org
Thread-Topic: draft-ietf-opsawg-ipfix-tcpo-v6eh-08 shepherd review
Thread-Index: AdpMQuKMC0dc7zgnTaGxd/2eWd0w+Q==
Date: Sun, 21 Jan 2024 08:44:48 +0000
Message-ID: <da568570a54a48a2970b4528f6295c87@swisscom.com>
Accept-Language: en-US, de-CH
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_2e1fccfb-80ca-4fe1-a574-1516544edb53_ActionId=22f60141-9b55-42ac-a712-0f38357833a7; MSIP_Label_2e1fccfb-80ca-4fe1-a574-1516544edb53_ContentBits=0; MSIP_Label_2e1fccfb-80ca-4fe1-a574-1516544edb53_Enabled=true; MSIP_Label_2e1fccfb-80ca-4fe1-a574-1516544edb53_Method=Standard; MSIP_Label_2e1fccfb-80ca-4fe1-a574-1516544edb53_Name=C2 Internal; MSIP_Label_2e1fccfb-80ca-4fe1-a574-1516544edb53_SetDate=2024-01-21T08:20:52Z; MSIP_Label_2e1fccfb-80ca-4fe1-a574-1516544edb53_SiteId=364e5b87-c1c7-420d-9bee-c35d19b557a1;
x-originating-ip: [138.188.161.184]
X-CFilter-Loop: Reflected
X-Trustmail: processed
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/YKfKrGTlxxOnFkgfGwFz_Zuk5DU>
Subject: [OPSAWG] draft-ietf-opsawg-ipfix-tcpo-v6eh-08 shepherd review
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jan 2024 08:45:07 -0000

Dear Med and Benoit,

Thanks a lot. The document is very well written and straight forward. As shared previously during the working group, I believe this document is very valuable to network operators since it addresses current issues in the observation of IPv6 headers and TCP options.

I have reviewed the document and wrote the initial shepherd review https://datatracker.ietf.org/doc/draft-ietf-opsawg-ipfix-tcpo-v6eh/shepherdwriteup/.

I agree with the points from the IPFIX doctor and the Transport area in regards to the comments made to the data type choice for tcpOptionsFull, tcpSharedOptionExID16 and tcpSharedOptionExID32. Mirroring my concerns previously shared in the review of draft-ietf-opsawg-tsvwg-udp-ipfix with udpExpOptionExID and udpUnsafeExpOptionExID.

I suggest to change the sentence from "Because some of these limitations cannot be addressed" to "Because some of these issues cannot be addressed" which is used in several occasions in the document.

I suggest in section 3.1, to extend the paragraph

Regarding "exported in separate ipv6ExtensionHeadersFull IEs" described in Section 3.1, I assume this refers to Section 8 of RFC 7011 (https://datatracker.ietf.org/doc/html/rfc7011#section-8) where

   If an Information Element is required more than once in a Template,
   the different occurrences of this Information Element SHOULD follow
   the logical order of their treatments by the Metering Process.

Is described. If yes, I suggest to reference. If not, to clarify the meaning within the document.

Here are some nits I found.

replace headerss with headers
replace octers with octets

Otherwise all perfect.

Best wishes
Thomas

v2.46.0 | Report a Bug | By Email | System Status