Re: [OPSAWG] Opsdir early review of draft-ietf-opsawg-ipfix-tcpo-v6eh-05

[[e-mail]]

Hi Yingzhen, 

Thank you for the review. 

The changes to address your review can be seen at: https://github.com/boucadair/ipfix-tcpoptions-and-v6eh/commit/ee2f459370d67df88866600438f315d55a0942b9

Please see inline for more context.

Cheers,
Med

> -----Message d'origine-----
> De : Yingzhen Qu via Datatracker <[e-mail]>
> Envoyé : vendredi 5 janvier 2024 00:31
> À : [e-mail]
> Cc : [e-mail];
> [e-mail]
> Objet : Opsdir early review of draft-ietf-opsawg-ipfix-tcpo-v6eh-
> 05
> 
> Reviewer: Yingzhen Qu
> Review result: Has Nits
> 
> I have reviewed this document as part of the Ops area
> directorate's ongoing effort to review all IETF documents being
> processed by the IESG.  These comments were written primarily for
> the benefit of the Ops area directors.
> Document editors and WG chairs should treat these comments just
> like any other last-call comments.
> 
> This document is well written and I believe it is ready for
> publication.
> However I have a few comments on the latest version v-05.
> 
> 
> The line numbers are generated using idnits.
> 
> 93	   This document specifies new IP Flow Information Export
> (IPFIX)
> 94	   Information Elements (IEs) to solve a set of issues
> encountered with
> 
> nits: reference to RFC7011 and RFC7012 should be added.

[Med] OK to cite 7011 here. 

> 
> 170	   The definition of the ipv6ExtensionHeaders IE is updated
> in
> 171	   [I-D.ietf-opsawg-ipfix-fixes] to address some of the
> issues listed in
> 172	   Section 1.1.  Because some of these limitations can't be
> addressed by
> 173	   simple updates to ipv6ExtensionHeaders, this section
> specifies a set
> 174	   of new IEs to address all the ipv6ExtensionHeaders IE
> limitations.
> 
> Question: I'm confused here. Do the new IEs proposed in this
> document address all the issues? If so, why are the updates to
> ipv6ExtensionHeaders needed? Some clarifications will be helpful.
> 

[Med] The new IEs fix all the issues. We do already have the following in I-D.ietf-opsawg-ipfix-fixes to zoom into this:

==
Section 4.1.2 specifies fixes to the first three issues. [I-D.ietf-opsawg-ipfix-tcpo-v6eh] specifies a new Information Element to fix the last issue. Other Information Elements are defined in [I-D.ietf-opsawg-ipfix-tcpo-v6eh] to address some other limitations such as lack of reporting of extension header chains or aggregate extension headers length.

Note that some implementations may not be able to export all observed extension headers in a Flow because of a hardware of software limit (see, e.g., [I-D.ietf-6man-eh-limits]. The specification of the ipv6ExtensionHeaders Information Element does not discuss whether it covers all enclosed extension headers or only up to a limit. A solution to this shortcoming is also defined in [I-D.ietf-opsawg-ipfix-tcpo-v6eh].
==

Rather than duplicating text, I added this new sentence: "Refer also to {{Section 4.1.1 of ?I-D.ietf-opsawg-ipfix-fixes}} for more details."

> 187	      packet of this Flow contained the respective IPv6
> extension
> 
> nits: s/contained/contains
> 

[Med] Fixed. Thanks.
____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.