IETF Logo Mail Archive

Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07

"Rob Wilton (rwilton)" <rwilton@cisco.com> Sat, 11 July 2020 08:46 UTC

Return-Path: <rwilton@cisco.com>
X-Original-To: opsawg@ietfa.amsl.com
Delivered-To: opsawg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DC56E3A08E5; Sat, 11 Jul 2020 01:46:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.598
X-Spam-Level:
X-Spam-Status: No, score=-9.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=B/KTkPue; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=Zlj8UwS0
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XbeuqPgpbVh1; Sat, 11 Jul 2020 01:46:36 -0700 (PDT)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA9D43A08E1; Sat, 11 Jul 2020 01:46:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=12836; q=dns/txt; s=iport; t=1594457196; x=1595666796; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=BY/XRjKSPFAAYqxKs9YTENJjDJZCYMT5ABb8GK4/hNQ=; b=B/KTkPueg8PlglCm3vvs78bG5Tccyu9HaB+GbesU0/kGTlBNcfItK2DL nwpJHlQpRramOCkCK2NvPtv6tQWVNnl0N91rEYe2DBeui/kS5y8ae2NOS gR+5SOnmCNovt1x1nZVZdasFuCCGM8gX/EcMwmPKmsMYfkdpbcjbgjPQs o=;
X-Files: tacacs_plus_ad_review.txt : 7054
IronPort-PHdr: 9a23:OGMhOhX0joaStXOFkj5mo4jS3K7V8LGuZFwc94YnhrRSc6+q45XlOgnF6O5wiEPSBNyHuflFkOHR9avnXD9I7ZWAtSUEd5pBH18AhN4NlgMtSMiCFQXgLfHsYiB7eaYKVFJs83yhd0QAHsH4ag7Zo2a56ngZHRCsfQZwL/7+T4jVicn/3uuu+prVNgNPgjf1Yb57IBis6wvLscxDiop5IaF3wRzM8XY=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0B/AAAHewlf/4cNJK1gGQEBAQEBAQEBAQEBAQEBAQEBARIBAQEBAQEBAQEBAQGCCoFSUQeBRy8XFQqEKYNGA41QmF6BQoERA1UEBwEBAQwBAS0CBAEBhEwCF4F/AiQ4EwIDAQELAQEFAQEBAgEGBG2FLgEsDIVoBwEBAQEDEhEEGQEBNwELBAIBCBEEAQEBKgICAjAdCAEBBA4FCAYUEweCa4JLAy4BA50bAoE5iGF2fzODAQEBBUaEcBiBIGcHCYE4AYJpg1SGMxqBQT+BVIJNPoQIAQwGAQkaBTGCXjOCLY81gw6GSCaBIplJgQQKgl2EMYJWh3uKd4J0iTaNXYUjsGACBAIEBQIOAQEFgWojZ3BwFTuCaVAXAg2BGQWNABESg06KVnQ3AgYBBwEBAwl8jDYBJgeBBgExXwEB
X-IronPort-AV: E=Sophos;i="5.75,338,1589241600"; d="txt'?scan'208";a="511054628"
Received: from alln-core-2.cisco.com ([173.36.13.135]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 11 Jul 2020 08:46:35 +0000
Received: from XCH-ALN-002.cisco.com (xch-aln-002.cisco.com [173.36.7.12]) by alln-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id 06B8kYVw026678 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 11 Jul 2020 08:46:34 GMT
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-ALN-002.cisco.com (173.36.7.12) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 11 Jul 2020 03:46:34 -0500
Received: from xhs-aln-003.cisco.com (173.37.135.120) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 11 Jul 2020 04:46:33 -0400
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sat, 11 Jul 2020 03:46:33 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PT24nPOo41AAelyfIn3xEvkStv7QWl7IaiwAAcFn6k9KPDnFW7/3u9CawNucPmpcGXWfYQLmCkjK6Im6r6uZj2QXjG8Aq2AnQClZhR45d25o0B2WBQ33Nh3mapHa/MWi9wgAZU+jRlOqUrUMSikvgyhESjDL2NZFgwK7rJIhPT8k8xJq7m9taeDNOf9++mxj3vtsvqKvS+bzUhit5ibYOv1jNJjkME4KrVRGHxQs0dNmzgKmZaAG6DC0AZYzbw+v5Ze3SPWMxRmIB1WXDc3hm3oI+RuQyOHM5wM1uSjJY1nNv6+k5y3FVSzPwdJgqxDcHehHg+vIjYRgPvs+0p+bDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RkFonCo8E7D+CF4Hue33yLexfq5IOVfDo2c1tHjJhMI=; b=K9V3rTCWKpwhzTf4B7mlAWfGJ3FsQElyWKokvU7UqtXhp5w+f5GN9sea6+8NS2J6Y1XZgwHehe4dRQ+WR8lPo0YCfG/seW84249vp+tns8fDOQ3tx6X5Mz/Su7dGiYX5PLKCcyKIfsp3NBv4zbP9BSPBoTRfsokucVvkiAGgnIiBjDv7VL226X+pewGSzjEOoW1L7XEy26tJ3P5t3KCNFFiQ6gZlFfgn0ZxyfUAlrkg6JdxartMrdmO3inFVXYXLXGXcAPBvhlZQ+zDeNEtMzI2gZAI+DbbbgViJgU+N/xDx7pClVLwunGLWLSdUHSRBV4qCIq3tu0GyhjpOZxJkfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RkFonCo8E7D+CF4Hue33yLexfq5IOVfDo2c1tHjJhMI=; b=Zlj8UwS02W0btqoW0EIAtfcrO+i8V4ErReFe1uWWh4c6Zu1+hSX7lnhcfxIjki0wHDRz2GOGDM+IZA0LHuN6Y53j2DUJKNZAR5XSC+fCJHwYJyhPdlXPaYCtyrssOmXe1GoL1DSdy9pegcir9BzyNi0Sf+VobA1T6ZnhIOpIid0=
Received: from MN2PR11MB4366.namprd11.prod.outlook.com (2603:10b6:208:190::17) by BL0PR11MB3492.namprd11.prod.outlook.com (2603:10b6:208:7c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Sat, 11 Jul 2020 08:46:32 +0000
Received: from MN2PR11MB4366.namprd11.prod.outlook.com ([fe80::e9d4:79b5:aef1:be18]) by MN2PR11MB4366.namprd11.prod.outlook.com ([fe80::e9d4:79b5:aef1:be18%5]) with mapi id 15.20.3174.023; Sat, 11 Jul 2020 08:46:32 +0000
From: "Rob Wilton (rwilton)" <rwilton@cisco.com>
To: "Joe Clarke (jclarke)" <jclarke@cisco.com>
CC: "draft-ietf-opsawg-tacacs-yang.all@ietf.org" <draft-ietf-opsawg-tacacs-yang.all@ietf.org>, opsawg <opsawg@ietf.org>
Thread-Topic: AD review of draft-ietf-opsawg-tacacs-yang-07
Thread-Index: AdZW2lnspRS1VWiiT9qRjIzfKMZsMAALTK6AABX8kBA=
Date: Sat, 11 Jul 2020 08:46:32 +0000
Message-ID: <MN2PR11MB436687A91BC0FD04F8C9AC50B5620@MN2PR11MB4366.namprd11.prod.outlook.com>
References: <MN2PR11MB436612630CAFCACF3A89BD56B5650@MN2PR11MB4366.namprd11.prod.outlook.com> <F4203B1C-825F-43FB-BDC4-2DBDB7E74B31@cisco.com>
In-Reply-To: <F4203B1C-825F-43FB-BDC4-2DBDB7E74B31@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [82.15.79.32]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a9f44675-b390-46e9-5dd2-08d82576e9a9
x-ms-traffictypediagnostic: BL0PR11MB3492:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BL0PR11MB349292AA2AA8C4A6E59BEF75B5620@BL0PR11MB3492.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: oPEoY1huvyHSGg94Gzv289xValmGlDJ4ckM2ZB7e3/6UEQG3opD/kOeo+HBeVQgDzEJB7nYchb6nf8qGfV6g7qEGRljn2rUxQW4TO8VSvuapbw0xrOBC2dx41oicjImVJEO7yovXnpXlJR29zvLZhm1S5fL8+y3q5S1cSFPm/bIt+pOF4HuNcPvFs+8OmYHX5u3edGM+6Gwo1cAFK4ioz3udkRPma0f28r1QUabZ02z4/+QDXMIbxhbwoO6qCS/06m/Ebbp+eRQ6pOJDZyx0yOuNZm19ujw2ahKqtO2y5yKO27wwjyTxdmkkr47F0XY3rDp05WxVGkVQ9HCSRIKvVQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(376002)(396003)(136003)(39860400002)(346002)(66446008)(186003)(8936002)(8676002)(71200400001)(33656002)(52536014)(66476007)(5660300002)(66946007)(76116006)(9686003)(66556008)(66616009)(55016002)(64756008)(83380400001)(99936003)(54906003)(6862004)(316002)(4326008)(26005)(478600001)(53546011)(6636002)(6506007)(450100002)(86362001)(2906002)(7696005); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: DCHc4LaTFA83dt/CTRtAyfmeMy3mXoWRS3LDzqAyaVkCilLm68uEBqGvC5duzd8BxujYXz0HIxfkx9K9thCxHwiVfRqXbr71/XQVq68ATCbsKo8WMJ95uvDNF9j4nzAAEB3QigsTXawA39b7Z/UhRXNdyTBFUG1127lSLECsxJ10mLZzwTKzNK0aQlmNodoSUQKsjFy5p8KtMwP4koxeD+4adY5soTeYoSeUrXmODLtNSvSgiZ9CqNkADkbbnzzM10EsTRptIu9bu3Rz3+ATvtZFSBgC9UcUatC81rSOfCsETLtdbAGrtMnkY3T7ITt8n9W+cRmJLK/wQFqgNmyr3f0hJqE3LFztMLrXBgbvD6d/0woKNE2xSlEolwQ2KCR7xwyPVeLWGYQPuTGCnaGYqK4btR+mDsWE3r/LAdG91G+Y430BLI50pWmJpiQWKf2Mwcu3fd6mg2XVj+TSZYqDMUCyy7OFfGI5CWfyhmOrBNs=
Content-Type: multipart/mixed; boundary="_002_MN2PR11MB436687A91BC0FD04F8C9AC50B5620MN2PR11MB4366namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9f44675-b390-46e9-5dd2-08d82576e9a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2020 08:46:32.7755 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E2YAqB9hwHZlQTUJWDxodh2qm5dTN1aAJ/S1AzyWMlGs8Rf4qhDrtZBs9DDiUAGJ5hukeme+WoMU560QMK609A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3492
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.12, xch-aln-002.cisco.com
X-Outbound-Node: alln-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/opsawg/pfa2rbwzVfJUmre4oTTF0ipVt4E>
Subject: Re: [OPSAWG] AD review of draft-ietf-opsawg-tacacs-yang-07
X-BeenThere: opsawg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OPSA Working Group Mail List <opsawg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/opsawg>, <mailto:opsawg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/opsawg/>
List-Post: <mailto:opsawg@ietf.org>
List-Help: <mailto:opsawg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/opsawg>, <mailto:opsawg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Jul 2020 08:46:38 -0000

Hi Joe,

Review comments also attached as txt file.

Thanks,
Rob


> -----Original Message-----
> From: Joe Clarke (jclarke) <jclarke@cisco.com>
> Sent: 10 July 2020 23:15
> To: Rob Wilton (rwilton) <rwilton@cisco.com>
> Cc: draft-ietf-opsawg-tacacs-yang.all@ietf.org; opsawg <opsawg@ietf.org>
> Subject: Re: AD review of draft-ietf-opsawg-tacacs-yang-07
> 
> Thanks, Rob.  Maybe it’s just me, but your email is truncated as you can
> see below.  I also didn’t see any attachment.
> 
> Joe
> 
> > On Jul 10, 2020, at 12:52, Rob Wilton (rwilton) <rwilton@cisco.com>
> wrote:
> >
> > Apologies for the delay, but please find my AD review of the TACACS+
> YANG module draft.
> >
> > I would like to thank the authors for their work on this document, and
> the WG for providing reviews and input in this document.
> >
> > I believe that the document is in good shape but propose some minor
> changes to some of the wording in places.
> >
> > One particular question that I would like to pull to the top is the
> naming of the module and identifiers:
> > These generally use "tacacsplus", but I think that "tacacs-plus" might
> be better and more readable.
> >
> >
> > Full comments are inline in the document below (marked as #)
> >
> >
> >   The YANG model can be used with network management protocols such as
> >   NETCONF[RFC6241] to install, manipulate, and delete the configuration
> >   of network devices.
> >
> >    Abstract
> >
> >       This document defines a YANG module that augment the System
> >       Management data model defined in the RFC 7317 with TACACS+ client
> >       model.  The data model of Terminal Access Controller Access
> Control
> >       System Plus (TACACS+) client allows the configuration of TACACS+
> >       servers for centralized Authentication, Authorization and
> Accounting

v2.23.0 | Report a Bug | By Email