Re: [OSPF] Gen-ART LC review of draft-ietf-ospf-sbfd-discriminator-04

"Carlos Pignataro (cpignata)" <cpignata@cisco.com> Mon, 18 April 2016 17:38 UTC

Return-Path: <cpignata@cisco.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0AE1012DAE9; Mon, 18 Apr 2016 10:38:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.516
X-Spam-Level:
X-Spam-Status: No, score=-15.516 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DfHZRiCHDPSu; Mon, 18 Apr 2016 10:38:42 -0700 (PDT)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5289612D925; Mon, 18 Apr 2016 10:38:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=7447; q=dns/txt; s=iport; t=1461001122; x=1462210722; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=zgNXIwkjgKU55ZEZZUIV0EHOr5PDX4MeVIW1FYpaP6s=; b=DE6ZG6wDEaFlUF76S+8MWCQAyLN3uJmCrOWUcZXMkMowTkMVmAju5dbU ZBTRisb/CaNaGtmrSNOEJBFWYOgU1eL3Pc1RTJshCxuSmoRnAJpGJeVzw wy7xhEMWXFi2J8h4dWq3BC/x0qNWAorlAwNjxunNkbovT3GoJW7SUXJDu M=;
X-Files: signature.asc : 841
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AjAwBRGxVX/5tdJa1aAxaDIlN9BrUwh?= =?us-ascii?q?HMOgXEihWwCgTg4FAEBAQEBAQFlJ4RBAQEBAwEjVgULAgEIDgYEKgICMiUCBA4?= =?us-ascii?q?FDogTCA6qTJE6AQEBAQEBAQEBAQEBAQEBAQEBAQEBDQiGIYF1glaEXwEmgjkrg?= =?us-ascii?q?isFkx6EcAGDJIFmbYgWgWdOhACIXI8qAQ8PAUOBTIIcbAGIO34BAQE?=
X-IronPort-AV: E=Sophos;i="5.24,503,1454976000"; d="asc'?scan'208,217";a="93101305"
Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2016 17:38:40 +0000
Received: from XCH-RTP-016.cisco.com (xch-rtp-016.cisco.com [64.101.220.156]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id u3IHcdm5028797 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 18 Apr 2016 17:38:39 GMT
Received: from xch-rtp-020.cisco.com (64.101.220.160) by XCH-RTP-016.cisco.com (64.101.220.156) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Mon, 18 Apr 2016 13:38:38 -0400
Received: from xch-rtp-020.cisco.com ([64.101.220.160]) by XCH-RTP-020.cisco.com ([64.101.220.160]) with mapi id 15.00.1104.009; Mon, 18 Apr 2016 13:38:38 -0400
From: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
To: Pete Resnick <presnick@qti.qualcomm.com>
Thread-Topic: Gen-ART LC review of draft-ietf-ospf-sbfd-discriminator-04
Thread-Index: AQHRmYzEAI6OedVcYkC65TRwJwyDGJ+QQj4A
Date: Mon, 18 Apr 2016 17:38:38 +0000
Message-ID: <D631F49E-D979-40BA-A16C-B5A7D9417D02@cisco.com>
References: <262CC2D9-1F83-45BB-8DA4-0FC70FAE88B4@qti.qualcomm.com>
In-Reply-To: <262CC2D9-1F83-45BB-8DA4-0FC70FAE88B4@qti.qualcomm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.117.115.53]
Content-Type: multipart/signed; boundary="Apple-Mail=_A6D988E2-6B39-46BA-80B8-FF83BC690422"; protocol="application/pgp-signature"; micalg=pgp-sha256
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/ospf/0IL_CId5w8WZANSZV-7_-421yk0>
Cc: "draft-ietf-ospf-sbfd-discriminator.all@ietf.org" <draft-ietf-ospf-sbfd-discriminator.all@ietf.org>, "ospf@ietf.org" <ospf@ietf.org>, General Area Review Team <gen-art@ietf.org>
Subject: Re: [OSPF] Gen-ART LC review of draft-ietf-ospf-sbfd-discriminator-04
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Apr 2016 17:38:48 -0000

Hi, Pete,

Many thanks for your review.

Good catches, I agree with the three editorial suggestions below. I’ve made these changes in our working copy.

Thanks,

— Carlos.

> On Apr 18, 2016, at 12:09 PM, Pete Resnick <presnick@qti.qualcomm.com> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <​http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq%3E>.
> 
> Document: draft-ietf-ospf-sbfd-discriminator-04
> Reviewer: Pete Resnick
> Review Date: 2016-04-18
> IETF LC End Date: 2016-04-26
> IESG Telechat date: 2016-05-05
> 
> Summary: This draft is ready for publication as a Proposed Standard RFC.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments: Two clarifications, one typo:
> 
> 2.1:
> 
> OLD
> Type - S-BFD Discriminator TLV Type
> NEW
> Type - S-BFD Discriminator TLV Type (TBD [to be filled in by IANA])
> END
> 
> OLD
> Length - Total length of the discriminator (Value field) in octets,
> not including the optional padding. The Length is a multiple of 4
> octets, and consequently specifies how many Discriminators are
> included in the TLV.
> NEW
> Length - Total length of the discriminator(s) that appear in the
> Value field, in octets. Each discriminator is 4 octets, so the Length
> is 4 times the number of Discriminators included in the TLV. There is
> no optional padding for this field.
> END
> 
> 2.2:
> 
> OLD
> Note that the S-BFD session may be required to pan multiple areas
> NEW
> Note that the S-BFD session may be required to span multiple areas
> END
> 
> --
> Pete Resnick http://www.qualcomm.com/~presnick/ <http://www.qualcomm.com/%7Epresnick/>
> Qualcomm Technologies, Inc. - +1 (858)651-4478
>