Re: [OSPF] Opsdir telechat review of draft-ietf-ospf-link-overload-13

Shraddha Hegde <shraddha@juniper.net> Wed, 31 January 2018 03:47 UTC

Return-Path: <shraddha@juniper.net>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D986B1314D2; Tue, 30 Jan 2018 19:47:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iZKex82i-EgE; Tue, 30 Jan 2018 19:47:28 -0800 (PST)
Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E6B41314D3; Tue, 30 Jan 2018 19:47:27 -0800 (PST)
Received: from pps.filterd (m0108159.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0V3iFSI001558; Tue, 30 Jan 2018 19:47:26 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=PPS1017; bh=oEerImqm1ytSJEt1cDzseTLefhyjwPVcO6wODHNhzkQ=; b=vv4kaZJ05/Z3vxDY3rNN21tHua9sKl8cI7xP2WBX12X9Drvf7/OtN57FzgO+ieP7CNdz jHLrQNuSHowlQLO8HNr2tNI7RijTFLHFPsP1KFjs7X0sBpOhd6bioXgg0CJ3gVqE7v2t rHrfasKYU3FTay2VC7L8kwApto+wkwVTEb+Oc0XUiDiSKbMA0rr5zwBiZRkmEapp0/XW 6Px954/fBerBkYSTO9FZAhblQhITTt6/IoyxmRYP/PjEBpOLQLMagXO1Aqe3u3ToYJN1 ka9DluieAv1A65AdqoFGhwd6zlqFoPrLtDhP+cp6rvne2wMTxRtg9hwPcrQy16pi0V+9 Fw==
Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp0080.outbound.protection.outlook.com [207.46.163.80]) by mx0a-00273201.pphosted.com with ESMTP id 2fu2vgrgm9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 30 Jan 2018 19:47:26 -0800
Received: from BN3PR05MB2706.namprd05.prod.outlook.com (10.167.2.135) by BN3PR05MB2659.namprd05.prod.outlook.com (10.166.72.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.6; Wed, 31 Jan 2018 03:47:24 +0000
Received: from BN3PR05MB2706.namprd05.prod.outlook.com ([10.167.2.135]) by BN3PR05MB2706.namprd05.prod.outlook.com ([10.167.2.135]) with mapi id 15.20.0464.012; Wed, 31 Jan 2018 03:47:24 +0000
From: Shraddha Hegde <shraddha@juniper.net>
To: Tim Chown <tim.chown@jisc.ac.uk>, "ops-dir@ietf.org" <ops-dir@ietf.org>
CC: "ospf@ietf.org" <ospf@ietf.org>, "draft-ietf-ospf-link-overload.all@ietf.org" <draft-ietf-ospf-link-overload.all@ietf.org>
Thread-Topic: Opsdir telechat review of draft-ietf-ospf-link-overload-13
Thread-Index: AQHTk5D/vr1aZFLMtkGlWxQhTnyUfqONZJYQ
Date: Wed, 31 Jan 2018 03:47:24 +0000
Message-ID: <BN3PR05MB27068B26494349744FDC219DD5FB0@BN3PR05MB2706.namprd05.prod.outlook.com>
References: <151663290487.7984.12317518080423140763@ietfa.amsl.com>
In-Reply-To: <151663290487.7984.12317518080423140763@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [116.197.184.14]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BN3PR05MB2659; 7:aM/MjVQ7LZjNrthGlQn2O518jGC4fW04jOxDW470tpXHztQ0vUCC1ya8azbEFE8K9sIhAG9Q51xGK3vk3mb2Ux1yDW5T3lFiBMF8E4M0U+41EJkcKNvtP4ZvflFwBSuP64kOb/rCd8PHFRFuD2+llhKNNn9gq71R1HIwOgAl6W+PMRkKe9rrSreJro8vaiB9jDfL/CIloD4tEPhIs7iyL7b/05HMZVHdjj713CJz3E8qHAoMrV2Gs3WPni0CoZTu
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: a13ee37b-d6aa-4910-d632-08d5685d5708
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:BN3PR05MB2659;
x-ms-traffictypediagnostic: BN3PR05MB2659:
x-microsoft-antispam-prvs: <BN3PR05MB26599657F55A52741B7C658ED5FB0@BN3PR05MB2659.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(274715658323672);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231101)(2400082)(944501161)(93006095)(93001095)(6055026)(6041288)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:BN3PR05MB2659; BCL:0; PCL:0; RULEID:; SRVR:BN3PR05MB2659;
x-forefront-prvs: 056929CBB8
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(346002)(39380400002)(366004)(396003)(376002)(51914003)(199004)(13464003)(189003)(6436002)(2950100002)(97736004)(110136005)(55016002)(9686003)(99286004)(25786009)(54906003)(229853002)(4326008)(3280700002)(76176011)(7696005)(8936002)(6116002)(3846002)(2906002)(53936002)(316002)(105586002)(77096007)(81166006)(2900100001)(74316002)(6506007)(6246003)(26005)(7736002)(86362001)(186003)(53546011)(66066001)(3660700001)(68736007)(14454004)(81156014)(33656002)(102836004)(5660300001)(8676002)(478600001)(305945005)(59450400001)(106356001)(2501003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR05MB2659; H:BN3PR05MB2706.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
x-microsoft-antispam-message-info: Lvo168Kyg/3w4ajLdN/o6i9hpZ4iqqRAxKY/6YAsNIzjXqkP4izS2glTYdw7p7Gq2sl+eWkIkUWa5EQcuGotfw==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-Network-Message-Id: a13ee37b-d6aa-4910-d632-08d5685d5708
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2018 03:47:24.3456 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR05MB2659
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-01-31_01:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801310046
Archived-At: <https://mailarchive.ietf.org/arch/msg/ospf/5WJOMw2MSqrzVRAyuPy3HjhK0eU>
Subject: Re: [OSPF] Opsdir telechat review of draft-ietf-ospf-link-overload-13
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2018 03:47:31 -0000

Tim,

Thanks for the review and comments.
Pls see inline for responses.

-----Original Message-----
From: Tim Chown [mailto:tim.chown@jisc.ac.uk] 
Sent: Monday, January 22, 2018 8:25 PM
To: ops-dir@ietf.org
Cc: ospf@ietf.org; draft-ietf-ospf-link-overload.all@ietf.org
Subject: Opsdir telechat review of draft-ietf-ospf-link-overload-13

Reviewer: Tim Chown
Review result: Ready

Hi,

I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review. Document editors and WG chairs should treat these comments just like any other last call comments.

This document defines mechanism(s) to allow OSPF routers to indicate that a specific link, rather than a whole node, is entering an imminent maintenance state, to allow other devices that understand the protocol extension(s) to more gracefully re-route traffic around the affected link.

I believe the document is Ready for publication.  I have only three minor comments below, which the authors may choose to act on.

Overall the document reads reasonably well. Not being overly familiar with the material, I needed to read it through end-to-end more than once to better understand its scope and intent. My first comment would be that perhaps the introduction section could be better written; the abstract seemed clear on the purpose of the draft, while the introduction felt a little muddled.  Sections 2, 3 and 4, which detail the motivations and extensions, were much clearer.
<Shraddha> Added more text to introduction section in version -14. Pls check if it looks better now.

Secondly, there are some minor typographic errors throughout the document, generally missing (in)definite articles.  While the RFC Editor would pick these up, it would be nice for the authors to have a final pass and fix those before submission.
<Shraddha> Ack. 

Thirdly, the document does not give any advice on the timing of using the extensions - how far in advance is it recommended to use the extensions? - or on the return to 'normal' state once the maintenance is completed.  So perhaps consider adding a short section on this, maybe in Section 5.
<Shraddha> Added below details to section 5

 When a link is ready to carry traffic, the Graceful-Lnk-Shutdown sub-TLV should be removed from the Extended Link TLV/Router-Link TLV and the corresponding
LSAs MUST be readvertised.

Best wishes,
Tim