[OSPF] Gen-ART LC review of draft-ietf-ospf-sbfd-discriminator-04

Pete Resnick <presnick@qti.qualcomm.com> Mon, 18 April 2016 16:09 UTC

Return-Path: <presnick@qti.qualcomm.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 781FD12DFA8; Mon, 18 Apr 2016 09:09:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.996
X-Spam-Level:
X-Spam-Status: No, score=-7.996 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-0.996, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=qti.qualcomm.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u0zji6_C0tEm; Mon, 18 Apr 2016 09:09:48 -0700 (PDT)
Received: from wolverine01.qualcomm.com (wolverine01.qualcomm.com [199.106.114.254]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7E91212DA19; Mon, 18 Apr 2016 09:09:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1460995788; x=1492531788; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=fcZPYwZr3ct40ymmGR/6O5h5Bfa/ozBydwBivMDv3TY=; b=f0Vzu78P5kZmBA+OirNAwWFJ9qm/nW5jFzWhsbQUou8QSshQ6SAHAS4M PyymoyZ4ZRh6kRND1fPBwZCUOimct2JjXDTS4qbb6o0eDVV49BH8canms hmhOQE3gEN74SD1FNOTzAsrpf9iPlSvCAy7M+l6IM/aOtCHE0xpQL1FCK U=;
X-IronPort-AV: E=Sophos;i="5.24,503,1455004800"; d="scan'208,217";a="186274414"
Received: from unknown (HELO Ironmsg04-L.qualcomm.com) ([10.53.140.111]) by wolverine01.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Apr 2016 09:09:45 -0700
X-IronPort-AV: E=McAfee;i="5700,7163,8139"; a="1105112810"
Received: from nasanexm01f.na.qualcomm.com ([10.85.0.32]) by Ironmsg04-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 18 Apr 2016 09:09:44 -0700
Received: from [10.64.160.13] (10.80.80.8) by NASANEXM01F.na.qualcomm.com (10.85.0.32) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Mon, 18 Apr 2016 09:09:43 -0700
From: Pete Resnick <presnick@qti.qualcomm.com>
To: General Area Review Team <gen-art@ietf.org>, <draft-ietf-ospf-sbfd-discriminator.all@ietf.org>, <ospf@ietf.org>
Date: Mon, 18 Apr 2016 11:09:42 -0500
Message-ID: <262CC2D9-1F83-45BB-8DA4-0FC70FAE88B4@qti.qualcomm.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=_MailMate_2B7CCF8A-0CEE-4F01-8DEA-A34E58100ED7_="
Content-Transfer-Encoding: 8bit
X-Mailer: MailMate (1.9.4r5239)
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: NASANEXM01F.na.qualcomm.com (10.85.0.32) To NASANEXM01F.na.qualcomm.com (10.85.0.32)
Archived-At: <http://mailarchive.ietf.org/arch/msg/ospf/C7OCjT1d7KKJex-eWo-uRmQPKQU>
Subject: [OSPF] Gen-ART LC review of draft-ietf-ospf-sbfd-discriminator-04
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Apr 2016 16:09:50 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area 
Review Team (Gen-ART) reviews all IETF documents being processed by the 
IESG for the IETF Chair. Please treat these comments just like any other 
last call comments. For more information, please see the FAQ at 
<​http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-ospf-sbfd-discriminator-04
Reviewer: Pete Resnick
Review Date: 2016-04-18
IETF LC End Date: 2016-04-26
IESG Telechat date: 2016-05-05

Summary: This draft is ready for publication as a Proposed Standard RFC.

Major issues: None

Minor issues: None

Nits/editorial comments: Two clarifications, one typo:

2.1:

OLD
    Type - S-BFD Discriminator TLV Type
NEW
    Type - S-BFD Discriminator TLV Type (TBD [to be filled in by IANA])
END

OLD
    Length - Total length of the discriminator (Value field) in octets,
    not including the optional padding.  The Length is a multiple of 4
    octets, and consequently specifies how many Discriminators are
    included in the TLV.
NEW
    Length - Total length of the discriminator(s) that appear in the
    Value field, in octets. Each discriminator is 4 octets, so the 
Length
    is 4 times the number of Discriminators included in the TLV. There 
is
    no optional padding for this field.
END

2.2:

OLD
    Note that the S-BFD session may be required to pan multiple areas
NEW
    Note that the S-BFD session may be required to span multiple areas
END

-- 
Pete Resnick <http://www.qualcomm.com/~presnick/>
Qualcomm Technologies, Inc. - +1 (858)651-4478