Re: [OSPF] 答复: Benoit Claise's Discuss on draft-ietf-ospf-encapsulation-cap-06: (with DISCUSS and COMMENT)

Benoit Claise <bclaise@cisco.com> Mon, 11 September 2017 10:20 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 41AC2133031; Mon, 11 Sep 2017 03:20:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.499
X-Spam-Level:
X-Spam-Status: No, score=-14.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3x5Uad9wwWOB; Mon, 11 Sep 2017 03:19:58 -0700 (PDT)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 87820128D0D; Mon, 11 Sep 2017 03:19:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=22198; q=dns/txt; s=iport; t=1505125198; x=1506334798; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to; bh=mdlUmQvzV+YFgb/YACIasHykKP9r5RPrJoo/XWxFj0s=; b=IFQMC8bJuWcEQOfMzzpbgIsb58qKqUWSWLyXiDSivwO/7QwuVgErPMRk Qef0PQ7leUDI9uY9/HXfFEZY8sKI7hWjwg0YhE0E1iCciwY6Q+KraLnJf dPk4BFlv9yo4vHkXrCocErsbgyZUh9+qHkvE+FCDoHyuIN9kujUuNwwzg 4=;
X-IronPort-AV: E=Sophos;i="5.42,377,1500940800"; d="scan'208,217";a="655553786"
Received: from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2017 10:19:55 +0000
Received: from [10.55.221.36] (ams-bclaise-nitro3.cisco.com [10.55.221.36]) by aer-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id v8BAJtUh030491; Mon, 11 Sep 2017 10:19:55 GMT
To: Xuxiaohu <xuxiaohu@huawei.com>, The IESG <iesg@ietf.org>
Cc: "tjw.ietf@gmail.com" <tjw.ietf@gmail.com>, "ospf@ietf.org" <ospf@ietf.org>, "acee@cisco.com" <acee@cisco.com>, "ospf-chairs@ietf.org" <ospf-chairs@ietf.org>, "draft-ietf-ospf-encapsulation-cap@ietf.org" <draft-ietf-ospf-encapsulation-cap@ietf.org>
References: <150407984152.21582.13499330365584334713.idtracker@ietfa.amsl.com> <567c98a4-3105-ccdf-f8e9-4aa082bf7b28@cisco.com> <1FEE3F8F5CCDE64C9A8E8F4AD27C19EE2BC10CC9@NKGEML515-MBX.china.huawei.com>
From: Benoit Claise <bclaise@cisco.com>
Message-ID: <e7797329-78e9-00c8-977d-fb280eb74518@cisco.com>
Date: Mon, 11 Sep 2017 12:19:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1FEE3F8F5CCDE64C9A8E8F4AD27C19EE2BC10CC9@NKGEML515-MBX.china.huawei.com>
Content-Type: multipart/alternative; boundary="------------9BEB58B1310FC8E8ACEEEEFC"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/ospf/DT9nXJAefC3FN-HGT5xlCR2EqR0>
Subject: Re: [OSPF] 答复: Benoit Claise's Discuss on draft-ietf-ospf-encapsulation-cap-06: (with DISCUSS and COMMENT)
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 10:20:01 -0000

Hi Xiaohu,

My DISCUSS is at 
https://datatracker.ietf.org/doc/draft-ietf-ospf-encapsulation-cap/ballot/
Let me try to rephrase the second DISCUSS point.
The following sentence is so generic

       Value (variable): Zero or more Tunnel Encapsulation Attribute Sub-
       TLVs as defined in Section 5.

Basically, it says: you can receive 0, 1, or more instance of

           0    Reserved               This document
           1    Encapsulation          This document & [I-D.ietf-idr-tunnel-encaps]
           2    Protocol Type          This document & [I-D.ietf-idr-tunnel-encaps]
           3    Endpoint               This document
           4    Color                  This document
           5    Load-Balancing Block   This document & [RFC5640]
           6    IP QoS                 This document & [I-D.ietf-idr-tunnel-encaps]
           7    UDP Destination Port   This document & [I-D.ietf-idr-tunnel-encaps]
     8-65499    Unassigned
65500-65534    Experimental           This document
       65535    Reserved               This document

And my question/point: really, you want to be that open/liberal in terms 
of Tunnel Encapsulation Attribute Sub-TLVs?
You have really no rules? What if some combinations don't even make sense?

     None of sub-TLVs are compulsory? Not even the Endpoint?
     What does a Color mean without an Endpoint?
     What do two IP QoS mean?
     What do two Endpoints mean?
     What do two different IP QoS with two different Endpoints mean?
     etc...

I wonder how you could inter-operate?

Regards, Benoit
> Hi Benoit,
>
> The Tunnel Encapsulation Capabilities TLV contains one or more Tunnel Encapsulation Type Sub-TLVs which in turn contain Zero or more Tunnel Encapsulation Attribute Sub-TLVs. More specifically, the intent of Tunnel Encapsulation Attribute Sub-TLVs contained in a given Tunnel Encapsulation Type Sub-TLV is to describe the specific parameters to be used for the tunnel indicated by the Type of that Tunnel Encapsulation Type Sub-TLV.
>
> I wonder whether I have understood your points correctly.
>
> Best regards,
> Xiaohu
>
>> -----邮件原件-----
>> 发件人: Benoit Claise [mailto:bclaise@cisco.com]
>> 发送时间: 2017年9月11日 15:39
>> 收件人: The IESG
>> 抄送: tjw.ietf@gmail.com; ospf@ietf.org; acee@cisco.com; ospf-chairs@ietf.org;
>> draft-ietf-ospf-encapsulation-cap@ietf.org
>> 主题: Re: Benoit Claise's Discuss on draft-ietf-ospf-encapsulation-cap-06: (with
>> DISCUSS and COMMENT)
>>
>> Dear authors,
>>
>> I see that a new version has been posted.
>> Can you let me know how my DISCUSS point 2 has been addressed?
>>
>> Regards, Benoit
>>> Benoit Claise has entered the following ballot position for
>>> draft-ietf-ospf-encapsulation-cap-06: Discuss
>>>
>>> When responding, please keep the subject line intact and reply to all
>>> email addresses included in the To and CC lines. (Feel free to cut
>>> this introductory paragraph, however.)
>>>
>>>
>>> Please refer to
>>> https://www.ietf.org/iesg/statement/discuss-criteria.html
>>> for more information about IESG DISCUSS and COMMENT positions.
>>>
>>>
>>> The document, along with other ballot positions, can be found here:
>>> https://datatracker.ietf.org/doc/draft-ietf-ospf-encapsulation-cap/
>>>
>>>
>>>
>>> ----------------------------------------------------------------------
>>> DISCUSS:
>>> ----------------------------------------------------------------------
>>>
>>> 1. I agree with Tim Wicinski's OPS DIR point about IANA.
>>>
>>>       The content appears to be fine, but there are some outdated (the
>> biggest
>>>       one is 5226 replaced by 8126), but its the IANA section which appears
>> the
>>>       most confusing.
>>>
>>>       7.1 OSPF Router Information (RI) Registry -  appears fine
>>>
>>>       7.2 OSPF Tunnel Encapsulation Attribute Sub-TLV Registry
>>>
>>>       This one defines the values being defined/allocated from "This
>> Document"
>>>       but in Section 5, each Sub-TLV is defined in other documents, so it's
>>>       totally confusing.
>>>
>>> 2. It's not clear which of the following sub-TLVs are
>>> required/relevant/interconnected in the Encapsulation Capability TLV
>>>
>>>               0    Reserved                                  This
>> document
>>>               1    Encapsulation                             This
>> document
>>>               2    Protocol Type                             This
>> document
>>>               3    Endpoint                                  This
>> document
>>>               4    Color                                     This
>> document
>>>               5    Load-Balancing Block                      This
>> document
>>>               6    IP QoS                                    This
>> document
>>>               7    UDP Destination Port                      This
>> document
>>> The only hint is:
>>>
>>>         Value (variable): Zero or more Tunnel Encapsulation Attribute Sub-
>>>         TLVs as defined in Section 5.
>>>
>>> Zero? really, what's the point?
>>> Now, from an operational point of view, which sub-TLVs are required/make
>> sense?
>>> Are some sub-TLVs irrelevant without others? Ex: Color without
>>> Encapsulation Could we have multiple identical sub-TLVs? Ex: Color
>>>
>>>
>>> ----------------------------------------------------------------------
>>> COMMENT:
>>> ----------------------------------------------------------------------
>>>
>>> - Sometimes you use "Encapsulation Capability TLV" (section 3),
>>> sometimes "The Tunnel Encapsulation Type Sub-TLV" I guess that: OLD:
>>>
>>>    The Tunnel Encapsulation Type Sub-TLV is structured as follows:
>>>
>>>          0                   1                   2
>> 3
>>>          0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>>>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>         |    Tunnel Type (2 Octets)     |        Length (2 Octets)
>> |
>>>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>         |
>> |
>>>         |                            Sub-TLVs
>> |
>>>         |
>> |
>>> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>
>>> NEW:
>>>    The Encapsulation Capability TLV is structured as follows:
>>>
>>>          0                   1                   2
>> 3
>>>          0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>>>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>         |    Tunnel Type (2 Octets)     |        Length (2 Octets)
>> |
>>>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>         |
>> |
>>>         |                            Sub-TLVs
>> |
>>>         |
>> |
>>> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>
>>> In section 7.1, should it be?
>>> OLD:
>>>       Value   TLV Name                                  Reference
>>>          -----   ------------------------------------   -------------
>>>          TBD1    Tunnel Capabilities                    This document
>>>
>>> NEW:
>>>       Value   TLV Name                                  Reference
>>>          -----   ------------------------------------   -------------
>>>          TBD1    Encapsulation Capabilities             This document
>>>
>>> OR:
>>>       Value   TLV Name                                  Reference
>>>          -----   ------------------------------------   -------------
>>>          TBD1    Tunnel Encapsulation Capabilities      This document
>>>
>>> - Then there is a discrepancy between Sub-TLVs and Value in the
>>> related text
>>>
>>>          0                   1                   2
>> 3
>>>          0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>>>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>         |    Tunnel Type (2 Octets)     |        Length (2 Octets)
>> |
>>>         +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>         |
>> |
>>>         |                            Sub-TLVs
>> |
>>>         |
>> |
>>> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>>
>>> Proposal: Sub-TLVs should be replaced by "Tunnel Encapsulation
>>> Attribute Sub-TLVs", and the following text updated:
>>>
>>>     Value (variable): Zero or more Tunnel Encapsulation Attribute Sub-
>>>         TLVs as defined in Section 5.
>>>
>>> - Then, reading section 5, I see yet another name: "OSPF Tunnel
>>> Encapsulation Attribute Sub-TLVs" Section 7.2.
>>>
>>> You should re-read the document to be consistent with your naming
>>> convention, in the text and in the IANA sections.
>>>
>>>
>>> .
>>>