Re: [OSPF] Opsdir telechat review of draft-ietf-ospf-link-overload-13

Tim Chown <Tim.Chown@jisc.ac.uk> Wed, 31 January 2018 09:33 UTC

Return-Path: <tim.chown@jisc.ac.uk>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 517BC131726 for <ospf@ietfa.amsl.com>; Wed, 31 Jan 2018 01:33:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.32
X-Spam-Level:
X-Spam-Status: No, score=-4.32 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=jisc.ac.uk
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uN9nnUmQIXYq for <ospf@ietfa.amsl.com>; Wed, 31 Jan 2018 01:33:51 -0800 (PST)
Received: from eu-smtp-delivery-189.mimecast.com (eu-smtp-delivery-189.mimecast.com [146.101.78.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02CD71316C4 for <ospf@ietf.org>; Wed, 31 Jan 2018 01:33:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jisc.ac.uk; s=mimecast20170213; t=1517391191; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references; bh=uODRSGiSWs40o9pzopT35nmwfqrtV7h++RYVVP+hx0M=; b=DnDl0X1EAgYTmNOicBITxP2ASz2a4AmQzaferav+X3uGQ8TJ0E/bN+uDU0jpujPat/2s4kZc5d39X3TOpkvLE/Dcr9PzeLoC8vvJLuZeAWTRjf4/2vDnQgnHd1hBa85tAoucDpcxf90mJ/+OUfcztHTUYite+w5l0GjiSHjRBAQ=
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp0207.outbound.protection.outlook.com [213.199.154.207]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-5-d1l_KSIpO-2pjmG6e08IsA-1; Wed, 31 Jan 2018 09:33:07 +0000
Received: from VI1PR07MB1151.eurprd07.prod.outlook.com (10.163.168.148) by VI1PR07MB1215.eurprd07.prod.outlook.com (10.163.169.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.6; Wed, 31 Jan 2018 09:33:02 +0000
Received: from VI1PR07MB1151.eurprd07.prod.outlook.com ([fe80::9dcf:98c2:11a9:5271]) by VI1PR07MB1151.eurprd07.prod.outlook.com ([fe80::9dcf:98c2:11a9:5271%14]) with mapi id 15.20.0464.008; Wed, 31 Jan 2018 09:33:02 +0000
From: Tim Chown <Tim.Chown@jisc.ac.uk>
To: Shraddha Hegde <shraddha@juniper.net>
CC: "ops-dir@ietf.org" <ops-dir@ietf.org>, "ospf@ietf.org" <ospf@ietf.org>, "draft-ietf-ospf-link-overload.all@ietf.org" <draft-ietf-ospf-link-overload.all@ietf.org>
Thread-Topic: Opsdir telechat review of draft-ietf-ospf-link-overload-13
Thread-Index: AQHTmkr/++UxNEPImkKdcM7ntynAGqONuGOA
Date: Wed, 31 Jan 2018 09:33:02 +0000
Message-ID: <8F9D719B-3858-4B10-906A-161DA44C5526@jisc.ac.uk>
References: <151663290487.7984.12317518080423140763@ietfa.amsl.com> <BN3PR05MB27068B26494349744FDC219DD5FB0@BN3PR05MB2706.namprd05.prod.outlook.com>
In-Reply-To: <BN3PR05MB27068B26494349744FDC219DD5FB0@BN3PR05MB2706.namprd05.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3445.5.20)
x-originating-ip: [194.82.140.195]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB1215; 7:6U5VCe1oGwFn8t8w5q5gz4RJaVpCAmkjIpVXvzE+9lce/h3NejEfwT1rG+D2yiY8kWamU8y9/ucP2EINuqtob8Rq4Pn/eD49BmDuLzIlEUnevLhebxT00iWDKS2m1tUNV44TWGAEb1pRcYMn1539Rwp8LN82w+ECd5oHlkIJXbAoEQeZqc9ZCxWZcR92uZS1gZzaXwq6gLCi1j3mrO2Z3v82wRpWnahj+8lAiqU59CChMAurUbJ7eTw1UT56awzD; 20:y8BDfiWqjjV4PcVm9nInIYenH4tdPzM2r5bgKoIZxyA/Tht8mz5rU0LQB7bi3URnhv5HCF1no8JxwiTL/NNcz9daWsqAFlxW+7grYqh+n4/74TlobfwJ+8HjWaPdf+7IgbCWjQRoz3+/q7f29QIJs48rOF5yUZ9iytb2Mausqdw=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: 04df1e0e-388c-41b9-e47f-08d5688d9fca
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR07MB1215;
x-ms-traffictypediagnostic: VI1PR07MB1215:
x-microsoft-antispam-prvs: <VI1PR07MB1215958A678156CF4374AB1ED6FB0@VI1PR07MB1215.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(274715658323672)(138986009662008);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(2400082)(944501161)(93006095)(93001095)(3002001)(6041288)(20161123558120)(20161123560045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR07MB1215; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB1215;
x-forefront-prvs: 056929CBB8
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(366004)(39850400004)(39380400002)(346002)(189003)(199004)(13464003)(51914003)(6246003)(8666007)(7736002)(82746002)(36756003)(6512007)(99286004)(3660700001)(1941001)(6436002)(305945005)(3280700002)(6486002)(83716003)(229853002)(105586002)(68736007)(4326008)(786003)(316002)(54906003)(102836004)(5250100002)(14454004)(66066001)(53546011)(97736004)(25786009)(5660300001)(8676002)(81166006)(2900100001)(26005)(57306001)(59450400001)(186003)(478600001)(8936002)(86362001)(2906002)(3846002)(50226002)(6916009)(2950100002)(106356001)(6116002)(81156014)(53936002)(33656002)(74482002)(42882006)(6506007)(76176011)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB1215; H:VI1PR07MB1151.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
x-microsoft-antispam-message-info: owbgtyTFjErwWw95Zu6p6jpcHX+sNVepv1PpaJFRZTcdyGG1V/9Du/LGk8sITq7WD93xN9DgsDrJR5CSzJxe0Q==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-ID: <9F07C8D951DAF847A6B95813562906C9@eurprd07.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: jisc.ac.uk
X-MS-Exchange-CrossTenant-Network-Message-Id: 04df1e0e-388c-41b9-e47f-08d5688d9fca
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2018 09:33:02.2563 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 48f9394d-8a14-4d27-82a6-f35f12361205
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB1215
X-MC-Unique: d1l_KSIpO-2pjmG6e08IsA-1
Content-Type: text/plain; charset="WINDOWS-1252"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/ospf/MNOgbYvLYp9ctb5qTCh9avTGjNc>
Subject: Re: [OSPF] Opsdir telechat review of draft-ietf-ospf-link-overload-13
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2018 09:33:55 -0000

Hi,

My comments 2 and 3 are covered, thanks.

My first comment, that the introduction section is rather muddled / unclear, still holds. I don't see that this has been changed; I think all the text is in there, it just doesn't flow well (to me).  Whether you change it, is up to you. I'd suggest if you do change it that the structure covers: the problem, the current tools that can be used, why/where those tools do not solve the problem, and then the solution defined in the document.

Best wishes,
Tim 

> On 31 Jan 2018, at 03:47, Shraddha Hegde <shraddha@juniper.net> wrote:
> 
> Tim,
> 
> Thanks for the review and comments.
> Pls see inline for responses.
> 
> -----Original Message-----
> From: Tim Chown [mailto:tim.chown@jisc.ac.uk] 
> Sent: Monday, January 22, 2018 8:25 PM
> To: ops-dir@ietf.org
> Cc: ospf@ietf.org; draft-ietf-ospf-link-overload.all@ietf.org
> Subject: Opsdir telechat review of draft-ietf-ospf-link-overload-13
> 
> Reviewer: Tim Chown
> Review result: Ready
> 
> Hi,
> 
> I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review. Document editors and WG chairs should treat these comments just like any other last call comments.
> 
> This document defines mechanism(s) to allow OSPF routers to indicate that a specific link, rather than a whole node, is entering an imminent maintenance state, to allow other devices that understand the protocol extension(s) to more gracefully re-route traffic around the affected link.
> 
> I believe the document is Ready for publication.  I have only three minor comments below, which the authors may choose to act on.
> 
> Overall the document reads reasonably well. Not being overly familiar with the material, I needed to read it through end-to-end more than once to better understand its scope and intent. My first comment would be that perhaps the introduction section could be better written; the abstract seemed clear on the purpose of the draft, while the introduction felt a little muddled.  Sections 2, 3 and 4, which detail the motivations and extensions, were much clearer.
> <Shraddha> Added more text to introduction section in version -14. Pls check if it looks better now.
> 
> Secondly, there are some minor typographic errors throughout the document, generally missing (in)definite articles.  While the RFC Editor would pick these up, it would be nice for the authors to have a final pass and fix those before submission.
> <Shraddha> Ack. 
> 
> Thirdly, the document does not give any advice on the timing of using the extensions - how far in advance is it recommended to use the extensions? - or on the return to 'normal' state once the maintenance is completed.  So perhaps consider adding a short section on this, maybe in Section 5.
> <Shraddha> Added below details to section 5
> 
> When a link is ready to carry traffic, the Graceful-Lnk-Shutdown sub-TLV should be removed from the Extended Link TLV/Router-Link TLV and the corresponding
> LSAs MUST be readvertised.
> 
> Best wishes,
> Tim
> 
>