Re: [OSPF] Genart telechat review of draft-ietf-ospf-link-overload-10

Shraddha Hegde <shraddha@juniper.net> Tue, 02 January 2018 04:51 UTC

Return-Path: <shraddha@juniper.net>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9E373126C2F; Mon, 1 Jan 2018 20:51:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KoPgTNlnYXrZ; Mon, 1 Jan 2018 20:51:26 -0800 (PST)
Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A6A7712025C; Mon, 1 Jan 2018 20:51:23 -0800 (PST)
Received: from pps.filterd (m0108159.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w024nUQN010454; Mon, 1 Jan 2018 20:51:22 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=PPS1017; bh=0dCr0mhCMkaFtW4QCnaMZdOP47pigm+pYKvliwjVn4I=; b=MKkOhGAaKQ7eMmgSRIBl/BbTmkz7JTbdpk2LIEPFuYEV49t5wZdpWD4L8dQSBvJyXK07 gpGwH759WqdOwkrOH1kD5RpFDoDBEhcibqlZyQN7X0jvYyfCI6R0gIkX1G+Sb4Ui0oy8 l6zT81L43Ffq2Fryshw/DvmELatOXaJ4yVVlNr6ONJ9eQ8dv5iuC4jA/7ok6AZI1atRZ cp8JHkX5CxglhA/GMmTmzKW2V1b5U0mQZFDRGMhH1ZGsbo1FD9aIdbppbEvnKhOjdWlh amPC1WUaydRglyXcHXw17mvUWvPfZ2jyXKukkOQGeXLhZb/h6cQhNB7rxCmcokeF8h+i cg==
Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp0021.outbound.protection.outlook.com [216.32.180.21]) by mx0a-00273201.pphosted.com with ESMTP id 2f7psgrrx2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 01 Jan 2018 20:51:21 -0800
Received: from CY1PR05MB2714.namprd05.prod.outlook.com (10.167.18.8) by CY1PR05MB2716.namprd05.prod.outlook.com (10.167.18.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.2; Tue, 2 Jan 2018 04:51:20 +0000
Received: from CY1PR05MB2714.namprd05.prod.outlook.com ([10.167.18.8]) by CY1PR05MB2714.namprd05.prod.outlook.com ([10.167.18.8]) with mapi id 15.20.0302.007; Tue, 2 Jan 2018 04:51:19 +0000
From: Shraddha Hegde <shraddha@juniper.net>
To: Joel Halpern <jmh@joelhalpern.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "ospf@ietf.org" <ospf@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-ospf-link-overload.all@ietf.org" <draft-ietf-ospf-link-overload.all@ietf.org>
Thread-Topic: Genart telechat review of draft-ietf-ospf-link-overload-10
Thread-Index: AQHTerQxFF0vuuv8ckaXUO8eGDR6KKNgEpWQ
Date: Tue, 02 Jan 2018 04:51:19 +0000
Message-ID: <CY1PR05MB271449E3929B434FE0979D89D5190@CY1PR05MB2714.namprd05.prod.outlook.com>
References: <151389924330.28066.4179341895130268032@ietfa.amsl.com>
In-Reply-To: <151389924330.28066.4179341895130268032@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [116.197.184.10]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; CY1PR05MB2716; 7:e5HXKLmoeMZFKmlu9TdKCppBL9d7osgPiE7f11eW3myy0qLcsYo6UbjHL92YCHM7B8/U99ZXiaw6s2RWChIp/jVejLIkB1VLCpmmW1FhDhL7nwAQUwJcOLuyCz1WSa2iBA9YhKE7E5JQmpXBkdm/CWNxqHFrAbwBtURKH4aTW/6WaN25dLtDiA21tr4rGx8iq6IB+LcZs5CieEK8dCmru8MJGqRc3OR2l0/NPFmQ8n63HJTZCbI+/KFXFNE9XEzD
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: eca58cfe-99ea-4502-af16-08d5519c7720
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020020)(48565401081)(4534040)(4602075)(4627136)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060); SRVR:CY1PR05MB2716;
x-ms-traffictypediagnostic: CY1PR05MB2716:
x-microsoft-antispam-prvs: <CY1PR05MB2716210CE1E90BDF52AF6628D5190@CY1PR05MB2716.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(10436049006162);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(3002001)(93006095)(93001095)(6055026)(6041268)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY1PR05MB2716; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR05MB2716;
x-forefront-prvs: 0540846A1D
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(396003)(346002)(39860400002)(376002)(366004)(199004)(189003)(51914003)(13464003)(377424004)(5660300001)(53936002)(8676002)(6116002)(316002)(86362001)(3846002)(66066001)(3660700001)(4001150100001)(53546011)(74316002)(81166006)(81156014)(2900100001)(7736002)(230783001)(59450400001)(2906002)(77096006)(54906003)(102836004)(478600001)(7696005)(14454004)(68736007)(99286004)(6506007)(97736004)(2501003)(4326008)(110136005)(106356001)(229853002)(6246003)(76176011)(105586002)(3280700002)(2950100002)(6306002)(6436002)(55016002)(8936002)(33656002)(305945005)(9686003)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR05MB2716; H:CY1PR05MB2714.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
x-microsoft-antispam-message-info: WMMmXWMZisX6UBZz1EqCPKjxrisUs4UnVcOjfZHryVrNnDDzljp0xSuNw9VrspoiPfChHVoDPhDHFZtWyNgQOA==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-Network-Message-Id: eca58cfe-99ea-4502-af16-08d5519c7720
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2018 04:51:19.7546 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR05MB2716
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-01-02_03:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801020072
Archived-At: <https://mailarchive.ietf.org/arch/msg/ospf/RSBEWXqCyCRwPwFReNtnT8Qt6YY>
Subject: Re: [OSPF] Genart telechat review of draft-ietf-ospf-link-overload-10
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jan 2018 04:51:29 -0000

Hi Joel,

Thanks for the detailed review and comments.
Pls see inline for replies.

Rgds
Shraddha

-----Original Message-----
From: Joel Halpern [mailto:jmh@joelhalpern.com] 
Sent: Friday, December 22, 2017 5:04 AM
To: gen-art@ietf.org
Cc: ospf@ietf.org; ietf@ietf.org; draft-ietf-ospf-link-overload.all@ietf.org
Subject: Genart telechat review of draft-ietf-ospf-link-overload-10

Reviewer: Joel Halpern
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

<https://urldefense.proofpoint.com/v2/url?u=https-3A__trac.ietf.org_trac_gen_wiki_GenArtfaq&d=DwICaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=NyjLsr7JA7mvpCJa0YmPdVKcmMXJ31bpbBaNqzCNrng&m=fPKCOPH32Vci8T4s7-Yd5jWslV2IjabEYm3R9_DaoFQ&s=NNAuYrMTe14MTajL9m6rdqAlGdBWqVvLAYWuh1dJW28&e=>.

Document: draft-ietf-ospf-link-overload-10
Reviewer: Joel Halpern
Review Date: 2017-12-21
IETF LC End Date: None
IESG Telechat date: 2018-01-25

Summary: This document is almost ready for publication as a Proposed Standard.

Major issues:
     If a remote IPv4 address is needed in some cases for link identification,
     then does it not follow that for IPv6 usage with OSPFv3, a remote IPv6
     address is also needed?
<Shraddha>OSPFv3 already has mechanisms to identify the remote side link as it already has
                      Interface-ID and Neighbor's Interface ID in its link description. I have added a detailed
                       Section 4.5 which describes the need for Remote-IPv4 address in OSPFv2 and also covers why its not needed for OSPFv3. Pls see revision -11 for details.

Minor issues:
    Why is the remote IPv4 address TLV being defined here?  It is not specific
    to link maintenance.  If this is the first place it is needed, could the
    text at least be clearer that this is a general purpose sub-TLV, not
    specific to the link maintenance indication?
<Shraddha> New section added with the reasoning as described above.

Nits/editorial comments:
    Given that this document specifically states that the problem to be solved
    is the desire to take a link out of service, I would strongly prefer that
    the option being defined by named to match the goal.  The link being
    modified is not overloaded.  Could this be renamed the link
    pending-maintenance indication or something along those lines?  I realize
    the working group knows what it means.  But the point of naming is so that
    folks looking later can understand or find the item.
<Shraddha> I think overload is common terminology used for maintenance operations. 
Similar feature for taking out Nodes from network is called "overload" in ISIS. The same feature 
Is called "stub router" in OSPF. "stub link" has a different meaning in OSPF so the best choice
Was to use "link-overload".