Re: [OSPF] AD review of draft-ietf-ospf-prefix-link-attr-06
Alia Atlas <akatlas@gmail.com> Sun, 02 August 2015 03:53 UTC
Return-Path: <akatlas@gmail.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3AE031A8A72; Sat, 1 Aug 2015 20:53:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.999
X-Spam-Level:
X-Spam-Status: No, score=-101.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8-WlxC-aB_-M; Sat, 1 Aug 2015 20:53:08 -0700 (PDT)
Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 096821A8A6B; Sat, 1 Aug 2015 20:53:08 -0700 (PDT)
Received: by oibn4 with SMTP id n4so56112724oib.3; Sat, 01 Aug 2015 20:53:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ccMUsGbASde9LxK2RgsPWLPNOIv13dVOvio6TjKkWTg=; b=NW2YZtyeej4jrx+0iHwSdmnCEnXrFenVAREg6uROZ/joBExsUbbUWYBZUQMJiTdKNp S9yPLNR68cSyLXjgGJBfLsO/38k++6Qa6TWcszISLGjd81TTG8M6rxVgLtJ0YbiE289a Zf2toNQjIkfBBfbfpPuKEKmxF4rwUNO8Y0AH2pNK4Br8NCfkfBatn2tlgkRViy84Kqr3 AM/kUI3GO0659k1jrWf49v1SQDI2cTvtvZDmgQ/O0FnCR6IIjp54GdtEmLgrbZsgF/CN ZEyaX0x//RNfeE7Wg+0z0/Xxk5dGDwVpVqOm2a8KzQ2A6uF5bRtNoBp0nb9eqVC8+j8l d9ZQ==
MIME-Version: 1.0
X-Received: by 10.202.87.22 with SMTP id l22mr10252579oib.91.1438487587551; Sat, 01 Aug 2015 20:53:07 -0700 (PDT)
Received: by 10.60.41.99 with HTTP; Sat, 1 Aug 2015 20:53:07 -0700 (PDT)
In-Reply-To: <0C25913C-059E-44B8-BEFE-2845482FE2BA@lindem.com>
References: <CAG4d1rfvc6NNO6cgX35Bo=+zA4K6dhL5bKkzL8ttuvCFxB2JSQ@mail.gmail.com> <D1E2B485.2A028%acee@cisco.com> <0C25913C-059E-44B8-BEFE-2845482FE2BA@lindem.com>
Date: Sat, 01 Aug 2015 23:53:07 -0400
Message-ID: <CAG4d1re+BonrE6dFvJQ+yP1aagcVP9mcxD2VNMzqjmgukr+z9g@mail.gmail.com>
From: Alia Atlas <akatlas@gmail.com>
To: Acee Lindem <acee.lindem@gmail.com>
Content-Type: multipart/alternative; boundary="001a113d6e42ab8202051c4bfd13"
Archived-At: <http://mailarchive.ietf.org/arch/msg/ospf/Uy1sBsc3o0DX6afrrAEUizofI58>
Cc: "draft-ietf-ospf-prefix-link-attr@ietf.org" <draft-ietf-ospf-prefix-link-attr@ietf.org>, OSPF List <ospf@ietf.org>
Subject: Re: [OSPF] AD review of draft-ietf-ospf-prefix-link-attr-06
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Aug 2015 03:53:11 -0000
Hi Acee, On Sat, Aug 1, 2015 at 6:51 PM, Acee Lindem <acee.lindem@gmail.com> wrote: > Hi Alia, > See a couple inlines. > > On Aug 1, 2015, at 5:54 PM, Acee Lindem (acee) <acee@cisco.com> wrote: > > Hi Alia, > Thanks for the review. > > From: Alia Atlas <akatlas@gmail.com> > Date: Thursday, July 30, 2015 at 2:22 PM > To: "draft-ietf-ospf-prefix-link-attr@ietf.org" < > draft-ietf-ospf-prefix-link-attr@ietf.org>, OSPF WG List <ospf@ietf.org>, > shraddha <shraddha@juniper.net> > Subject: AD review of draft-ietf-ospf-prefix-link-attr-06 > > As is customary, I have done my AD review > of draft-ietf-ospf-prefix-link-attr-06 before asking for IETF Last Call. > First, thank you very much for your hard work on this draft. It is lovely > to see needed work move quickly and have numerous interoperable > implementations. > > I do have a number of minor issues on the draft - but all on the level of > clarifications. Therefore, I have requested that IETF Last Call be > started. Assuming good responsiveness on the part of the authors, a > revised version that addresses my concerns can be on the IESG telechat on > August 20. > > I do note that there are 6 authors on this draft. Please provide input - > since I know that you all well aware that the limit is normally at most 5. > One can identify a primary editor or two. This isn't pure process; the > more authors listed on a draft, the longer it takes to handle AUTH48 - > particularly when some are not as involved and do not respond rapidly and > with full context. I make no judgement about the authors of this draft - > who have clearly moved from pulling out the idea into a stand-alone draft > and had a number of different implementations. > > > We’ve already made one pass on pruning the authors and since we are only > one over, I’d like to leave it as is. > > > > My review comments are below. Thanks again for your hard work in getting > this far! > > Minor issues: > > 1) On p. 6, it says " AF Address family for the prefix. Currently, the > only supported value is 0 for IPv4 unicast." Please clarify VERY > CLEARLY why this restriction exists. Not everyone reading this will > be familiar with support for IPv6 in various protocols and we are really > finally heading towards lots more IPv6. > > > I will clarify. There are basically two reasons. The first is that we > really didn’t want to specify more than was necessary in this base > document. The second is that we have OSPFv3 for IPv6. So, you may ask why > we have this at all. The reason is that we didn’t want to rule out > extension of OSPFv2 completely. > > > > > 2) On p. 6 and 8.: > "The Instance field is an arbitrary value used to maintain multiple > Extended Prefix Opaque LSAs. A maximum of 16777216 Extended Prefix > Opaque LSAs may be sourced by a single OSPF instance.": This doesn't > really give normative behavior. I assume that what you mean is that > the advertising router has a number space for the Instance which has > no significance outside of that advertising router and can have > arbitrary values allocated from it. Each of these LSAs is identified > uniquely by its Instance number. Please provide good text for what > MUST be done and indicate that the value may be used for tie-breaking > ("In this case, the Extended-Prefix-TLV in the Extended Prefix Opaque > LSA with the smallest Instance is used by receiving OSPFv2 Routers. ") > and there's an assumption that the values will be allocated from > smallest to largest. > > > I will clarify this. However, I don’t want to specify any assumption about > allocation. > > > > 3) On p. 6 for the Route Type, it would be useful to have a reference to > where these type values are pulled from. I'd also like to see some > text about whether other values could be valid in the future and how > so. For instance, I'm assuming that you are basically pulling the > values from the OSPFv2 Link State (LS) Type > ( > http://www.iana.org/assignments/ospfv2-parameters/ospfv2-parameters.xhtml#ospfv2-parameters-5 > ) > - so perhaps you could simply say so or clarify for what are valid > values. > > > Is there an example of referencing an IANA directory? I could also > reference RFC 2823 and RFC 3101 directly. > > > I am referencing this URL directly. Given all the YANG documents I’m > reviewing or even writing, this seems very natural ;^) > Sure - I was suggesting the name of the registry also. 4) On p. 9: For Link-Type, could you also put a reference to the IANA > registry? I'd prefer it to be clear that if (unlikely as it seems) > there were a new Link-Type added, it would apply here too. > > > Sure. We’ll do the same. > > > > 5) In Sec 5, pleaes add an RFC Editor note that Section 5 will be removed > upon publication. That's the intent wtih RFC 6982. Thanks for > including this section in the draft. If the information wants to move > to the OSPF WG wiki, that would give it a place to survive after this > draft is submitted to the RFC Editor. > > > Ok - I need to hunt down this OSPF Wiki we talked about in Prague as well. > > > > Nits: > > 6) In Sec 2, there's an "e.g., mapping server deployment". Could you add > a reference? This tells me nothing... > > > Sure - it is the segment routing architecture document. > > > > 7) In Sec 2, In the packet format, could you clarify Opaque type = 7? Same > for on p.8 for opaque type = 8 ? > > > Sure. > > > I guess you want me to reference the Opaque draft. We have early IANA > allocation for both these values but that will be completely irrelevant > once this is published. > Sure - it'd be nice to have a reference - but all I was asking was for the figure to be updated to show the value of the Opaque Type since it is known. Thanks, Alia > Thanks, > Acee > > > > > 8) Since you are creating the registry for the TLVs, please clearly state > that value 1 is being used earlier - instead of "suggested value" as > on p.9 > > > Sure. > > Thanks, > Acee > > > > Regards, > Alia > > _______________________________________________ > OSPF mailing list > OSPF@ietf.org > https://www.ietf.org/mailman/listinfo/ospf > > >
- [OSPF] AD review of draft-ietf-ospf-prefix-link-a… Alia Atlas
- Re: [OSPF] AD review of draft-ietf-ospf-prefix-li… Acee Lindem (acee)
- Re: [OSPF] AD review of draft-ietf-ospf-prefix-li… Alia Atlas
- Re: [OSPF] AD review of draft-ietf-ospf-prefix-li… Alia Atlas
- Re: [OSPF] AD review of draft-ietf-ospf-prefix-li… t.petch
- Re: [OSPF] AD review of draft-ietf-ospf-prefix-li… Acee Lindem (acee)