Re: [OSPF] Rtg Dir review of draft-ietf-ospf-sbfd-discriminator-04.txt

"Acee Lindem (acee)" <acee@cisco.com> Wed, 27 April 2016 13:48 UTC

Return-Path: <acee@cisco.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 82EEB12D1D3; Wed, 27 Apr 2016 06:48:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.517
X-Spam-Level:
X-Spam-Status: No, score=-15.517 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jV8-zyQCbhUV; Wed, 27 Apr 2016 06:48:40 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 417FB12D152; Wed, 27 Apr 2016 06:48:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=10880; q=dns/txt; s=iport; t=1461764920; x=1462974520; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=gCS6tuNkpO1xKA0eXAbCUQmLNoP5Z+v5YCEPc5xdacc=; b=gkxFoIGALqOdj6VM00bIqQFCCFJ6w5JSWedB9uNX4A7xNyHaCX0o0a/6 5HgLC/DAqh09xQRir9/F3xg9HlCU99pXFEoijvEBmxCQw25655TEb/FtB 4/S92f81UUZoCp9z4NHaW55Qw4RK4l/edakI1s2KkWSFLGhkk+j6yY8Zp 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0D3AQA0wiBX/4wNJK1UCoM4U30GuWYBD?= =?us-ascii?q?YF1FwuFbQIcgQ84FAEBAQEBAQFlJ4RCAQEEAQEBIBE6CxACAQgUBgImAgICJQs?= =?us-ascii?q?VEAEBBAENBYgqDrJvkTQBAQEBAQEBAQEBAQEBAQEBAQEBAQEVfIhugQKEFQQkg?= =?us-ascii?q?wCCVgWYEAGFe4gbgWdOg3+DKYU0jy8BHgEBQoNrbAEBh24/fwEBAQ?=
X-IronPort-AV: E=Sophos;i="5.24,541,1454976000"; d="scan'208";a="96160230"
Received: from alln-core-7.cisco.com ([173.36.13.140]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Apr 2016 13:48:38 +0000
Received: from XCH-RTP-012.cisco.com (xch-rtp-012.cisco.com [64.101.220.152]) by alln-core-7.cisco.com (8.14.5/8.14.5) with ESMTP id u3RDmcQl021988 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 27 Apr 2016 13:48:38 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-012.cisco.com (64.101.220.152) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 27 Apr 2016 09:48:37 -0400
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1104.009; Wed, 27 Apr 2016 09:48:37 -0400
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Adrian Farrel <adrian@olddog.co.uk>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>
Thread-Topic: [OSPF] Rtg Dir review of draft-ietf-ospf-sbfd-discriminator-04.txt
Thread-Index: AdGghcVG0QuPS2RxQ6ajDKPyM64RjwABboyA
Date: Wed, 27 Apr 2016 13:48:37 +0000
Message-ID: <D3463A53.5D683%acee@cisco.com>
References: <069b01d1a086$46d4d470$d47e7d50$@olddog.co.uk>
In-Reply-To: <069b01d1a086$46d4d470$d47e7d50$@olddog.co.uk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.196]
Content-Type: text/plain; charset="utf-8"
Content-ID: <FBC1E7057878B24AA9A8D503509EC333@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/ospf/aIDXB-qxXCdMbYnRc20gl8gSvh0>
Cc: "draft-ietf-ospf-sbfd-discriminator.all@ietf.org" <draft-ietf-ospf-sbfd-discriminator.all@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "ospf@ietf.org" <ospf@ietf.org>
Subject: Re: [OSPF] Rtg Dir review of draft-ietf-ospf-sbfd-discriminator-04.txt
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2016 13:48:46 -0000

Hi Adrian, 

Thanks for the thorough review. See one inline.

On 4/27/16, 9:11 AM, "OSPF on behalf of Adrian Farrel"
<ospf-bounces@ietf.org on behalf of adrian@olddog.co.uk> wrote:

>Hello,
>
>I have been selected as the Routing Directorate reviewer for this draft.
>The
>Routing Directorate seeks to review all routing or routing-related drafts
>as
>they pass through IETF last call and IESG review, and sometimes on special
>request. The purpose of the review is to provide assistance to the
>Routing ADs.
>For more information about the Routing Directorate, please see
>http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>
>Although these comments are primarily for the use of the Routing ADs, it
>would be helpful if you could consider them before or along with any IETF
>Last Call comments that you receive, and strive to resolve them through
>discussion or by updating the draft.
>
>Document: draft-ietf-ospf-sbfd-discriminator-04.txt
> Reviewer: Adrian Farrel
> Review Date: 27 April 2016
> IETF LC End Date: 26 April 2016
> Intended Status: Standards Track
>
>Summary: 
>I have some minor concerns about this document that I think should be
>resolved before publication.
>
>Comments: 
>
>This is a simple document that doesn't require much to implement or
>understand.  It was disappointing, however, to find a large number of
>small issues and nits.  I don't believe any of these are blocking to
>the utility of the document and if it went for publication in its
>current state it would not be harmful.  But in the interest of making
>our documents useful and accessible, and for the purpose of eliminating
>all possible interoperability and deployment, I think it would be
>valuable to clean up the issues I have listed.
>
>Major Issues: 
>No major issues found.
>
>Minor Issues: 
>
>I should like to see some small amount of text on the scaling impact on
>OSPF. 1. How much additional information will implementations have to
>store per node/link in the network? 2. What is the expected churn in
>LSAs introduced by this mechanism (especially when the Reflector is
>turned on and off)?
>
>In the second case there is a security implication as well. Can I DoS
>the routing system by toggling some BFD Reflectors? Needs text!
>
>You *do* have...
>   A change in information in the S-BFD Discriminator TLV MUST NOT
>   trigger any SPF computation at a receiving router.
>...which is a help.
>
>---
>
>Section 1 has
>
>   This is achieved by using unique
>   network-wide discriminators to identify the Network Targets (e.g., IP
>   addresses).
>
>You may be aware of IPv6 :-)
>
>Although 2.1 gives some hints on the size of a discriminator, I had to
>go back to 5880 to check that *all* discriminators are exactly 4 octets.
>So saying "e.g., IP addresses" is at best confusing.
>
>BTW, draft-ietf-bfd-seamless-base and draft-ietf-bfd-seamless-ip don't
>give any hints on this.
>
>Oh, and what is "network-wide"?
>
>I suggest...
>
>   This is achieved by using four-octet discriminators as defined in
>   [RFC5880] to identify the Network Targets.
>
>---
>
>In Section 2 you have
>   Upon receipt of the TLV, a
>   router may decide to ignore this TLV or install the S-BFD
>   discriminator in BFD Target Identifier Table.
>
>I think "ignore" is ambiguous. You need to be very clear that "ignore"
>means:
>- take no local action
>- retain the TLV in the opaque LSA
>- continue to advertise the opaque LSA according to its scope


Since the content of opaque LSAs are, in fact, opaque to the OSPF
protocol, implementations should not modify the contents or filter the
LSA. 

Thanks,
Acee

>
>In Section 3 you also have
>   A router not supporting the S-BFD Discriminator TLV will just
>   silently ignore the TLV as specified in [RFC7770].
>
>Am I missing something when I read 7770? I don't find anything about
>handling unknown TLVs.
>
>---
>
>Section 2 para 3
>s/superset/union/ 
>("superset" would allow you to include any other discriminators!)
>
>---
>
>Section 2.1
>To be totally unambiguous...
>OLD
>   Length - Total length of the discriminator (Value field) in octets,
>   not including the optional padding.  The Length is a multiple of 4
>   octets, and consequently specifies how many Discriminators are
>   included in the TLV.
>NEW
>   Length - Total length of all discriminator in the Value field in
>   octets, not including the optional padding.  The Length is a multiple
>   of 4 octets, and consequently specifies how many Discriminators are
>   included in the TLV.
>END
>
>However (!) are you sure that you can include optional padding? I think
>that 7770 uses padding to take the V field up to a 4 octet boundary.
>Since all of your discriminators are exactly a multiple of 4 octets it
>seems that there will never be any padding and it would be less
>confusing to write...
>
>NEW
>   Length - Total length of all discriminators in the TLV counted in
>   octets.  The Length is a multiple of 4 octets, and consequently
>   specifies how many Discriminators are included in the TLV.
>END
>
>---
>
>At the end of section 2.1 you have
>
>   S-BFD discriminator is associated with the
>   BFD Target Identifier type, that allows demultiplexing to a specific
>   task or service.
>
>This is a wonderfully throw-away statement with no context and no
>further explanation in the document that I could find. Maybe this is
>just missing a reference to another document, or maybe it needs some
>clarification.
>
>---
>
>Section 2.2 has
>
>   The flooding scope for S-BFD Discriminator information advertised
>   through OSPF can be limited to one or more OSPF areas, or can be
>   extended across the entire OSPF routing domain.
>
>   Note that the S-BFD session may be required to pan multiple areas, in
>   which case the flooding scope may comprise these areas.  This could
>   be the case for an ABR, for instance, advertising the S-BFD
>   Discriminator information within the backbone area and/or a subset of
>   its attached IGP area(s).
>
>As I understand flooding scope the options for Opaque LSAs (see 5250)
>are:
>
>   o  Link-state type-9 denotes a link-local scope.
>
>   o  Link-state type-10 denotes an area-local scope.
>
>   o  Link-state type-11 denotes that the LSA is flooded throughout the
>      Autonomous System (AS).
>
>Your text seems to imply something different. In particular, you seem to
>be suggesting that I can have a scope that is greater than one area but
>less than the whole AS (assuming "whole AS" == "entire OSPF routing
>domain").
>
>This needs re-writing to clarify what you want to achieve and to bring
>it in line with 5250.
>
>Note that the 4th para of Section 2.2 seems to have this right.
>
>===
>                  
>Nits
>
>Has Trilok's affiliation changed?
>--
>Capitalise the document title
>---
>Expand acronyms in the Abstract if they do not appear with an asterisk
>in http://www.rfc-editor.org/materials/abbrev.expansion.txt
>---
>Throughout the text, expand acronyms on first use if they do not appear
>within http://www.rfc-editor.org/materials/abbrev.expansion.txt with an
>asterisk.
>---
>Decide whether "discriminator" or "Discriminator"
>---
>In 2.1 you have
>   Value - S-BFD network target discriminator value or values.
>But there is no "Value" in the figure.
>---
>2.2 para 2
>s/pan/span/
>---
>2.2
>   In the case of domain-
>   wide flooding, i.e., where the originator is sitting in a remote
>   area, the mechanism described in section 5 of [RFC5250] should be
>   used.
>s/should/SHOULD/?
>But if you mean should or SHOULD (not MUST), what are the exception
>cases?
>---
>
>Thanks,
>Adrian
>
>_______________________________________________
>OSPF mailing list
>OSPF@ietf.org
>https://www.ietf.org/mailman/listinfo/ospf