Re: [OSPF] AD review of draft-ietf-ospf-two-part-metric-05

"Acee Lindem (acee)" <acee@cisco.com> Tue, 02 August 2016 22:28 UTC

Return-Path: <acee@cisco.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C65AE12D9C6; Tue, 2 Aug 2016 15:28:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.807
X-Spam-Level:
X-Spam-Status: No, score=-15.807 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.287, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WH1YjaVykwRq; Tue, 2 Aug 2016 15:28:22 -0700 (PDT)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B1D2312D857; Tue, 2 Aug 2016 15:28:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=11277; q=dns/txt; s=iport; t=1470176901; x=1471386501; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=wBgfN236YGb+wqB3FGACyJsNevDKKL+tywRVXl9euZU=; b=BvYBBTB8BdiZmInaY8cKJiTgv5p2wXwjB/RgYLfJ5SE96SZQ9203hoEp V/ellw6rslYbtbi/gcI/3VtDkEOEaDBv8MDJBuKL4ja6eh7YmYps8kqh5 lpHF+w0BY1zdFisM85fkd/A8Bj6rU93IahnUzU9V8oHvSSeuhHq+XX+sA I=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AwAgBaHaFX/4MNJK1dgndOgVIHrQOHH?= =?us-ascii?q?oUGgX2GHQIcgSM4FAEBAQEBAQFdJ4ReAQEFI2YCAQgOAwMBAigDAgICHxEUCQg?= =?us-ascii?q?CBAESiBcDF692i1MNg00BAQEBAQEBAQIBAQEBAQEBAR+Kd4JDgVpDgmGCWgWYf?= =?us-ascii?q?zQBjEmCNYFrhFqIeoZkgUeEBYN2AR42g3puhm1FfwEBAQ?=
X-IronPort-AV: E=Sophos;i="5.28,462,1464652800"; d="scan'208,217";a="305178102"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 02 Aug 2016 22:28:20 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id u72MSKm0023418 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 2 Aug 2016 22:28:20 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 2 Aug 2016 18:28:19 -0400
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1210.000; Tue, 2 Aug 2016 18:28:19 -0400
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Alia Atlas <akatlas@gmail.com>, OSPF List <ospf@ietf.org>, "draft-ietf-ospf-two-part-metric@ietf.org" <draft-ietf-ospf-two-part-metric@ietf.org>
Thread-Topic: AD review of draft-ietf-ospf-two-part-metric-05
Thread-Index: AQHR6hErJdRTP5/JwkOb/UfQNTV8naA2RjEA
Date: Tue, 2 Aug 2016 22:28:19 +0000
Message-ID: <D3C6946B.74536%acee@cisco.com>
References: <CAG4d1reezvCeBUdou32rZJ34TeWK1gsaAUD92DA_0i3-27rj3A@mail.gmail.com>
In-Reply-To: <CAG4d1reezvCeBUdou32rZJ34TeWK1gsaAUD92DA_0i3-27rj3A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.198]
Content-Type: multipart/alternative; boundary="_000_D3C6946B74536aceeciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ospf/ho4-eSuQ5ghE_ISoSoxgN-6OMP4>
Subject: Re: [OSPF] AD review of draft-ietf-ospf-two-part-metric-05
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Aug 2016 22:28:24 -0000

Hi Alia,

Thanks for your review and progression.

From: Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>>
Date: Friday, July 29, 2016 at 11:19 PM
To: OSPF WG List <ospf@ietf.org<mailto:ospf@ietf.org>>, "draft-ietf-ospf-two-part-metric@ietf.org<mailto:draft-ietf-ospf-two-part-metric@ietf.org>" <draft-ietf-ospf-two-part-metric@ietf.org<mailto:draft-ietf-ospf-two-part-metric@ietf.org>>
Subject: AD review of draft-ietf-ospf-two-part-metric-05
Resent-From: <alias-bounces@ietf.org<mailto:alias-bounces@ietf.org>>
Resent-To: Lili Wang <liliw@juniper.net<mailto:liliw@juniper.net>>, Acee Lindem <acee@cisco.com<mailto:acee@cisco.com>>, <Dave.Dubois@gdc4s.com<mailto:Dave.Dubois@gdc4s.com>>, Vibhor Julka <vibhor.julka@l-3Com.com<mailto:vibhor.julka@l-3Com.com>>, Tom McMillan <tom.mcmillan@l-3com.com<mailto:tom.mcmillan@l-3com.com>>, Jeffrey Zhang <zzhang@juniper.net<mailto:zzhang@juniper.net>>
Resent-Date: Friday, July 29, 2016 at 11:19 PM

First, I would like to thank the authors, Jeffrey, Lili, Acee, David, Vibhor and Tom, for their work on this draft.

As is customary, I have done my AD review of draft-ietf-ospf-two-part-metric-05.
I do have a few concerns which are detailed below.  The number of authors will block progressing to IESG telechat until it is addressed.   Trusting to a timely resolution of the issues below, I am requesting IETF Last Call.  With prompt action, this document can make it to the August 18 telechat for approval.

Review Comments:

First, this fairly short document has 6 authors.   As you all well know, the usual limit for drafts progressing is 5.  This greatly simplifies the interactions during AUTH48 and there is rarely more than a few active editors.  Please consider if you can reduce it and explain to me privately what justifications might exist, if any, for not doing so.

Okay - we will do this and get back to you.


Second, please update the TBDs in the document for the various IANA allocated sub-TLV values to be TBD1, TBD2, and TBD3 so it's easier to replace during IANA and RFC Editor processing.

Yes - we will do this.


Third, Sec 3.7 defines bit 0 to have specific meaning but doesn't indicate that in the IANA section.  Please update the IANA section to clearly indicate the bit being requested (or update the bit to be a TBD4).  The term used to refer to the bit also varies between 3.7 and 4.  Please pick one term and stick with it.  In 3.7, it is "Router Functional Capability Bit" and in Sec 4, it is Router Informational Capability Bits.

Will do - it is a definitely a “Router Functional Capability Bit” as defined in RFC 7770.

Thanks,
Acee




Regards,
Alia