Re: [OSPF] Suresh Krishnan's Discuss on draft-ietf-ospf-encapsulation-cap-06: (with DISCUSS and COMMENT)

<bruno.decraene@orange.com> Mon, 18 September 2017 15:20 UTC

Return-Path: <bruno.decraene@orange.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F03E1342A1; Mon, 18 Sep 2017 08:20:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.619
X-Spam-Level:
X-Spam-Status: No, score=-1.619 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1i2KgiVEAOwl; Mon, 18 Sep 2017 08:20:13 -0700 (PDT)
Received: from relais-inet.orange.com (mta240.mail.business.static.orange.com [80.12.66.40]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6B1781321A2; Mon, 18 Sep 2017 08:20:13 -0700 (PDT)
Received: from opfedar06.francetelecom.fr (unknown [xx.xx.xx.8]) by opfedar25.francetelecom.fr (ESMTP service) with ESMTP id 039E81209A6; Mon, 18 Sep 2017 17:20:12 +0200 (CEST)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [xx.xx.31.72]) by opfedar06.francetelecom.fr (ESMTP service) with ESMTP id CFA4B80081; Mon, 18 Sep 2017 17:20:11 +0200 (CEST)
Received: from OPEXCLILM21.corporate.adroot.infra.ftgroup ([fe80::e92a:c932:907e:8f06]) by OPEXCLILMA3.corporate.adroot.infra.ftgroup ([fe80::60a9:abc3:86e6:2541%19]) with mapi id 14.03.0361.001; Mon, 18 Sep 2017 17:20:11 +0200
From: bruno.decraene@orange.com
To: Suresh Krishnan <suresh.krishnan@gmail.com>
CC: "draft-ietf-ospf-encapsulation-cap@ietf.org" <draft-ietf-ospf-encapsulation-cap@ietf.org>, Acee Lindem <acee@cisco.com>, "ospf-chairs@ietf.org" <ospf-chairs@ietf.org>, "acee@cisco.com" <acee@cisco.com>, "ospf@ietf.org" <ospf@ietf.org>, The IESG <iesg@ietf.org>
Thread-Topic: Suresh Krishnan's Discuss on draft-ietf-ospf-encapsulation-cap-06: (with DISCUSS and COMMENT)
Thread-Index: AQHTIgPXG5o8mWqhREuxDDpNkgkzhKK0XDJQ
Date: Mon, 18 Sep 2017 15:20:11 +0000
Message-ID: <10459_1505748011_59BFE42B_10459_96_12_53C29892C857584299CBF5D05346208A47879377@OPEXCLILM21.corporate.adroot.infra.ftgroup>
References: <150414779958.16833.5322499494351720362.idtracker@ietfa.amsl.com>
In-Reply-To: <150414779958.16833.5322499494351720362.idtracker@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.1]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ospf/pPqBXXpAgLM0OeBD1fuvfY8V_yo>
Subject: Re: [OSPF] Suresh Krishnan's Discuss on draft-ietf-ospf-encapsulation-cap-06: (with DISCUSS and COMMENT)
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 15:20:16 -0000

Suresh,

Thanks for the review and comments.
Please see inline [Bruno]

> From: Suresh Krishnan [mailto:suresh.krishnan@gmail.com]
 > Sent: Thursday, August 31, 2017 4:50 AM
> 
 > Suresh Krishnan has entered the following ballot position for
 > draft-ietf-ospf-encapsulation-cap-06: Discuss
 > 
 > When responding, please keep the subject line intact and reply to all
 > email addresses included in the To and CC lines. (Feel free to cut this
 > introductory paragraph, however.)
 > 
 > 
 > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
 > for more information about IESG DISCUSS and COMMENT positions.
 > 
 > 
 > The document, along with other ballot positions, can be found here:
 > https://datatracker.ietf.org/doc/draft-ietf-ospf-encapsulation-cap/
 > 
 > 
 > 
 > ----------------------------------------------------------------------
 > DISCUSS:
 > ----------------------------------------------------------------------
 > 
 > * There seems to be an difference between this document's definition of
 > sub-TLVs (with 2 octet types and lengths) and those of RFC5512 (with 1 octet
 > types and lengths). So I am surprised to see the document point to the RFC5512
 > based TLVs for both syntax and semantics (Sections 5.1, 5.2, 5.3 ...) . Can you
 > please explain how these sub-TLVs are encoded on the wire to be compatible with
 > this draft?
 
[Bruno] Would the following change works for you?

OLD:
        This Sub-TLV of type 2 is defined in Section 3.4.1 "Protocol Type
        sub-TLV" of <xref target="I-D.ietf-idr-tunnel-encaps"/> from a
        syntactic, semantic, and usage standpoint.

NEW:
        This Sub-TLV type is 2. The syntax, semantic, and usage of its value field is defined in Section 3.4.1 "Protocol Type
        sub-TLV" of <xref target="I-D.ietf-idr-tunnel-encaps"/>.


 
 > ----------------------------------------------------------------------
 > COMMENT:
 > ----------------------------------------------------------------------
 > 
 > * IANA considerations
 > 
 > Looks like the value 65535 is included both as experimental and reserved. Suggest changing
 > 
 > OLD:
 > 65500-65535    Experimental                              This document
 > 
 > NEW:
 > 65500-65534    Experimental                              This document
 > 

[Bruno] Good catch. Thanks for the careful review. Fixed as per you suggestion in -07 https://tools.ietf.org/rfcdiff?url2=draft-ietf-ospf-encapsulation-cap-07.txt

--Bruno
 

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.