Re: [P2PSIP] Jari Arkko's No Objection on draft-ietf-p2psip-diagnostics-21: (with COMMENT)

"Songhaibin (A)" <haibin.song@huawei.com> Mon, 21 March 2016 01:03 UTC

Return-Path: <haibin.song@huawei.com>
X-Original-To: p2psip@ietfa.amsl.com
Delivered-To: p2psip@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 04E2412D7FB; Sun, 20 Mar 2016 18:03:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.222
X-Spam-Level:
X-Spam-Status: No, score=-4.222 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wjV5lff7DiBu; Sun, 20 Mar 2016 18:03:37 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E6D6612D522; Sun, 20 Mar 2016 18:03:35 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml705-cah.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CLA63528; Mon, 21 Mar 2016 01:03:33 +0000 (GMT)
Received: from NKGEML404-HUB.china.huawei.com (10.98.56.35) by lhreml705-cah.china.huawei.com (10.201.5.168) with Microsoft SMTP Server (TLS) id 14.3.235.1; Mon, 21 Mar 2016 01:03:32 +0000
Received: from NKGEML513-MBX.china.huawei.com ([169.254.1.56]) by nkgeml404-hub.china.huawei.com ([10.98.56.35]) with mapi id 14.03.0235.001; Mon, 21 Mar 2016 09:03:26 +0800
From: "Songhaibin (A)" <haibin.song@huawei.com>
To: Jari Arkko <jari.arkko@piuha.net>, The IESG <iesg@ietf.org>
Thread-Topic: Jari Arkko's No Objection on draft-ietf-p2psip-diagnostics-21: (with COMMENT)
Thread-Index: AQHRgi6hJ4wRO2ehzE+4M89sweQo559jFkiw
Date: Mon, 21 Mar 2016 01:03:26 +0000
Message-ID: <E33E01DFD5BEA24B9F3F18671078951F65DD3706@nkgeml513-mbx.china.huawei.com>
References: <20160319222805.15018.68420.idtracker@ietfa.amsl.com>
In-Reply-To: <20160319222805.15018.68420.idtracker@ietfa.amsl.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.79.145]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.56EF4866.0004, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.1.56, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: c3fb951a6b64c5f919522befa4483482
Archived-At: <http://mailarchive.ietf.org/arch/msg/p2psip/-BL7f4D-PiSjvhmNsQEbL0fjaEg>
Cc: "p2psip-chairs@ietf.org" <p2psip-chairs@ietf.org>, "draft-ietf-p2psip-diagnostics@ietf.org" <draft-ietf-p2psip-diagnostics@ietf.org>, "p2psip@ietf.org" <p2psip@ietf.org>, "alexey.melnikov@isode.com" <alexey.melnikov@isode.com>
Subject: Re: [P2PSIP] Jari Arkko's No Objection on draft-ietf-p2psip-diagnostics-21: (with COMMENT)
X-BeenThere: p2psip@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Peer-to-Peer SIP working group discussion list <p2psip.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/p2psip>, <mailto:p2psip-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/p2psip/>
List-Post: <mailto:p2psip@ietf.org>
List-Help: <mailto:p2psip-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/p2psip>, <mailto:p2psip-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Mar 2016 01:03:39 -0000

Yes. That's a bug. I will fix it as Alexey suggested.

Best Regards!
-Haibin

> -----Original Message-----
> From: Jari Arkko [mailto:jari.arkko@piuha.net]
> Sent: Sunday, March 20, 2016 6:28 AM
> To: The IESG
> Cc: draft-ietf-p2psip-diagnostics@ietf.org; p2psip-chairs@ietf.org;
> cjbc@it.uc3m.es; p2psip@ietf.org; alexey.melnikov@isode.com
> Subject: Jari Arkko's No Objection on draft-ietf-p2psip-diagnostics-21: (with
> COMMENT)
> 
> Jari Arkko has entered the following ballot position for
> draft-ietf-p2psip-diagnostics-21: No Objection
> 
> When responding, please keep the subject line intact and reply to all email
> addresses included in the To and CC lines. (Feel free to cut this introductory
> paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-p2psip-diagnostics/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thanks for improving the IANA considerations section! However, Section
> 9.1 still has a bug that IMHO needs to be corrected. The reserved values need
> to be shifted in value by one, because now you have two with the value 1.
> 
> As Alexey said: "The draft has improved, however Section 9.1 still seems
> incorrect: if the first bit is reserved, then the first allocated value must be 2, so
> all other allocated values should be shifted by 1 bit."
> 
> However, I have cleared so that the shepherding AD and the WG can take care
> of this. Please make sure you fix this though, as my understanding is that if you
> didn't make the change, the protocol would not work as you intended it to
> work.
>