Re: [P2PSIP] Jari Arkko's Discuss on draft-ietf-p2psip-diagnostics-19: (with DISCUSS)

Jari Arkko <jari.arkko@piuha.net> Thu, 07 January 2016 00:34 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: p2psip@ietfa.amsl.com
Delivered-To: p2psip@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0A6CD1A1A28; Wed, 6 Jan 2016 16:34:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xqtub7AO8kQr; Wed, 6 Jan 2016 16:34:38 -0800 (PST)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 092EB1A1A00; Wed, 6 Jan 2016 16:34:38 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 14C572CCE5; Thu, 7 Jan 2016 02:34:36 +0200 (EET) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bo-6Rx0vDSP3; Thu, 7 Jan 2016 02:34:35 +0200 (EET)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 4637D2CCAE; Thu, 7 Jan 2016 02:34:35 +0200 (EET) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_0CEAF76B-59FE-47BD-8F23-ADDB6B019503"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Pgp-Agent: GPGMail 2.5.1
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <E33E01DFD5BEA24B9F3F18671078951F65DAC93C@nkgeml513-mbx.china.huawei.com>
Date: Thu, 7 Jan 2016 02:34:31 +0200
Message-Id: <11E81FFA-7187-43B4-BA99-40859D835FDD@piuha.net>
References: <20151217072025.29734.77582.idtracker@ietfa.amsl.com> <E33E01DFD5BEA24B9F3F18671078951F65DAC93C@nkgeml513-mbx.china.huawei.com>
To: "Songhaibin (A)" <haibin.song@huawei.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/p2psip/LluleoyAoXDNfUGd6LGZeacxvHQ>
Cc: "alexey.melnikov@isode.com" <alexey.melnikov@isode.com>, "p2psip-chairs@ietf.org" <p2psip-chairs@ietf.org>, "draft-ietf-p2psip-diagnostics@ietf.org" <draft-ietf-p2psip-diagnostics@ietf.org>, The IESG <iesg@ietf.org>, "p2psip@ietf.org" <p2psip@ietf.org>
Subject: Re: [P2PSIP] Jari Arkko's Discuss on draft-ietf-p2psip-diagnostics-19: (with DISCUSS)
X-BeenThere: p2psip@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Peer-to-Peer SIP working group discussion list <p2psip.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/p2psip>, <mailto:p2psip-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/p2psip/>
List-Post: <mailto:p2psip@ietf.org>
List-Help: <mailto:p2psip-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/p2psip>, <mailto:p2psip-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jan 2016 00:34:41 -0000

> In Section 5.3, it says "The dMFlags field described above is a 64 bit field that allows initiator nodes to identify up to 62 items of base information to request in a request message (the first and last flags being reserved)." 62 bits can be used to indicate up to 62 diagnostic Kinds, but dMFlags reserves all "0"s that means nothing is requested, and all "1"s that means everything is requested. But at the same time, the first and last bits cannot be used for other purposes.

Right. Can that be explained somewhere, and can Section 9.1 show the two aspects? That is, the all 0s/1s *and* first and last bits being reserved? The current text does not reserve the first and last bits. It only reserves the all 0s and all 1s…

    +-------------------------+------------------------------+----------+
    |  diagnostic information |diagnostic flag in dMFlags    | RFC      |
    |-------------------------+------------------------------+----------|
    |Reserved                 | 0x 0000 0000 0000 0000       |RFC-[TBDX]|
    |STATUS_INFO              | 0x 0000 0000 0000 0001       |RFC-[TBDX]|
    |ROUTING_TABLE_SIZE       | 0x 0000 0000 0000 0002       |RFC-[TBDX]|
    |PROCESS_POWER            | 0x 0000 0000 0000 0004       |RFC-[TBDX]|
    |UPSTREAM_BANDWIDTH       | 0x 0000 0000 0000 0008       |RFC-[TBDX]|
    |DOWNSTREAM_ BANDWIDTH    | 0x 0000 0000 0000 0010       |RFC-[TBDX]|
    |SOFTWARE_VERSION         | 0x 0000 0000 0000 0020       |RFC-[TBDX]|
    |MACHINE_UPTIME           | 0x 0000 0000 0000 0040       |RFC-[TBDX]|
    |APP_UPTIME               | 0x 0000 0000 0000 0080       |RFC-[TBDX]|
    |MEMORY_FOOTPRINT         | 0x 0000 0000 0000 0100       |RFC-[TBDX]|
    |DATASIZE_STORED          | 0x 0000 0000 0000 0200       |RFC-[TBDX]|
    |INSTANCES_STORED         | 0x 0000 0000 0000 0400       |RFC-[TBDX]|
    |MESSAGES_SENT_RCVD       | 0x 0000 0000 0000 0800       |RFC-[TBDX]|
    |EWMA_BYTES_SENT          | 0x 0000 0000 0000 1000       |RFC-[TBDX]|
    |EWMA_BYTES_RCVD          | 0x 0000 0000 0000 2000       |RFC-[TBDX]|
    |UNDERLAY_HOP             | 0x 0000 0000 0000 4000       |RFC-[TBDX]|
    |BATTERY_STATUS           | 0x 0000 0000 0000 8000       |RFC-[TBDX]|
    |Reserved                 | 0x FFFF FFFF FFFF FFFF       |RFC-[TBDX]|
    +-------------------------+------------------------------+————+

But maybe I’m missing something.

I thought the text above should be something like this instead:

    +-------------------------+------------------------------+----------+
    |  diagnostic information |diagnostic flag in dMFlags    | RFC      |
    |-------------------------+------------------------------+----------|
    |Reserved All 0s value   | 0x 0000 0000 0000 0000       |RFC-[TBDX]|
    |Reserved First Bit    | 0x 0000 0000 0000 0001       |RFC-[TBDX]|
    |STATUS_INFO              | 0x 0000 0000 0000 0002       |RFC-[TBDX]|
    |ROUTING_TABLE_SIZE       | 0x 0000 0000 0000 0004       |RFC-[TBDX]|
    |PROCESS_POWER            | 0x 0000 0000 0000 0008       |RFC-[TBDX]|
    |UPSTREAM_BANDWIDTH       | 0x 0000 0000 0000 0010       |RFC-[TBDX]|
    |DOWNSTREAM_ BANDWIDTH    | 0x 0000 0000 0000 0020       |RFC-[TBDX]|
    |SOFTWARE_VERSION         | 0x 0000 0000 0000 0040       |RFC-[TBDX]|
    |MACHINE_UPTIME           | 0x 0000 0000 0000 0080       |RFC-[TBDX]|
    |APP_UPTIME               | 0x 0000 0000 0000 0100       |RFC-[TBDX]|
    |MEMORY_FOOTPRINT         | 0x 0000 0000 0000 0200       |RFC-[TBDX]|
    |DATASIZE_STORED          | 0x 0000 0000 0000 0400       |RFC-[TBDX]|
    |INSTANCES_STORED         | 0x 0000 0000 0000 0800       |RFC-[TBDX]|
    |MESSAGES_SENT_RCVD       | 0x 0000 0000 0000 1000       |RFC-[TBDX]|
    |EWMA_BYTES_SENT          | 0x 0000 0000 0000 2000       |RFC-[TBDX]|
    |EWMA_BYTES_RCVD          | 0x 0000 0000 0000 4000       |RFC-[TBDX]|
    |UNDERLAY_HOP             | 0x 0000 0000 0000 8000       |RFC-[TBDX]|
    |BATTERY_STATUS           | 0x 0000 0000 0001 0000       |RFC-[TBDX]|
    |Reserved Last Bit              | 0x 8000 0000 0000 0000       |RFC-[TBDX]|
    |Reserved All 1s Value       | 0x FFFF FFFF FFFF FFFF       |RFC-[TBDX]|
    +-------------------------+------------------------------+————+

> 
>> 
>> Also, Section 5.3 uses "delimited" when it probably should have said
>> "terminated", unless there's more substructure in the SOFTWARE_VERSION
>> string than is identified by the text.
> 
> It is the language problem and accepted.

Thanks!

Jari