Re: [Pals] Ben Campbell's No Objection on draft-ietf-pals-p2mp-pw-03: (with COMMENT)

Stewart Bryant <stewart.bryant@gmail.com> Tue, 29 August 2017 12:17 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: pals@ietfa.amsl.com
Delivered-To: pals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E13AB132A89; Tue, 29 Aug 2017 05:17:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CCw70uuMAJP5; Tue, 29 Aug 2017 05:17:45 -0700 (PDT)
Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 145FE132396; Tue, 29 Aug 2017 05:17:42 -0700 (PDT)
Received: by mail-wm0-x22e.google.com with SMTP id t201so908686wmt.1; Tue, 29 Aug 2017 05:17:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=brVLtR3SHCEu8pvLRGbavV0l20MzE+NoPrcSXTODo7I=; b=Q8UigWPW5N6DZAC48Kr5GccYPJfue6unQtjGfxBByj2LTnZpYhsBjsNwXRUjCR2ReG bxxbel2ak1QkLilCMWX92jniulC5nBRMxHUMZE2zwmnnyQ5nTq6IKRamc6BIJ1wQkWZT uZi6f4xgjrpRMXuHzwBt8lkqGTkaPX+DDbxEgUoCy56Z/eyehT4MPPThYBEHHxbTK3FM lwPTJyUyczhAU+e92zONLCdZs/I9M/caKIJXusuyo9CuTBf4SeTkwlnti/SAvM4R0Lf7 rt3p+BIr8gXnjfKqisiBJrxAaURitniLmdesY9HB4NxVNcPNaMXt7BlUQ9QKyNz1f7FX xDCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=brVLtR3SHCEu8pvLRGbavV0l20MzE+NoPrcSXTODo7I=; b=D2qK4Y03wx8lElCarutejqjsVG+GyTJjvweV2cqS/XR3hE6WHBK2b0mf7jbIeOSh7R wB5My0wtzrTnL49Ue7NvehgnMvetvGMSiLbC7QeYUYjKHKOGVteMXeBFOzF1izGzartI pDiKCg6ui3RbV0zX/tdSZPSqZEMA1MskF/GWhzlbPv2URzq/egFUo+dnK1WoHsfKy3mf s2TamWEqeYVMOmvIC3QXhRYuAv16ntg/IigwC6WZU+tf3lWX14S89QildmcEbs330vt+ jBayffbqkCKSG7NFzXFBlEqdVyV4rIvJS0imrjEQQ3kMaFH72CrPXWx7iMXxYUF0oCf4 l4iA==
X-Gm-Message-State: AHYfb5gakltN+GNlLGg9k8gynEfu+2L7Y/Y4Xd9Ncprsryu/pTLZh0qS jpUEgfHeU9hnxP8K7mE=
X-Received: by 10.28.98.130 with SMTP id w124mr2020899wmb.121.1504009060097; Tue, 29 Aug 2017 05:17:40 -0700 (PDT)
Received: from [192.168.2.126] (host213-123-124-182.in-addr.btopenworld.com. [213.123.124.182]) by smtp.gmail.com with ESMTPSA id w9sm254259wre.58.2017.08.29.05.17.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 05:17:39 -0700 (PDT)
To: Ben Campbell <ben@nostrum.com>, The IESG <iesg@ietf.org>
Cc: draft-ietf-pals-p2mp-pw@ietf.org, pals-chairs@ietf.org, pals@ietf.org
References: <150397460616.13187.9088547841072107137.idtracker@ietfa.amsl.com>
From: Stewart Bryant <stewart.bryant@gmail.com>
Message-ID: <cbf2ef4c-9264-858a-b399-e2f1d920971b@gmail.com>
Date: Tue, 29 Aug 2017 13:17:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <150397460616.13187.9088547841072107137.idtracker@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/pals/-vVA6B-GJ0NKNiQuT3qz7F9_H-E>
Subject: Re: [Pals] Ben Campbell's No Objection on draft-ietf-pals-p2mp-pw-03: (with COMMENT)
X-BeenThere: pals@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Pseudowire And LDP-enabled Services dicussion list." <pals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pals>, <mailto:pals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pals/>
List-Post: <mailto:pals@ietf.org>
List-Help: <mailto:pals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pals>, <mailto:pals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Aug 2017 12:17:52 -0000


On 29/08/2017 03:43, Ben Campbell wrote:
> Ben Campbell has entered the following ballot position for
> draft-ietf-pals-p2mp-pw-03: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-pals-p2mp-pw/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Please check idnits. It flags some issues that should be resolved, especially
> 2119 language issues.
>
> The security considerations seem inadequate. I'm no expert here, but it seems
> like adding p2mp support in addition to p2p support has a good chance of
> creating some new considerations. If it really doesn't, it would be helpful to
> see arguments to that effect.
>
>

Hi Ben

Thank you for the review.

The RFC2119 errors are all using "MUST not" instead of "MUST NOT" the 
intent is obvious and
will surely be picked up by the RFC Editor as a matter of course.

The reference to RFC4447 is an oversight in updating from RFC4447 to 
RFC4447bis during the
gestation of the text. Again I am sure the RFC Editor would get that one.

The only other IDnit is a writespace error in ordinary text.

Clearly if there is a respin the editors should fix these points.

As to your security concern this draft is concerned with the signalling 
needed to set up the
p2mp PWs, and uses LDP exactly as any other MPLS system uses LDP so 
there are no new
security issues that arise. There is an issue with LDP needing a 
security upgrade, but that
is really outside the scope of this draft, and indeed is outside the 
scope of this WG.
We are discussing with SecDir reviewer suitable text on this point.

Best Regards

Stewart

suitable text