Re: [Pals] RtgDir review: draft-ietf-pals-vccv-for-gal-03
Stewart Bryant <stbryant@cisco.com> Tue, 26 May 2015 17:06 UTC
Return-Path: <stbryant@cisco.com>
X-Original-To: pals@ietfa.amsl.com
Delivered-To: pals@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2E191A1BB5; Tue, 26 May 2015 10:06:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.611
X-Spam-Level:
X-Spam-Status: No, score=-12.611 tagged_above=-999 required=5 tests=[BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JmdmjCLlsOkw; Tue, 26 May 2015 10:06:13 -0700 (PDT)
Received: from aer-iport-1.cisco.com (aer-iport-1.cisco.com [173.38.203.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C4A471AC3D6; Tue, 26 May 2015 10:06:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=60812; q=dns/txt; s=iport; t=1432659968; x=1433869568; h=message-id:date:from:reply-to:mime-version:to:cc:subject: references:in-reply-to; bh=F+nSP8axfAeyBwTYKgN3WvoMksKgb3kzu5ENEi95ccc=; b=YtLru3JvPq2RBGzbKCUcP3zknFD/FqLT62/wz014Jx48Lyb4heNgYLfQ z35lIiaG2TEjFQ8hUy1yS8pPtEX3DCykKLatjY3h+1ils8mTh9onBTMU8 QKaPVA9HGXhd1IWMvwqwROkSGc273T36i6w835e1Jp9csbum+f3jvhRCS 0=;
X-Files: draft-ietf-pals-vccv-for-gal-03-SB.docx : 37511
X-IronPort-AV: E=Sophos;i="5.13,499,1427760000"; d="xml'?rels'?docx'72,48?scan'72,48,72,217,208,48";a="515721890"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-1.cisco.com with ESMTP; 26 May 2015 17:06:06 +0000
Received: from [64.103.106.148] (dhcp-bdlk10-data-vlan300-64-103-106-148.cisco.com [64.103.106.148]) by aer-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id t4QH65C2026769; Tue, 26 May 2015 17:06:06 GMT
Message-ID: <5564A800.8050904@cisco.com>
Date: Tue, 26 May 2015 18:06:08 +0100
From: Stewart Bryant <stbryant@cisco.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Loa Andersson <loa@pi.nu>, draft-ietf-pals-vccv-for-gal.all@tools.ietf.org, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
References: <5559ACFF.3080104@pi.nu>
In-Reply-To: <5559ACFF.3080104@pi.nu>
Content-Type: multipart/mixed; boundary="------------060505010501050000050102"
Archived-At: <http://mailarchive.ietf.org/arch/msg/pals/o3AtkNvU7590XpCd_x2nVYwBha8>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "pals-chairs@tools.ietf.org" <pals-chairs@tools.ietf.org>, "pals@ietf.org" <pals@ietf.org>
Subject: Re: [Pals] RtgDir review: draft-ietf-pals-vccv-for-gal-03
X-BeenThere: pals@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: stbryant@cisco.com
List-Id: "Pseudowire And LDP-enabled Services dicussion list." <pals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pals>, <mailto:pals-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pals/>
List-Post: <mailto:pals@ietf.org>
List-Help: <mailto:pals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pals>, <mailto:pals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2015 17:06:16 -0000
On 18/05/2015 10:12, Loa Andersson wrote: Thank you for the review. > > Summary: > > - This document is basically ready for publication, but has nits that > should be considered prior to publication. > Note: I also have a question about a security statement in the draft > that I don't know if it has been addressed. > > > Comments: > - Overview of the draft quality and readability. > The document is technically sound. > The document is sometimes a bit hard to read, but I guess that > will be sorted out by the RFC Editor. > > > - Anything else that you think will be helpful toward understanding > your review. > I normally do my reviews by Word with change bars and comments, > I've included that file for details. Please see attached word file with comments on your comments > > Major Issues: > - I put the question on the security statement at the end of the > second paragraph in the Introduction here. I'm not sure it is a > major issue, but I want to lift to make sure that it is properly > discussed. > > If I understand correctly "..., and is a security risk" refers to the > fact that OAM packets might be sent over the attachment circuit(s) if > the TTL is not set right. > > OAM packets on the attachment circuit as the specific problems this > could involve is not listed as a security risk in 6073. The security > section of 6073 talks about the possibilities that pay load packets > are forwarded on to the attachment circuit, but does not say anything > about OAM packets. The threat is called up in 13.1.1 <https://tools.ietf.org/html/rfc6073#section-13.1.1>. VCCV Security Considerations of RFC 6073 which talks about VCCV i.e. OAM packets, however this text provides a new solution to the problem. I would like to hear from the ADs on whether this alternate mitigation to the TTL error warrants an update to RFC 6073 being noted. > > > Minor Issues: > - I think I could say "No minor issues found" and say that everything > else is nit, but since some of the thing captured in the word file > are for clarity, e.g. the last paragraph in section 4 (fate sharing) > and the first paragraph in section 5 (what MUST be inspected), so I > guess that there are things that sits on the fence between minor and > nits. However, I think that they are very easy to resolve, in that > respect they can be treated as nits. > - A second minor issue is that I find the Abstract less informative than > I would want, it should be beefed up and clarified a bit. Please see t he word file on the above. > > Nits: > - The rest of the comments in the word file are nits, e.g.: > > -- Naming of the new channel (I think these to names refer to the > same thing > MPLS VCCV Control Channel (CC) > GAL VCCV Control Channel Type > > -- expanding abbreviations the first time they are used > > -- expanding all abbreviations that is not on the RFC Editors > list of well-known All dealt with - Stewart > > /Loa > -- For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html
- [Pals] RtgDir review: draft-ietf-pals-vccv-for-ga… Loa Andersson
- Re: [Pals] RtgDir review: draft-ietf-pals-vccv-fo… Stewart Bryant
- Re: [Pals] RtgDir review: draft-ietf-pals-vccv-fo… Loa Andersson