Re: [Pana] Fwd: New Version Notification for draft-yegin-pana-encr-avp-01.txt

Yasuyuki Tanaka <yatch@isl.rdc.toshiba.co.jp> Mon, 26 March 2012 06:00 UTC

Return-Path: <yatch@isl.rdc.toshiba.co.jp>
X-Original-To: pana@ietfa.amsl.com
Delivered-To: pana@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C711921E8082 for <pana@ietfa.amsl.com>; Sun, 25 Mar 2012 23:00:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.089
X-Spam-Level:
X-Spam-Status: No, score=-6.089 tagged_above=-999 required=5 tests=[AWL=2.000, BAYES_00=-2.599, HELO_EQ_JP=1.244, HOST_EQ_JP=1.265, RCVD_IN_DNSWL_HI=-8, UNPARSEABLE_RELAY=0.001]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vU+VTZ-CTDZN for <pana@ietfa.amsl.com>; Sun, 25 Mar 2012 23:00:15 -0700 (PDT)
Received: from imx12.toshiba.co.jp (imx12.toshiba.co.jp [61.202.160.132]) by ietfa.amsl.com (Postfix) with ESMTP id B215521E8064 for <pana@ietf.org>; Sun, 25 Mar 2012 23:00:11 -0700 (PDT)
Received: from arc11.toshiba.co.jp ([133.199.90.127]) by imx12.toshiba.co.jp with ESMTP id q2Q609IK010878 for <pana@ietf.org>; Mon, 26 Mar 2012 15:00:09 +0900 (JST)
Received: (from root@localhost) by arc11.toshiba.co.jp id q2Q609SE024742 for pana@ietf.org; Mon, 26 Mar 2012 15:00:09 +0900 (JST)
Received: from ovp11.toshiba.co.jp [133.199.90.148] by arc11.toshiba.co.jp with ESMTP id RAA24739; Mon, 26 Mar 2012 15:00:09 +0900
Received: from mx2.toshiba.co.jp (localhost [127.0.0.1]) by ovp11.toshiba.co.jp with ESMTP id q2Q608bh012679 for <pana@ietf.org>; Mon, 26 Mar 2012 15:00:08 +0900 (JST)
Received: from spiffy21.isl.rdc.toshiba.co.jp by toshiba.co.jp id q2Q608eX006785; Mon, 26 Mar 2012 15:00:08 +0900 (JST)
Received: from [133.196.16.146] (ncg-dhcp146.isl.rdc.toshiba.co.jp [133.196.16.146]) by spiffy21.isl.rdc.toshiba.co.jp (Postfix) with ESMTPS id 9445F97C8B; Mon, 26 Mar 2012 15:00:08 +0900 (JST)
Message-ID: <4F7005FF.4030609@isl.rdc.toshiba.co.jp>
Date: Mon, 26 Mar 2012 15:00:31 +0900
From: Yasuyuki Tanaka <yatch@isl.rdc.toshiba.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: pana@ietf.org
References: <20120104095307.27035.33867.idtracker@ietfa.amsl.com> <4F631E51.6030302@gridmerge.com>
In-Reply-To: <4F631E51.6030302@gridmerge.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Pana] Fwd: New Version Notification for draft-yegin-pana-encr-avp-01.txt
X-BeenThere: pana@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Protocol for carrying Authentication for Network Access <pana.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pana>, <mailto:pana-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pana>
List-Post: <mailto:pana@ietf.org>
List-Help: <mailto:pana-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pana>, <mailto:pana-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Mar 2012 06:00:16 -0000

Hi,

I've read the draft and I have four comments. Please see them below.

Best,
Yasuyuki Tanaka

---------------------------------------------------------------------

(1) Section 3
I found a typo in the last sentence.

 >   The length of PANA_ENCR_KEY depends on the integrity algorithm in
 >   use.

should be

     The length of PANA_ENCR_KEY depends on the *encryption* algorithm in
     use.

---------------------------------------------------------------------

(2) Section 4
I've not found text about key size of AES to be used for
AES_CTR. Probably 128-bit is assumed.

It would be better to clarify the key size to be used for the
algorithm and to use "AES128_CTR" or something instead of "AES_CTR".

---------------------------------------------------------------------

(3) Section 4
The definition of "q" is different between the draft and NIST
SP800-38C. In this draft, "q" is defined as "octet length of message
length field." But in NIST SP800-38C, "q" is defined as "The octet
length of the binary representation of the octet length of the
payload."

In addition, I don't realize what 'length of message length field'
means... Why is "q" 3? The length of "Message Length" field of PANA
Message Header is 2 octets...

Anyway, I think the following part might cause some confusion.

 >      AES-CTR (Counter) encryption algorithm as specified in
 >      [NIST_SP800_38A].  The formatting function and counter generation
 >      function as specified in Appendix A of [NIST_SP800_38C] are used,
 >      with the following parameters:
 >
 >
 >            n, octet length of nonce, is 12.
 >            q, octet length of message length field, is 3.

IMHO, it's better to say just "q is 3" as the definition of "q".

---------------------------------------------------------------------

(4) Section 4
It would be very helpful to provide an example of the first counter.

When Key-Id is 0x55667788, Session ID is 0xaabbccdd, and Sequence
Number is 0x11223344, the correct first counter is
0x0255667788aabbccdd11223344000001. is it correct?

---------------------------------------------------------------------

(2012/03/16 20:04), Robert Cragie wrote:
> I would like to move this forward so I am soliciting any comments from
> the PANA mailing list.
>
> Thanks
>
> Robert
>
> -------- Original Message --------
> Subject: 	New Version Notification for draft-yegin-pana-encr-avp-01.txt
> Date: 	Wed, 04 Jan 2012 01:53:07 -0800
> From: 	internet-drafts@ietf.org
> To: 	alper.yegin@yegin.org
> CC: 	robert.cragie@gridmerge.com, alper.yegin@yegin.org
>
>
>
> A new version of I-D, draft-yegin-pana-encr-avp-01.txt has been successfully submitted by Alper Yegin and posted to the IETF repository.
>
> Filename:	 draft-yegin-pana-encr-avp
> Revision:	 01
> Title:		 Encrypting PANA AVPs
> Creation date:	 2012-01-04
> WG ID:		 Individual Submission
> Number of pages: 8
>
> Abstract:
>     This document specifies a mechanism for delivering PANA (Protocol for
>     Carrying Authentication for Network Access) AVPs (Attribute-Value
>     Pairs) in encrypted form.
>
>
>
>
> The IETF Secretariat
>
>
>
>
> _______________________________________________
> Pana mailing list
> Pana@ietf.org
> https://www.ietf.org/mailman/listinfo/pana